From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7469625; Sat, 20 Apr 2024 04:24:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713587053; cv=none; b=VhWLqgak1Me5Cq17UDoX0QXk5gkU+nrxjDO8pZPvjSfj9wdd6re/jCFHzfxqtTYo8mur88T2jhfgBCNc3y2AAbsRUDEQ9DI5HbL5TpAq33FX2m0IJzD79DUYiegmUH9tj2dAQMnq56wncp5pNuq6/pJRWi43VnntYAppSasH6gE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713587053; c=relaxed/simple; bh=XIe/vC5nJoDDEu9/Q7ZoXeJlkdIzu3x0dG0pVHSQyaU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=d/F3neD3QRJUKWQQrsGReOJCd+id8uImiaYCDBFlCN1puOdsR7K4TtL+9KwScLfGZ6B+uxNZcg6TXPXy8rzXEikkur2n5rfEuGJ+qM4ICOq7CQpbGshFuy1tQ/sse2zqGqjMfqM6U2FRv+QXhb/B0VfeN6sdV9pt8q3w1sYUOn4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YhvasTWv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YhvasTWv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83904C072AA; Sat, 20 Apr 2024 04:24:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713587052; bh=XIe/vC5nJoDDEu9/Q7ZoXeJlkdIzu3x0dG0pVHSQyaU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YhvasTWvPZXPkThPYjnuTXJtKsDsFI6ZK4Bt9IvngW4VcopIHwZq0rN2TN47VCWUq FBJkDpR2DtP+unWDJY8C7sJEQiAOVs8L9KzXsojOjPLi6kQ9YDHioYtZ6nUFM1e0iU J5CLWhI8Oh/UQKju6kDG7HnVFfwfwBxuIE1OR267WnG9gRFiBTNZwpWVx17pWQtTrY fdbuHV6o8S3vVJ6wqWsJuIqtAsaxpsI2nzHYz53bqy1qeEbZ3ljz7qw9wo3USiXNjB OSy86A07SSbIPPzvVI3U5+/bWUkfoO6zoETP+0NHBuzBlMRXY9HoUBu5v7wjVTOH+s DowdwAPfYuE4g== Date: Sat, 20 Apr 2024 07:22:50 +0300 From: Mike Rapoport To: Song Liu Cc: Mark Rutland , Peter Zijlstra , linux-kernel@vger.kernel.org, Alexandre Ghiti , Andrew Morton , Bjorn Topel , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Donald Dutile , Eric Chanudet , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Michael Ellerman , Nadav Amit , Palmer Dabbelt , Puranjay Mohan , Rick Edgecombe , Russell King , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v4 05/15] mm: introduce execmem_alloc() and execmem_free() Message-ID: References: Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Apr 19, 2024 at 02:42:16PM -0700, Song Liu wrote: > On Fri, Apr 19, 2024 at 1:00 PM Mike Rapoport wrote: > > > > On Fri, Apr 19, 2024 at 10:32:39AM -0700, Song Liu wrote: > > > On Fri, Apr 19, 2024 at 10:03 AM Mike Rapoport wrote: > > > [...] > > > > > > > > > > > > [1] https://lore.kernel.org/all/20240411160526.2093408-1-rppt@kernel.org > > > > > > > > > > For the ROX to work, we need different users (module text, kprobe, etc.) to have > > > > > the same execmem_range. From [1]: > > > > > > > > > > static void *execmem_cache_alloc(struct execmem_range *range, size_t size) > > > > > { > > > > > ... > > > > > p = __execmem_cache_alloc(size); > > > > > if (p) > > > > > return p; > > > > > err = execmem_cache_populate(range, size); > > > > > ... > > > > > } > > > > > > > > > > We are calling __execmem_cache_alloc() without range. For this to work, > > > > > we can only call execmem_cache_alloc() with one execmem_range. > > > > > > > > Actually, on x86 this will "just work" because everything shares the same > > > > address space :) > > > > > > > > The 2M pages in the cache will be in the modules space, so > > > > __execmem_cache_alloc() will always return memory from that address space. > > > > > > > > For other architectures this indeed needs to be fixed with passing the > > > > range to __execmem_cache_alloc() and limiting search in the cache for that > > > > range. > > > > > > I think we at least need the "map to" concept (initially proposed by Thomas) > > > to get this work. For example, EXECMEM_BPF and EXECMEM_KPROBE > > > maps to EXECMEM_MODULE_TEXT, so that all these actually share > > > the same range. > > > > Why? > > IIUC, we need to update __execmem_cache_alloc() to take a range pointer as > input. module text will use "range" for EXECMEM_MODULE_TEXT, while kprobe > will use "range" for EXECMEM_KPROBE. Without "map to" concept or sharing > the "range" object, we will have to compare different range parameters to check > we can share cached pages between module text and kprobe, which is not > efficient. Did I miss something? We can always share large ROX pages as long as they are within the correct address space. The permissions for them are ROX and the alignment differences are due to KASAN and this is handled during allocation of the large page to refill the cache. __execmem_cache_alloc() only needs to limit the search for the address space of the range. And regardless, they way we deal with sharing of the cache can be sorted out later. > Thanks, > Song -- Sincerely yours, Mike. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29A99C04FFE for ; Sat, 20 Apr 2024 04:24:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YiZttxwnMKS5V5YQ8Ob7Igp+dSbtRtAPvSeUzKpyTkU=; b=ptcuWBOWsESABZ 2xWe6DNjyVoum33Z+6tNGZi44orjXSVI4EnR5Rh8wVJHB4JPI2vhKsYQH99PHZd36/uNAhIpMH5CE yVQsijva9FkbsHLQ2KhZSerulekPx3Pjk92yzO2fjWfg9Seot6HOOSGEsry3+xQvFBLAxM15Au5v8 CI3ZD5B6IcMin92vtMAw8x6kaF++aWqu7yIiACNTE//9NwIhwnU1tS+YUgWTVTfNZsVyPjLrUS2aX hzxZ2FEGxSjPDDnkYs7bD7/hFYwqqQb3ZTyMPoqn28LcyL7cu41WYYDjQThbVLHAiZpOzCMJ/kwIN b9Z4p4VvUnI+poa0B+Xg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ry2Gx-00000007lvt-0GhH; Sat, 20 Apr 2024 04:24:19 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ry2Gs-00000007lu6-40XH; Sat, 20 Apr 2024 04:24:16 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1D0AA60C70; Sat, 20 Apr 2024 04:24:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83904C072AA; Sat, 20 Apr 2024 04:24:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713587052; bh=XIe/vC5nJoDDEu9/Q7ZoXeJlkdIzu3x0dG0pVHSQyaU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YhvasTWvPZXPkThPYjnuTXJtKsDsFI6ZK4Bt9IvngW4VcopIHwZq0rN2TN47VCWUq FBJkDpR2DtP+unWDJY8C7sJEQiAOVs8L9KzXsojOjPLi6kQ9YDHioYtZ6nUFM1e0iU J5CLWhI8Oh/UQKju6kDG7HnVFfwfwBxuIE1OR267WnG9gRFiBTNZwpWVx17pWQtTrY fdbuHV6o8S3vVJ6wqWsJuIqtAsaxpsI2nzHYz53bqy1qeEbZ3ljz7qw9wo3USiXNjB OSy86A07SSbIPPzvVI3U5+/bWUkfoO6zoETP+0NHBuzBlMRXY9HoUBu5v7wjVTOH+s DowdwAPfYuE4g== Date: Sat, 20 Apr 2024 07:22:50 +0300 From: Mike Rapoport To: Song Liu Cc: Mark Rutland , Peter Zijlstra , linux-kernel@vger.kernel.org, Alexandre Ghiti , Andrew Morton , Bjorn Topel , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Donald Dutile , Eric Chanudet , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Michael Ellerman , Nadav Amit , Palmer Dabbelt , Puranjay Mohan , Rick Edgecombe , Russell King , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v4 05/15] mm: introduce execmem_alloc() and execmem_free() Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240419_212415_114454_E2C54898 X-CRM114-Status: GOOD ( 26.44 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gRnJpLCBBcHIgMTksIDIwMjQgYXQgMDI6NDI6MTZQTSAtMDcwMCwgU29uZyBMaXUgd3JvdGU6 Cj4gT24gRnJpLCBBcHIgMTksIDIwMjQgYXQgMTowMOKAr1BNIE1pa2UgUmFwb3BvcnQgPHJwcHRA a2VybmVsLm9yZz4gd3JvdGU6Cj4gPgo+ID4gT24gRnJpLCBBcHIgMTksIDIwMjQgYXQgMTA6MzI6 MzlBTSAtMDcwMCwgU29uZyBMaXUgd3JvdGU6Cj4gPiA+IE9uIEZyaSwgQXByIDE5LCAyMDI0IGF0 IDEwOjAz4oCvQU0gTWlrZSBSYXBvcG9ydCA8cnBwdEBrZXJuZWwub3JnPiB3cm90ZToKPiA+ID4g Wy4uLl0KPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gWzFdIGh0dHBzOi8vbG9yZS5rZXJuZWwub3Jn L2FsbC8yMDI0MDQxMTE2MDUyNi4yMDkzNDA4LTEtcnBwdEBrZXJuZWwub3JnCj4gPiA+ID4gPgo+ ID4gPiA+ID4gRm9yIHRoZSBST1ggdG8gd29yaywgd2UgbmVlZCBkaWZmZXJlbnQgdXNlcnMgKG1v ZHVsZSB0ZXh0LCBrcHJvYmUsIGV0Yy4pIHRvIGhhdmUKPiA+ID4gPiA+IHRoZSBzYW1lIGV4ZWNt ZW1fcmFuZ2UuIEZyb20gWzFdOgo+ID4gPiA+ID4KPiA+ID4gPiA+IHN0YXRpYyB2b2lkICpleGVj bWVtX2NhY2hlX2FsbG9jKHN0cnVjdCBleGVjbWVtX3JhbmdlICpyYW5nZSwgc2l6ZV90IHNpemUp Cj4gPiA+ID4gPiB7Cj4gPiA+ID4gPiAuLi4KPiA+ID4gPiA+ICAgICAgICBwID0gX19leGVjbWVt X2NhY2hlX2FsbG9jKHNpemUpOwo+ID4gPiA+ID4gICAgICAgIGlmIChwKQo+ID4gPiA+ID4gICAg ICAgICAgICAgICAgcmV0dXJuIHA7Cj4gPiA+ID4gPiAgICAgICBlcnIgPSBleGVjbWVtX2NhY2hl X3BvcHVsYXRlKHJhbmdlLCBzaXplKTsKPiA+ID4gPiA+IC4uLgo+ID4gPiA+ID4gfQo+ID4gPiA+ ID4KPiA+ID4gPiA+IFdlIGFyZSBjYWxsaW5nIF9fZXhlY21lbV9jYWNoZV9hbGxvYygpIHdpdGhv dXQgcmFuZ2UuIEZvciB0aGlzIHRvIHdvcmssCj4gPiA+ID4gPiB3ZSBjYW4gb25seSBjYWxsIGV4 ZWNtZW1fY2FjaGVfYWxsb2MoKSB3aXRoIG9uZSBleGVjbWVtX3JhbmdlLgo+ID4gPiA+Cj4gPiA+ ID4gQWN0dWFsbHksIG9uIHg4NiB0aGlzIHdpbGwgImp1c3Qgd29yayIgYmVjYXVzZSBldmVyeXRo aW5nIHNoYXJlcyB0aGUgc2FtZQo+ID4gPiA+IGFkZHJlc3Mgc3BhY2UgOikKPiA+ID4gPgo+ID4g PiA+IFRoZSAyTSBwYWdlcyBpbiB0aGUgY2FjaGUgd2lsbCBiZSBpbiB0aGUgbW9kdWxlcyBzcGFj ZSwgc28KPiA+ID4gPiBfX2V4ZWNtZW1fY2FjaGVfYWxsb2MoKSB3aWxsIGFsd2F5cyByZXR1cm4g bWVtb3J5IGZyb20gdGhhdCBhZGRyZXNzIHNwYWNlLgo+ID4gPiA+Cj4gPiA+ID4gRm9yIG90aGVy IGFyY2hpdGVjdHVyZXMgdGhpcyBpbmRlZWQgbmVlZHMgdG8gYmUgZml4ZWQgd2l0aCBwYXNzaW5n IHRoZQo+ID4gPiA+IHJhbmdlIHRvIF9fZXhlY21lbV9jYWNoZV9hbGxvYygpIGFuZCBsaW1pdGlu ZyBzZWFyY2ggaW4gdGhlIGNhY2hlIGZvciB0aGF0Cj4gPiA+ID4gcmFuZ2UuCj4gPiA+Cj4gPiA+ IEkgdGhpbmsgd2UgYXQgbGVhc3QgbmVlZCB0aGUgIm1hcCB0byIgY29uY2VwdCAoaW5pdGlhbGx5 IHByb3Bvc2VkIGJ5IFRob21hcykKPiA+ID4gdG8gZ2V0IHRoaXMgd29yay4gRm9yIGV4YW1wbGUs IEVYRUNNRU1fQlBGIGFuZCBFWEVDTUVNX0tQUk9CRQo+ID4gPiBtYXBzIHRvIEVYRUNNRU1fTU9E VUxFX1RFWFQsIHNvIHRoYXQgYWxsIHRoZXNlIGFjdHVhbGx5IHNoYXJlCj4gPiA+IHRoZSBzYW1l IHJhbmdlLgo+ID4KPiA+IFdoeT8KPiAKPiBJSVVDLCB3ZSBuZWVkIHRvIHVwZGF0ZSBfX2V4ZWNt ZW1fY2FjaGVfYWxsb2MoKSB0byB0YWtlIGEgcmFuZ2UgcG9pbnRlciBhcwo+IGlucHV0LiBtb2R1 bGUgdGV4dCB3aWxsIHVzZSAicmFuZ2UiIGZvciBFWEVDTUVNX01PRFVMRV9URVhULCB3aGlsZSBr cHJvYmUKPiB3aWxsIHVzZSAicmFuZ2UiIGZvciBFWEVDTUVNX0tQUk9CRS4gV2l0aG91dCAibWFw IHRvIiBjb25jZXB0IG9yIHNoYXJpbmcKPiB0aGUgInJhbmdlIiBvYmplY3QsIHdlIHdpbGwgaGF2 ZSB0byBjb21wYXJlIGRpZmZlcmVudCByYW5nZSBwYXJhbWV0ZXJzIHRvIGNoZWNrCj4gd2UgY2Fu IHNoYXJlIGNhY2hlZCBwYWdlcyBiZXR3ZWVuIG1vZHVsZSB0ZXh0IGFuZCBrcHJvYmUsIHdoaWNo IGlzIG5vdAo+IGVmZmljaWVudC4gRGlkIEkgbWlzcyBzb21ldGhpbmc/CgpXZSBjYW4gYWx3YXlz IHNoYXJlIGxhcmdlIFJPWCBwYWdlcyBhcyBsb25nIGFzIHRoZXkgYXJlIHdpdGhpbiB0aGUgY29y cmVjdAphZGRyZXNzIHNwYWNlLiBUaGUgcGVybWlzc2lvbnMgZm9yIHRoZW0gYXJlIFJPWCBhbmQg dGhlIGFsaWdubWVudApkaWZmZXJlbmNlcyBhcmUgZHVlIHRvIEtBU0FOIGFuZCB0aGlzIGlzIGhh bmRsZWQgZHVyaW5nIGFsbG9jYXRpb24gb2YgdGhlCmxhcmdlIHBhZ2UgdG8gcmVmaWxsIHRoZSBj YWNoZS4gX19leGVjbWVtX2NhY2hlX2FsbG9jKCkgb25seSBuZWVkcyB0byBsaW1pdAp0aGUgc2Vh cmNoIGZvciB0aGUgYWRkcmVzcyBzcGFjZSBvZiB0aGUgcmFuZ2UuCgpBbmQgcmVnYXJkbGVzcywg dGhleSB3YXkgd2UgZGVhbCB3aXRoIHNoYXJpbmcgb2YgdGhlIGNhY2hlIGNhbiBiZSBzb3J0ZWQK b3V0IGxhdGVyLgoKPiBUaGFua3MsCj4gU29uZwoKLS0gClNpbmNlcmVseSB5b3VycywKTWlrZS4K Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LXJp c2N2IG1haWxpbmcgbGlzdApsaW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcmlzY3YK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78A63C4345F for ; Sat, 20 Apr 2024 04:25:01 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=YhvasTWv; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4VLz234V7mz3dKF for ; Sat, 20 Apr 2024 14:24:59 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=YhvasTWv; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=rppt@kernel.org; receiver=lists.ozlabs.org) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4VLz1F4Vprz3c4P for ; Sat, 20 Apr 2024 14:24:17 +1000 (AEST) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1D0AA60C70; Sat, 20 Apr 2024 04:24:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83904C072AA; Sat, 20 Apr 2024 04:24:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713587052; bh=XIe/vC5nJoDDEu9/Q7ZoXeJlkdIzu3x0dG0pVHSQyaU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YhvasTWvPZXPkThPYjnuTXJtKsDsFI6ZK4Bt9IvngW4VcopIHwZq0rN2TN47VCWUq FBJkDpR2DtP+unWDJY8C7sJEQiAOVs8L9KzXsojOjPLi6kQ9YDHioYtZ6nUFM1e0iU J5CLWhI8Oh/UQKju6kDG7HnVFfwfwBxuIE1OR267WnG9gRFiBTNZwpWVx17pWQtTrY fdbuHV6o8S3vVJ6wqWsJuIqtAsaxpsI2nzHYz53bqy1qeEbZ3ljz7qw9wo3USiXNjB OSy86A07SSbIPPzvVI3U5+/bWUkfoO6zoETP+0NHBuzBlMRXY9HoUBu5v7wjVTOH+s DowdwAPfYuE4g== Date: Sat, 20 Apr 2024 07:22:50 +0300 From: Mike Rapoport To: Song Liu Subject: Re: [PATCH v4 05/15] mm: introduce execmem_alloc() and execmem_free() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , x86@kernel.org, Peter Zijlstra , Catalin Marinas , Russell King , linux-mm@kvack.org, Donald Dutile , sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, Nadav Amit , linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Helge Deller , Huacai Chen , Luis Chamberlain , linux-mips@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Alexandre Ghiti , Will Deacon , Heiko Carstens , Steven Rostedt , loongarch@lists.linux.dev, Thomas Gleixner , bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Thomas Bogendoerfer , linux-parisc@vger.kernel.org, Puranjay Mohan , netdev@vger.kernel.org, Kent Overstreet , linux-kernel@vger.kernel.org, Dinh Nguyen , Bjorn Topel , Eric Chanudet , Palmer Dabbelt , Andrew Morton , Rick Edgecombe , linuxppc-dev@lists.ozlabs.org, "David S. Miller" , linux-modules@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Apr 19, 2024 at 02:42:16PM -0700, Song Liu wrote: > On Fri, Apr 19, 2024 at 1:00 PM Mike Rapoport wrote: > > > > On Fri, Apr 19, 2024 at 10:32:39AM -0700, Song Liu wrote: > > > On Fri, Apr 19, 2024 at 10:03 AM Mike Rapoport wrote: > > > [...] > > > > > > > > > > > > [1] https://lore.kernel.org/all/20240411160526.2093408-1-rppt@kernel.org > > > > > > > > > > For the ROX to work, we need different users (module text, kprobe, etc.) to have > > > > > the same execmem_range. From [1]: > > > > > > > > > > static void *execmem_cache_alloc(struct execmem_range *range, size_t size) > > > > > { > > > > > ... > > > > > p = __execmem_cache_alloc(size); > > > > > if (p) > > > > > return p; > > > > > err = execmem_cache_populate(range, size); > > > > > ... > > > > > } > > > > > > > > > > We are calling __execmem_cache_alloc() without range. For this to work, > > > > > we can only call execmem_cache_alloc() with one execmem_range. > > > > > > > > Actually, on x86 this will "just work" because everything shares the same > > > > address space :) > > > > > > > > The 2M pages in the cache will be in the modules space, so > > > > __execmem_cache_alloc() will always return memory from that address space. > > > > > > > > For other architectures this indeed needs to be fixed with passing the > > > > range to __execmem_cache_alloc() and limiting search in the cache for that > > > > range. > > > > > > I think we at least need the "map to" concept (initially proposed by Thomas) > > > to get this work. For example, EXECMEM_BPF and EXECMEM_KPROBE > > > maps to EXECMEM_MODULE_TEXT, so that all these actually share > > > the same range. > > > > Why? > > IIUC, we need to update __execmem_cache_alloc() to take a range pointer as > input. module text will use "range" for EXECMEM_MODULE_TEXT, while kprobe > will use "range" for EXECMEM_KPROBE. Without "map to" concept or sharing > the "range" object, we will have to compare different range parameters to check > we can share cached pages between module text and kprobe, which is not > efficient. Did I miss something? We can always share large ROX pages as long as they are within the correct address space. The permissions for them are ROX and the alignment differences are due to KASAN and this is handled during allocation of the large page to refill the cache. __execmem_cache_alloc() only needs to limit the search for the address space of the range. And regardless, they way we deal with sharing of the cache can be sorted out later. > Thanks, > Song -- Sincerely yours, Mike. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F5D0C4345F for ; Sat, 20 Apr 2024 04:24:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2nV84s9y7I2Xo5qBpv44eLv1zD7te3QiLt/zxGJTI9o=; b=yHw9uoybVcQHq0 AYkI/1cwPA983iDaoT9+mvQDDACwi2hegGKKchP7o6U8kMaoQ7FRZLKYEg3P9u6Q+wVmep6Spn78V aGRqg5c9OYUX13Iw2gtzUY2Rd3LPIRx8ioIvjbx+FyZliSpMxn61g3lmmPCgi4QXA2gvN1ajkyTy4 G4x8JAondR8z83DdJqSeToCJbaRBfZvKZEciB2ktLrlyqytCIiGe0oUxrGBD2uOD3jesThnfgrK76 TNrK4dNWWQ9OVuGMnVgj2XvYcqz83xRkMQ6MfHninpkA0kAMPIOue0JVlwQI9bLOGonluHAEPIMtc DPzzx5vb+qAB5GX21Mug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ry2Gw-00000007lvi-1biy; Sat, 20 Apr 2024 04:24:18 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ry2Gs-00000007lu6-40XH; Sat, 20 Apr 2024 04:24:16 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1D0AA60C70; Sat, 20 Apr 2024 04:24:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83904C072AA; Sat, 20 Apr 2024 04:24:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713587052; bh=XIe/vC5nJoDDEu9/Q7ZoXeJlkdIzu3x0dG0pVHSQyaU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YhvasTWvPZXPkThPYjnuTXJtKsDsFI6ZK4Bt9IvngW4VcopIHwZq0rN2TN47VCWUq FBJkDpR2DtP+unWDJY8C7sJEQiAOVs8L9KzXsojOjPLi6kQ9YDHioYtZ6nUFM1e0iU J5CLWhI8Oh/UQKju6kDG7HnVFfwfwBxuIE1OR267WnG9gRFiBTNZwpWVx17pWQtTrY fdbuHV6o8S3vVJ6wqWsJuIqtAsaxpsI2nzHYz53bqy1qeEbZ3ljz7qw9wo3USiXNjB OSy86A07SSbIPPzvVI3U5+/bWUkfoO6zoETP+0NHBuzBlMRXY9HoUBu5v7wjVTOH+s DowdwAPfYuE4g== Date: Sat, 20 Apr 2024 07:22:50 +0300 From: Mike Rapoport To: Song Liu Cc: Mark Rutland , Peter Zijlstra , linux-kernel@vger.kernel.org, Alexandre Ghiti , Andrew Morton , Bjorn Topel , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Donald Dutile , Eric Chanudet , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Michael Ellerman , Nadav Amit , Palmer Dabbelt , Puranjay Mohan , Rick Edgecombe , Russell King , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v4 05/15] mm: introduce execmem_alloc() and execmem_free() Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240419_212415_114454_E2C54898 X-CRM114-Status: GOOD ( 26.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBBcHIgMTksIDIwMjQgYXQgMDI6NDI6MTZQTSAtMDcwMCwgU29uZyBMaXUgd3JvdGU6 Cj4gT24gRnJpLCBBcHIgMTksIDIwMjQgYXQgMTowMOKAr1BNIE1pa2UgUmFwb3BvcnQgPHJwcHRA a2VybmVsLm9yZz4gd3JvdGU6Cj4gPgo+ID4gT24gRnJpLCBBcHIgMTksIDIwMjQgYXQgMTA6MzI6 MzlBTSAtMDcwMCwgU29uZyBMaXUgd3JvdGU6Cj4gPiA+IE9uIEZyaSwgQXByIDE5LCAyMDI0IGF0 IDEwOjAz4oCvQU0gTWlrZSBSYXBvcG9ydCA8cnBwdEBrZXJuZWwub3JnPiB3cm90ZToKPiA+ID4g Wy4uLl0KPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gWzFdIGh0dHBzOi8vbG9yZS5rZXJuZWwub3Jn L2FsbC8yMDI0MDQxMTE2MDUyNi4yMDkzNDA4LTEtcnBwdEBrZXJuZWwub3JnCj4gPiA+ID4gPgo+ ID4gPiA+ID4gRm9yIHRoZSBST1ggdG8gd29yaywgd2UgbmVlZCBkaWZmZXJlbnQgdXNlcnMgKG1v ZHVsZSB0ZXh0LCBrcHJvYmUsIGV0Yy4pIHRvIGhhdmUKPiA+ID4gPiA+IHRoZSBzYW1lIGV4ZWNt ZW1fcmFuZ2UuIEZyb20gWzFdOgo+ID4gPiA+ID4KPiA+ID4gPiA+IHN0YXRpYyB2b2lkICpleGVj bWVtX2NhY2hlX2FsbG9jKHN0cnVjdCBleGVjbWVtX3JhbmdlICpyYW5nZSwgc2l6ZV90IHNpemUp Cj4gPiA+ID4gPiB7Cj4gPiA+ID4gPiAuLi4KPiA+ID4gPiA+ICAgICAgICBwID0gX19leGVjbWVt X2NhY2hlX2FsbG9jKHNpemUpOwo+ID4gPiA+ID4gICAgICAgIGlmIChwKQo+ID4gPiA+ID4gICAg ICAgICAgICAgICAgcmV0dXJuIHA7Cj4gPiA+ID4gPiAgICAgICBlcnIgPSBleGVjbWVtX2NhY2hl X3BvcHVsYXRlKHJhbmdlLCBzaXplKTsKPiA+ID4gPiA+IC4uLgo+ID4gPiA+ID4gfQo+ID4gPiA+ ID4KPiA+ID4gPiA+IFdlIGFyZSBjYWxsaW5nIF9fZXhlY21lbV9jYWNoZV9hbGxvYygpIHdpdGhv dXQgcmFuZ2UuIEZvciB0aGlzIHRvIHdvcmssCj4gPiA+ID4gPiB3ZSBjYW4gb25seSBjYWxsIGV4 ZWNtZW1fY2FjaGVfYWxsb2MoKSB3aXRoIG9uZSBleGVjbWVtX3JhbmdlLgo+ID4gPiA+Cj4gPiA+ ID4gQWN0dWFsbHksIG9uIHg4NiB0aGlzIHdpbGwgImp1c3Qgd29yayIgYmVjYXVzZSBldmVyeXRo aW5nIHNoYXJlcyB0aGUgc2FtZQo+ID4gPiA+IGFkZHJlc3Mgc3BhY2UgOikKPiA+ID4gPgo+ID4g PiA+IFRoZSAyTSBwYWdlcyBpbiB0aGUgY2FjaGUgd2lsbCBiZSBpbiB0aGUgbW9kdWxlcyBzcGFj ZSwgc28KPiA+ID4gPiBfX2V4ZWNtZW1fY2FjaGVfYWxsb2MoKSB3aWxsIGFsd2F5cyByZXR1cm4g bWVtb3J5IGZyb20gdGhhdCBhZGRyZXNzIHNwYWNlLgo+ID4gPiA+Cj4gPiA+ID4gRm9yIG90aGVy IGFyY2hpdGVjdHVyZXMgdGhpcyBpbmRlZWQgbmVlZHMgdG8gYmUgZml4ZWQgd2l0aCBwYXNzaW5n IHRoZQo+ID4gPiA+IHJhbmdlIHRvIF9fZXhlY21lbV9jYWNoZV9hbGxvYygpIGFuZCBsaW1pdGlu ZyBzZWFyY2ggaW4gdGhlIGNhY2hlIGZvciB0aGF0Cj4gPiA+ID4gcmFuZ2UuCj4gPiA+Cj4gPiA+ IEkgdGhpbmsgd2UgYXQgbGVhc3QgbmVlZCB0aGUgIm1hcCB0byIgY29uY2VwdCAoaW5pdGlhbGx5 IHByb3Bvc2VkIGJ5IFRob21hcykKPiA+ID4gdG8gZ2V0IHRoaXMgd29yay4gRm9yIGV4YW1wbGUs IEVYRUNNRU1fQlBGIGFuZCBFWEVDTUVNX0tQUk9CRQo+ID4gPiBtYXBzIHRvIEVYRUNNRU1fTU9E VUxFX1RFWFQsIHNvIHRoYXQgYWxsIHRoZXNlIGFjdHVhbGx5IHNoYXJlCj4gPiA+IHRoZSBzYW1l IHJhbmdlLgo+ID4KPiA+IFdoeT8KPiAKPiBJSVVDLCB3ZSBuZWVkIHRvIHVwZGF0ZSBfX2V4ZWNt ZW1fY2FjaGVfYWxsb2MoKSB0byB0YWtlIGEgcmFuZ2UgcG9pbnRlciBhcwo+IGlucHV0LiBtb2R1 bGUgdGV4dCB3aWxsIHVzZSAicmFuZ2UiIGZvciBFWEVDTUVNX01PRFVMRV9URVhULCB3aGlsZSBr cHJvYmUKPiB3aWxsIHVzZSAicmFuZ2UiIGZvciBFWEVDTUVNX0tQUk9CRS4gV2l0aG91dCAibWFw IHRvIiBjb25jZXB0IG9yIHNoYXJpbmcKPiB0aGUgInJhbmdlIiBvYmplY3QsIHdlIHdpbGwgaGF2 ZSB0byBjb21wYXJlIGRpZmZlcmVudCByYW5nZSBwYXJhbWV0ZXJzIHRvIGNoZWNrCj4gd2UgY2Fu IHNoYXJlIGNhY2hlZCBwYWdlcyBiZXR3ZWVuIG1vZHVsZSB0ZXh0IGFuZCBrcHJvYmUsIHdoaWNo IGlzIG5vdAo+IGVmZmljaWVudC4gRGlkIEkgbWlzcyBzb21ldGhpbmc/CgpXZSBjYW4gYWx3YXlz IHNoYXJlIGxhcmdlIFJPWCBwYWdlcyBhcyBsb25nIGFzIHRoZXkgYXJlIHdpdGhpbiB0aGUgY29y cmVjdAphZGRyZXNzIHNwYWNlLiBUaGUgcGVybWlzc2lvbnMgZm9yIHRoZW0gYXJlIFJPWCBhbmQg dGhlIGFsaWdubWVudApkaWZmZXJlbmNlcyBhcmUgZHVlIHRvIEtBU0FOIGFuZCB0aGlzIGlzIGhh bmRsZWQgZHVyaW5nIGFsbG9jYXRpb24gb2YgdGhlCmxhcmdlIHBhZ2UgdG8gcmVmaWxsIHRoZSBj YWNoZS4gX19leGVjbWVtX2NhY2hlX2FsbG9jKCkgb25seSBuZWVkcyB0byBsaW1pdAp0aGUgc2Vh cmNoIGZvciB0aGUgYWRkcmVzcyBzcGFjZSBvZiB0aGUgcmFuZ2UuCgpBbmQgcmVnYXJkbGVzcywg dGhleSB3YXkgd2UgZGVhbCB3aXRoIHNoYXJpbmcgb2YgdGhlIGNhY2hlIGNhbiBiZSBzb3J0ZWQK b3V0IGxhdGVyLgoKPiBUaGFua3MsCj4gU29uZwoKLS0gClNpbmNlcmVseSB5b3VycywKTWlrZS4K Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFy bS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1r ZXJuZWwK