From: Peter Xu <peterx@redhat.com>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org
Subject: Re: [PATCH v2] mm: memory: check userfaultfd_wp() in vmf_orig_pte_uffd_wp()
Date: Sun, 21 Apr 2024 09:53:40 -0400 [thread overview]
Message-ID: <ZiUaZEHTyGr-nE4t@x1n> (raw)
In-Reply-To: <073f3d13-5656-4de0-a62b-cee96f2b0eaa@huawei.com>
On Sat, Apr 20, 2024 at 12:05:04PM +0800, Kefeng Wang wrote:
> The latency of lat_pagefault increased a lot than the old kernel(vs 5.10),
> except mm counter updating, the another obvious difference
> shown from perf graph is the new vmf_orig_pte_uffd_wp().
Curious how different it is.
I wanted to give it a quick shot over lmbench but fails on missing rpc.h,
at least for the Intel repo. I think it's because of the libc change to
drop that. Are you using a separate repo that fixed all things up?
> Moving it upper is better, and maybe add __always_inline to
> vmf_orig_pte_uffd_wp() to make set_pte_range() only check VM_UFFD_WP from
> vm_flags?
Sounds good here, thanks.
--
Peter Xu
next prev parent reply other threads:[~2024-04-21 13:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 12:06 [PATCH v2] mm: memory: check userfaultfd_wp() in vmf_orig_pte_uffd_wp() Kefeng Wang
2024-04-18 16:32 ` Peter Xu
2024-04-19 3:00 ` Kefeng Wang
2024-04-19 15:17 ` Peter Xu
2024-04-20 4:05 ` Kefeng Wang
2024-04-21 13:53 ` Peter Xu [this message]
2024-04-22 2:13 ` Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZiUaZEHTyGr-nE4t@x1n \
--to=peterx@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.