Re: [meta-virtualization][PATCH] conmon/crun/docker-compose/nerdctl: get rid of go-md2man dependency

[Bruce Ashfield <bruce.ashfield@gmail.com>]

In message: [meta-virtualization][PATCH] conmon/crun/docker-compose/nerdctl: get rid of go-md2man dependency
on 17/04/2024 Chen Qi via lists.yoctoproject.org wrote:

> From: Chen Qi <Qi.Chen@windriver.com>
> 
> The go-md2man dependency is not needed for these recipes.
> 
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
>  recipes-containers/conmon/conmon_git.bb                 | 2 +-
>  recipes-containers/crun/crun_git.bb                     | 2 +-
>  recipes-containers/docker-compose/docker-compose_git.bb | 1 -
>  recipes-containers/nerdctl/nerdctl_git.bb               | 1 -
>  4 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/recipes-containers/conmon/conmon_git.bb b/recipes-containers/conmon/conmon_git.bb
> index d7047ed0..ab8a4ef2 100644
> --- a/recipes-containers/conmon/conmon_git.bb
> +++ b/recipes-containers/conmon/conmon_git.bb
> @@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=61af0b6932ea7b12fb9142721043bc77"
>  inherit features_check
>  REQUIRED_DISTRO_FEATURES ?= "seccomp"
>  
> -DEPENDS = "glib-2.0 go-md2man-native libseccomp"
> +DEPENDS = "glib-2.0 libseccomp"
>  
>  SRCREV = "affab49967eb62f75d2a47398344ab053326289f"
>  SRC_URI = "\
> diff --git a/recipes-containers/crun/crun_git.bb b/recipes-containers/crun/crun_git.bb
> index 89ba21b4..c0f9ead6 100644
> --- a/recipes-containers/crun/crun_git.bb
> +++ b/recipes-containers/crun/crun_git.bb
> @@ -26,7 +26,7 @@ inherit autotools-brokensep pkgconfig features_check
>  
>  PACKAGECONFIG ??= ""
>  
> -DEPENDS = "yajl libcap go-md2man-native m4-native"
> +DEPENDS = "yajl libcap m4-native"

crun still has the capability to build man pages, so this
can still be required and I don't want to remove it.

As for the others, technically it is still used, but is
now typically built from the vendored source versus our
dependency.

I would be ok with removing it from the packages that are
now using a vendored copy or don't build man pages (in a
v2)

Bruce

>  # TODO: is there a packageconfig to turn this off ?
>  DEPENDS += "libseccomp"
>  DEPENDS += "systemd"
> diff --git a/recipes-containers/docker-compose/docker-compose_git.bb b/recipes-containers/docker-compose/docker-compose_git.bb
> index 07650126..afb3150a 100644
> --- a/recipes-containers/docker-compose/docker-compose_git.bb
> +++ b/recipes-containers/docker-compose/docker-compose_git.bb
> @@ -3,7 +3,6 @@ SUMMARY =  "Multi-container orchestration for Docker"
>  DESCRIPTION = "Docker compose v2"
>  
>  DEPENDS = " \
> -    go-md2man \
>      rsync-native \
>  "
>  
> diff --git a/recipes-containers/nerdctl/nerdctl_git.bb b/recipes-containers/nerdctl/nerdctl_git.bb
> index 8868274f..dce5b2cc 100644
> --- a/recipes-containers/nerdctl/nerdctl_git.bb
> +++ b/recipes-containers/nerdctl/nerdctl_git.bb
> @@ -4,7 +4,6 @@ DESCRIPTION = "nerdctl: Docker-compatible CLI for containerd \
>      "
>  
>  DEPENDS = " \
> -    go-md2man \
>      rsync-native \
>      ${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \
>  "
> -- 
> 2.42.0
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#8683): https://lists.yoctoproject.org/g/meta-virtualization/message/8683
> Mute This Topic: https://lists.yoctoproject.org/mt/105591667/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>