From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA4A3C07C79 for ; Mon, 22 Apr 2024 13:02:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 7878281E84; Mon, 22 Apr 2024 13:02:28 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id ptWp03liICql; Mon, 22 Apr 2024 13:02:24 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 8A17F81E9B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1713790944; bh=qm99+1pJ8lbqw/SE/f1RwUN3qOZS7r1xsqomwM1clCE=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=zeO46xSj+VRv7GDj/LXLJmNMXdJxpi591J+8pcjm6+w5aPMbKP+t+UbSjbMDOrizs no0w7bqSL5ln+fhuDELsg4+XlPKGzehIaDO20SHLi3yFfVwjxzNaSlC+Gnyw3I4pwM q+w10NOfWkA6oqVbriAOecXGuhBvhksO48CPxDTjZQVq5s9tJA7j8/26Ckwpsp/KJ0 /Alv9hidSE+JvYLFA3L8UVE0VV+OLmCyNI5wWGpuDEaiBiRwrB14R2skmL0kB67Etz 5xp8fAZ5NsCpmvyDPZF3KVZmK/Ggi2Fzzelj+NELKEOdSwjMUPgeYNdEg6sSW9/k75 A6xZjAnB6DjaA== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 8A17F81E9B; Mon, 22 Apr 2024 13:02:24 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 981AD1BF322 for ; Mon, 22 Apr 2024 13:02:22 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 8F24681E84 for ; Mon, 22 Apr 2024 13:02:22 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id eiw5re-9KU9n for ; Mon, 22 Apr 2024 13:02:17 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=2a00:1450:4864:20::32a; helo=mail-wm1-x32a.google.com; envelope-from=jiri@resnulli.us; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 95BC081E9B DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 95BC081E9B Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by smtp1.osuosl.org (Postfix) with ESMTPS id 95BC081E9B for ; Mon, 22 Apr 2024 13:02:14 +0000 (UTC) Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-41a70466b77so4778745e9.0 for ; Mon, 22 Apr 2024 06:02:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713790932; x=1714395732; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qm99+1pJ8lbqw/SE/f1RwUN3qOZS7r1xsqomwM1clCE=; b=qh1SoWeCL4wHgUvedVf3/mGS9PrrFQ4fUU2FEehuSebx8bnSji/X1KE1gdyxdHLCoo mujz29bV/Sc6xpW6Ei71yR1C6ajknaCJDVgD2BwX2qw4OWoudYVsZrWuLj4V6Gb7Zv4k aSgmtY1ZvPaYpLA3Eb5FnfkZ7NYLqBgpMDQ69tEbyzN1E01+CFGPVf06k42DIXSUxBr+ qn79qQE3JvEAOipXybXqiqNprWJFjs5+IW7LEQAYyClWYvF4CUbkzZYX/2IHuIJyKzfi 8AxRC4l1kZa+m1lma63D3CThocKZ022hszNgsHbfHJpiEslwTr/FSkeJpgYmYseqmBxU IHuA== X-Gm-Message-State: AOJu0YzxFEVm6Ns+l4N5nUW89JH3EFBwz3lTkpaERE35o4pDL4IAD+pP Q37b0A8CHIUw/tNtKrcHzX3LSlN5TDJ8XaG6URX23Hqjt9dpy9jPvzHJTRFyMLw= X-Google-Smtp-Source: AGHT+IG3NklYHUNy3UDg5EkitlWCH3cW4NlqKxBNkiYa584fYnuPfopZscWVPOTdu1h6QogJnanWFA== X-Received: by 2002:a05:600c:46c8:b0:414:d95:cc47 with SMTP id q8-20020a05600c46c800b004140d95cc47mr9577310wmo.30.1713790932386; Mon, 22 Apr 2024 06:02:12 -0700 (PDT) Received: from localhost (78-80-105-131.customers.tmcz.cz. [78.80.105.131]) by smtp.gmail.com with ESMTPSA id bg5-20020a05600c3c8500b00419f419236fsm8281965wmb.41.2024.04.22.06.02.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Apr 2024 06:02:11 -0700 (PDT) Date: Mon, 22 Apr 2024 15:02:10 +0200 From: Jiri Pirko To: Michal Swiatkowski Message-ID: References: <20240419171336.11617-1-michal.swiatkowski@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240419171336.11617-1-michal.swiatkowski@linux.intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1713790932; x=1714395732; darn=lists.osuosl.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=qm99+1pJ8lbqw/SE/f1RwUN3qOZS7r1xsqomwM1clCE=; b=YEJWPk1hzZNfW7kvebnwTJFBH99U5KxxzonrDBjBI5vYoTsDiHebFvCIAkeJxNHp8w qJol5DuAcTYTrFktxkiz1Ou4koqeqGLPKAen/iszkCXLZJArqYnRmIxwfXfKk7E5PO+g Q+wPKiou2lqLhJPPL9EtbQZJ9AM85UMID/X9K2grHUsTa3gUeE5agzK5pnZ3SoBpEXit FMy/CSz3oCIY1sUsNElUnRWx2Lkue50i9cI6USu7ngzJHJfThpUttsqc7F/2mDlCyPIc GIWW8L4on1A98uAv+U5PK3cJXkt3+xqK6GlV+J+By/UDFxQyoHhmMpPce+XqQa3nKbCv NhIw== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=none (p=none dis=none) header.from=resnulli.us X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=YEJWPk1h Subject: Re: [Intel-wired-lan] [iwl-next v1 0/4] ice: prepare representor for SF support X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: shayd@nvidia.com, maciej.fijalkowski@intel.com, mateusz.polchlopek@intel.com, netdev@vger.kernel.org, jiri@nvidia.com, michal.kubiak@intel.com, intel-wired-lan@lists.osuosl.org, pio.raczynski@gmail.com, sridhar.samudrala@intel.com, jacob.e.keller@intel.com, wojciech.drewek@intel.com, przemyslaw.kitszel@intel.com Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" Fri, Apr 19, 2024 at 07:13:32PM CEST, michal.swiatkowski@linux.intel.com wrote: >Hi, > >This is a series to prepare port representor for supporting also >subfunctions. We need correct devlink locking and the possibility to >update parent VSI after port representor is created. > >Refactor how devlink lock is taken to suite the subfunction use case. > >VSI configuration needs to be done after port representor is created. >Port representor needs only allocated VSI. It doesn't need to be >configured before. > >VSI needs to be reconfigured when update function is called. > >The code for this patchset was split from (too big) patchset [1]. > >[1] https://lore.kernel.org/netdev/20240213072724.77275-1-michal.swiatkowski@linux.intel.com/ > >Michal Swiatkowski (4): > ice: store representor ID in bridge port > ice: move devlink locking outside the port creation > ice: move VSI configuration outside repr setup > ice: update representor when VSI is ready FWIW, looks fine to me. > > .../net/ethernet/intel/ice/devlink/devlink.c | 2 - > .../ethernet/intel/ice/devlink/devlink_port.c | 4 +- > drivers/net/ethernet/intel/ice/ice_eswitch.c | 83 +++++++++++++------ > drivers/net/ethernet/intel/ice/ice_eswitch.h | 14 +++- > .../net/ethernet/intel/ice/ice_eswitch_br.c | 4 +- > .../net/ethernet/intel/ice/ice_eswitch_br.h | 1 + > drivers/net/ethernet/intel/ice/ice_repr.c | 16 ++-- > drivers/net/ethernet/intel/ice/ice_repr.h | 1 + > drivers/net/ethernet/intel/ice/ice_vf_lib.c | 2 +- > 9 files changed, 88 insertions(+), 39 deletions(-) > >-- >2.42.0 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84A78746E for ; Mon, 22 Apr 2024 13:02:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713790940; cv=none; b=c2TilLTHHyFmWmxU2tpZ+gwsCK3DevmqLldYATtc3oAVy3Q0tWH1uj3BzfbX3ViTNaBLE3CZ/fXOATo0V/OuK/bcuSlmXkghqgPvdpg5aI6IDwyZw2ICx5VH9PpbNQa0lfSXfaUWeJr+d8my4lIzEyxUF1STkMmHUvKaYOO3B6g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713790940; c=relaxed/simple; bh=HiztFdgqaV8KD4r9t+kYvJXPXgbRU5w9CQbYk3ihQqA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JREqXoho0hQIQNqFJfNxnkuM1KyG2VsZ1nPFnwG9iNlphxwZwbPdpKBwn08I2SWq01oL/Bm38aHXJsynYj/apM8nKS9zynbgJyb/SNI0hqPtiHlFXSHbGqCsnYWgbTJcAiFUJABtK5dv5j7FTGIX3eWHzmihm4uvNOcpuCjqZGI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us; spf=none smtp.mailfrom=resnulli.us; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b=bfDaePoo; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=resnulli.us Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b="bfDaePoo" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-41a0979b9aeso10848645e9.3 for ; Mon, 22 Apr 2024 06:02:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1713790932; x=1714395732; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=qm99+1pJ8lbqw/SE/f1RwUN3qOZS7r1xsqomwM1clCE=; b=bfDaePoo7hOaamusFoD0TN/JyQq6eTgAvC04Bo6r/GqCvOAqj1LPjQa610Uvy5aLCh CF6bMCh0bxeRQYdgKZxOcDzUTELL2LK/1jHEvX87JxwGLsOREcnBaPPcV+rcMyu8gUcw e8m3S65rYkjDfI3mg9shKYIZaID+KCw+s3M4XH+a5tTrWk2KNSporOvmfNDrRMjO5lvw FmO51Wrc2UcEAJvaPshjOC6/pmRtzRAy0RynuSwxZi6UM+laBbu1iNWdQ4O6I7C2QPoo A7dH3mLqil7nclbC2xCKlvuFHobCCPwZx1xaM6nqtL1zLc8IwZEzkVwcOP4iXEkfBPVh DQNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713790932; x=1714395732; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qm99+1pJ8lbqw/SE/f1RwUN3qOZS7r1xsqomwM1clCE=; b=luY6TajELn/Q9lyjsGHIrleGNZUCA9w9+Rhl71LfLyd9dl1kPVjAmzmNuBGPUL2/w5 8BoegRe+2lBBNnFgZbfVDnKosik7YXwbNir5I8rXPd0/dBAOLCTWY/eCWSCpIXPenqnN Lc2VWIImpyRNi0F87tq4Xe8KuDNjFXU9KFsb4r78BKKuayVKXSljI8Lnd3i70BICft44 el+4xnmT8O2sIApt70PTRracKPwcwTjdEVDauaswGYhBawJGNmSPtM1DW/FQ4RkVzXuT 0hy04J9mHccCCZGeLGzHj+tbXjliHRWjLU9qhp31vczGAhl8Dte5TP3h4WlO/xXEL8sZ Gnmw== X-Forwarded-Encrypted: i=1; AJvYcCXTUzrCPmrIuhYJg2tRX59ADbMJP0ZgLSgNlWUToZ7EPlwKAOpa0V1HUqMFMq/gzvN1iV8l9Ue69LuM7Ixsuyitr/lDSgBa X-Gm-Message-State: AOJu0YxAbUKvJeJJuQhvX4ouTfHlaFC2BPCIaJ8KzT+mH4ht8UUK2IV+ 37fDcuNNy9FptakECpx7ZXEV/EmSDHvwSiYf1yh6xJmQiB0bMNH/6BzArPsgkus= X-Google-Smtp-Source: AGHT+IG3NklYHUNy3UDg5EkitlWCH3cW4NlqKxBNkiYa584fYnuPfopZscWVPOTdu1h6QogJnanWFA== X-Received: by 2002:a05:600c:46c8:b0:414:d95:cc47 with SMTP id q8-20020a05600c46c800b004140d95cc47mr9577310wmo.30.1713790932386; Mon, 22 Apr 2024 06:02:12 -0700 (PDT) Received: from localhost (78-80-105-131.customers.tmcz.cz. [78.80.105.131]) by smtp.gmail.com with ESMTPSA id bg5-20020a05600c3c8500b00419f419236fsm8281965wmb.41.2024.04.22.06.02.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Apr 2024 06:02:11 -0700 (PDT) Date: Mon, 22 Apr 2024 15:02:10 +0200 From: Jiri Pirko To: Michal Swiatkowski Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, jacob.e.keller@intel.com, michal.kubiak@intel.com, maciej.fijalkowski@intel.com, sridhar.samudrala@intel.com, przemyslaw.kitszel@intel.com, wojciech.drewek@intel.com, pio.raczynski@gmail.com, jiri@nvidia.com, mateusz.polchlopek@intel.com, shayd@nvidia.com Subject: Re: [iwl-next v1 0/4] ice: prepare representor for SF support Message-ID: References: <20240419171336.11617-1-michal.swiatkowski@linux.intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240419171336.11617-1-michal.swiatkowski@linux.intel.com> Fri, Apr 19, 2024 at 07:13:32PM CEST, michal.swiatkowski@linux.intel.com wrote: >Hi, > >This is a series to prepare port representor for supporting also >subfunctions. We need correct devlink locking and the possibility to >update parent VSI after port representor is created. > >Refactor how devlink lock is taken to suite the subfunction use case. > >VSI configuration needs to be done after port representor is created. >Port representor needs only allocated VSI. It doesn't need to be >configured before. > >VSI needs to be reconfigured when update function is called. > >The code for this patchset was split from (too big) patchset [1]. > >[1] https://lore.kernel.org/netdev/20240213072724.77275-1-michal.swiatkowski@linux.intel.com/ > >Michal Swiatkowski (4): > ice: store representor ID in bridge port > ice: move devlink locking outside the port creation > ice: move VSI configuration outside repr setup > ice: update representor when VSI is ready FWIW, looks fine to me. > > .../net/ethernet/intel/ice/devlink/devlink.c | 2 - > .../ethernet/intel/ice/devlink/devlink_port.c | 4 +- > drivers/net/ethernet/intel/ice/ice_eswitch.c | 83 +++++++++++++------ > drivers/net/ethernet/intel/ice/ice_eswitch.h | 14 +++- > .../net/ethernet/intel/ice/ice_eswitch_br.c | 4 +- > .../net/ethernet/intel/ice/ice_eswitch_br.h | 1 + > drivers/net/ethernet/intel/ice/ice_repr.c | 16 ++-- > drivers/net/ethernet/intel/ice/ice_repr.h | 1 + > drivers/net/ethernet/intel/ice/ice_vf_lib.c | 2 +- > 9 files changed, 88 insertions(+), 39 deletions(-) > >-- >2.42.0 > >