From: Sean Christopherson <seanjc@google.com>
To: Kele Huang <kele@cs.columbia.edu>
Cc: Zide Chen <zide.chen@intel.com>,
pbonzini@redhat.com, kvm@vger.kernel.org
Subject: Re: [1/1] KVM: restrict kvm_gfn_to_hva_cache_init() to only accept address ranges within one page
Date: Mon, 29 Apr 2024 13:13:24 -0700 [thread overview]
Message-ID: <Zi__ZF5SY2k7BtTE@google.com> (raw)
In-Reply-To: <CAOfLF_L+bxOo4kK5H6WAUcOeTu5wFiU57UtR5qmr1rQBT5mAfA@mail.gmail.com>
On Sat, Apr 27, 2024, Kele Huang wrote:
> Although, it is a bit not straightforward to me because it needs to call
> designed functions to do the guest memory read and write even though people
> assume the cache is initialized, or need to do the ghc->memslot checking
> manually before using the fast path.
Oh, don't get me wrong, I completely agree that the code isn't straightforward.
But I don't think this is a problem that can be reasonably solved in the caching
code, at least not easily, as a lot of the oddities stem from KVM's memslots, and
KVM's contracts with userspace and the guest.
next prev parent reply other threads:[~2024-04-29 20:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 2:49 [1/1] KVM: restrict kvm_gfn_to_hva_cache_init() to only accept address ranges within one page Kele Huang
2024-04-26 1:16 ` Chen, Zide
[not found] ` <CAOfLF_L2UgSUyUsbiBDhLPskt2xLWujy1GBAhpcWzi2i3brAww@mail.gmail.com>
2024-04-26 4:18 ` Kele Huang
2024-04-26 16:17 ` Sean Christopherson
2024-04-27 4:27 ` Kele Huang
2024-04-29 20:13 ` Sean Christopherson [this message]
2024-04-30 19:29 ` Kele Huang
2024-04-26 6:25 ` Christoph Hellwig
2024-04-27 3:50 ` Kele Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zi__ZF5SY2k7BtTE@google.com \
--to=seanjc@google.com \
--cc=kele@cs.columbia.edu \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=zide.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.