From: Stanislav Fomichev <sdf@google.com>
To: Philo Lu <lulie@linux.alibaba.com>
Cc: bpf@vger.kernel.org, edumazet@google.com, davem@davemloft.net,
kuba@kernel.org, pabeni@redhat.com, ast@kernel.org,
daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev,
eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev,
john.fastabend@gmail.com, kpsingh@kernel.org, haoluo@google.com,
jolsa@kernel.org, dsahern@kernel.org, laoar.shao@gmail.com,
fred.cc@alibaba-inc.com, xuanzhuo@linux.alibaba.com
Subject: Re: [PATCH bpf-next] bpf: add mrtt and srtt as BPF_SOCK_OPS_RTT_CB args
Date: Mon, 22 Apr 2024 16:09:11 -0700 [thread overview]
Message-ID: <ZibuF9_INOxYUVch@google.com> (raw)
In-Reply-To: <20240421042440.33125-1-lulie@linux.alibaba.com>
On 04/21, Philo Lu wrote:
> Two important arguments in RTT estimation, mrtt and srtt, are passed to
> tcp_bpf_rtt(), so that bpf programs get more information about RTT
> computation in BPF_SOCK_OPS_RTT_CB.
>
> The difference between bpf_sock_ops->srtt_us and the srtt here is: the
> former is an old rtt before update, while srtt passed by tcp_bpf_rtt()
> is that after update.
Can you also extend the rtt selftest to exercise there new numbers?
Something simple like making sure they are non-zero should be enough.
next prev parent reply other threads:[~2024-04-22 23:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-21 4:24 [PATCH bpf-next] bpf: add mrtt and srtt as BPF_SOCK_OPS_RTT_CB args Philo Lu
2024-04-22 23:09 ` Stanislav Fomichev [this message]
2024-04-23 0:58 ` Philo Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZibuF9_INOxYUVch@google.com \
--to=sdf@google.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=eddyz87@gmail.com \
--cc=edumazet@google.com \
--cc=fred.cc@alibaba-inc.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=laoar.shao@gmail.com \
--cc=lulie@linux.alibaba.com \
--cc=martin.lau@linux.dev \
--cc=pabeni@redhat.com \
--cc=song@kernel.org \
--cc=xuanzhuo@linux.alibaba.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.