Re: [PATCH 00/10] ALSA: emu10k1: fixes related to uploading firmware to the E-MU dock

[Oswald Buddenhagen <oswald.buddenhagen@gmx.de>]

On Mon, Apr 22, 2024 at 09:29:27PM +0200, Takashi Iwai wrote:
>On Sun, 21 Apr 2024 22:46:57 +0200,
>Oswald Buddenhagen wrote:
>>
>> patches 1-3 & 5 fix the regression(s), patch 4 fixes a related pre-existing
>> problem, while patches 6-10 are "only" improvements.
>>
>If a few of the series are rather regression fixes that should be
>merged to Linus tree sooner, please separate them and send two patch
>sets instead.
>
i can't give more precise instructions than above; it's a judgment call
whether you consider patch 4 urgent enough (it's a fix, but not for a
recently introduced regression; nonetheless, i've seen less important
patches from me be picked to stable). i'd just split the series in half.

>I don't see Fixes tag in the patch 2, for example, so
>I'm not sure whether I should pick up.
>
as the commit message says, it's preparatory refactoring for patch 3, so
it's not a fix, but a mandatory dependency for one.

>Also, your Fixes tag usage is incorrect.  It should be
>  Fixes: $ID ("subject...")
>while yours missing the quotes.  Some people are picky about those
>formats, so let's be strict.
>
fair enough.