From: Jiri Pirko <jiri@resnulli.us>
To: "Marek Behún" <kabel@kernel.org>
Cc: netdev@vger.kernel.org, Russell King <rmk+kernel@armlinux.org.uk>,
Raju Lakkaraju <Raju.Lakkaraju@microchip.com>,
Frank Wunderlich <frank-w@public-files.de>,
Eric Woudstra <ericwouds@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH net-next v2 2/2] net: sfp: enhance quirk for Fibrestore 2.5G copper SFP module
Date: Tue, 23 Apr 2024 13:41:33 +0200 [thread overview]
Message-ID: <ZieebbTQ0FP0yiXx@nanopsycho> (raw)
In-Reply-To: <20240423085039.26957-2-kabel@kernel.org>
Tue, Apr 23, 2024 at 10:50:39AM CEST, kabel@kernel.org wrote:
>Enhance the quirk for Fibrestore 2.5G copper SFP module. The original
>commit e27aca3760c0 ("net: sfp: add quirk for FS's 2.5G copper SFP")
>introducing the quirk says that the PHY is inaccessible, but that is
>not true.
>
>The module uses Rollball protocol to talk to the PHY, and needs a 4
>second wait before probing it, same as FS 10G module.
>
>The PHY inside the module is Realtek RTL8221B-VB-CG PHY. The realtek
>driver recently gained support to set it up via clause 45 accesses.
>
>Signed-off-by: Marek Behún <kabel@kernel.org>
>---
>This patch depends on realtek driver changes merged in
> c31bd5b6ff6f ("Merge branch 'rtl8226b-serdes-switching'")
>which are currently only in net-next.
I don't follow. You are targetting net-next (by patch subject), what's
the point of this comment?
Otherwise looks ok to me.
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
next prev parent reply other threads:[~2024-04-23 11:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 8:50 [PATCH net-next v2 1/2] net: sfp: update comment for FS SFP-10G-T quirk Marek Behún
2024-04-23 8:50 ` [PATCH net-next v2 2/2] net: sfp: enhance quirk for Fibrestore 2.5G copper SFP module Marek Behún
2024-04-23 11:41 ` Jiri Pirko [this message]
2024-04-23 11:45 ` Marek Behún
2024-04-23 11:39 ` [PATCH net-next v2 1/2] net: sfp: update comment for FS SFP-10G-T quirk Jiri Pirko
2024-04-26 2:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZieebbTQ0FP0yiXx@nanopsycho \
--to=jiri@resnulli.us \
--cc=Raju.Lakkaraju@microchip.com \
--cc=andrew@lunn.ch \
--cc=ericwouds@gmail.com \
--cc=frank-w@public-files.de \
--cc=hkallweit1@gmail.com \
--cc=kabel@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.