From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH v2 1/1] mm: page_alloc: Avoid defining unused function
Date: Tue, 23 Apr 2024 21:27:07 +0300 [thread overview]
Message-ID: <Zif9e5ByqBKJ9rgQ@smile.fi.intel.com> (raw)
In-Reply-To: <20240423111000.aaf74252a07d7e7fd56d7e12@linux-foundation.org>
On Tue, Apr 23, 2024 at 11:10:00AM -0700, Andrew Morton wrote:
> On Tue, 23 Apr 2024 19:14:43 +0300 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > In some configurations I got
> > mm/page_alloc.c:656:20: warning: unused function 'add_to_free_list' [-Wunused-function]
> > Becuase the only user is guarged with a certain ifdeffery,
> > do the same for add_to_free_list().
...
> Thanks, I'll queue this as a fix against "mm: page_alloc: consolidate
> free page accounting".
Thank you!
> Please do tell us the config when fixing these things. That way I can
> do a little bisect to ensure that I correctly identified the offending
> patch.
Hmm... You mean defconfig? I can share it.
I built this with `make W=1`, probably that one helps, but the MM parts of
the defconfig have not been altered by me from the x86_64_defconfig.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-04-23 18:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 16:14 [PATCH v2 1/1] mm: page_alloc: Avoid defining unused function Andy Shevchenko
2024-04-23 18:10 ` Andrew Morton
2024-04-23 18:27 ` Andy Shevchenko [this message]
2024-04-23 20:30 ` Johannes Weiner
2024-04-23 20:45 ` Andy Shevchenko
2024-04-25 6:25 ` Miaohe Lin
2024-04-25 9:15 ` Andy Shevchenko
2024-04-25 9:45 ` Andy Shevchenko
2024-04-25 11:23 ` Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zif9e5ByqBKJ9rgQ@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.