From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E297C4345F for ; Tue, 23 Apr 2024 15:30:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id F1586812FD; Tue, 23 Apr 2024 15:30:36 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 967h1QOis5G6; Tue, 23 Apr 2024 15:30:35 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 0B945812D9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1713886235; bh=2PasE5zHDUZQpfPlcoJSnFo4u5YpglCrOsGZQUACmWk=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=47s4p4Cet3XQxqAvYt75r5ITg5ToHwdfQD00o1q/ozZhaYsyZaynq463+Wf3ACemW 9ouwIFu+h090GTAh7RfQ7SKycZuS6O6vC4thi6/3N62coSx/cyvAXetFA4Mq2R4n4e VckGXQjxLqe2t/79xu2SKPN3S247WRut4NEonsD+aCK7pbkfbPUrH+bVwkbwxAG9bQ +vqKkh1PPYeOWhJXvViCNJqLErTZsRRb0ujx+wfI2R/1FtGAREcwNxibLcn9Y6YJNB m+MkRV8QMoFiUUEm03hNKaUt5GVS/dvtMgiDvxau61r94u1IdQkrrjme+J0pHpZZYC yoLZ2HWKszgOA== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 0B945812D9; Tue, 23 Apr 2024 15:30:35 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 4F5F71BF343 for ; Tue, 23 Apr 2024 15:30:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 399EC812D9 for ; Tue, 23 Apr 2024 15:30:33 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 8gn4QNosDMyv for ; Tue, 23 Apr 2024 15:30:32 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=2a00:1450:4864:20::335; helo=mail-wm1-x335.google.com; envelope-from=jiri@resnulli.us; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 9AF2380ABA DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 9AF2380ABA Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by smtp1.osuosl.org (Postfix) with ESMTPS id 9AF2380ABA for ; Tue, 23 Apr 2024 15:30:09 +0000 (UTC) Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-41a1d88723bso19034095e9.0 for ; Tue, 23 Apr 2024 08:30:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713886207; x=1714491007; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2PasE5zHDUZQpfPlcoJSnFo4u5YpglCrOsGZQUACmWk=; b=YZ56W2rdtkBTXSGxHbBYmJB3+dqhGIWqwdfqhzh/WwVgnwpvPJdZhjKtTpg7V5wa4A hqh6/tM8pCgoITMfZovoZkHVy/e1kj04UOf3Nr2aEGZo4W+rt3/5+WsZKkbQ+THqb1Or o25AnFs2r2mmVzjIHxkSLN5E3bZEP1DhbYAm/XU9STzSUwvm5NANpzbgKFNFpW38KOmU h+zVrXbiacI1M8iCaPZeZG8HjKLASdek9zU4aq8vvPSZ/POeEzHO4wVILKvCBtOt9XYk pb4ZfMe8p6JPDP8ROebos6I32e13CYiW2/3vP43yZHnH4A+4cmzzpMqVsCpbO5ybGFPI keTQ== X-Forwarded-Encrypted: i=1; AJvYcCVKOfgS6EL7CSuKuWL2JXlowxVCraG92aF6b6kZl9is3aS1uXSAXxExv+ns3cV+IGQqLAtyohjDGyhYV54BPPWm8HTzYiqiLqkJi0MqvdycAg== X-Gm-Message-State: AOJu0YxqYdFSCf4kvu4eRRBOOiNa5hiEH+VvKqZD3x/JH0TGNNEZgR2Y Vgx896UUOMtJ0SVryGYdKLbAj3giwFKRK00NED9+Jg7k2/EW1ICrxy8qx3VNlc0= X-Google-Smtp-Source: AGHT+IGtEkEhcb5mQc3KY/J9uWfPMgymkhpoR4p6Es6H93bP2NJvAnRHhoqtAk124PPyocNsK1fuzQ== X-Received: by 2002:adf:ec4d:0:b0:34a:2852:f119 with SMTP id w13-20020adfec4d000000b0034a2852f119mr8476258wrn.36.1713886207063; Tue, 23 Apr 2024 08:30:07 -0700 (PDT) Received: from localhost ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id p5-20020a5d48c5000000b0034afaa9ca47sm6577931wrs.1.2024.04.23.08.30.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Apr 2024 08:30:06 -0700 (PDT) Date: Tue, 23 Apr 2024 17:30:02 +0200 From: Jiri Pirko To: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org Message-ID: References: <20240423102446.901450-1-vinschen@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1713886207; x=1714491007; darn=lists.osuosl.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2PasE5zHDUZQpfPlcoJSnFo4u5YpglCrOsGZQUACmWk=; b=cPIjnCwq1EC5oTwhmqISfoxnmqei5UEXKDnq1CxTvHaX5r9knN+V5DdtQi/+yIsQHV SJ8A7N2EdGyobRNEIsxJjnhIZQpEC1N3d3CfUtPFYIMxcq+j+DcRFe0GT5IKd8Jh31Km RmNdcykf4XuSYkmhgJ4h1/jKY/fUXSny9zNZYK9gk2A4Um5ow8X7XSybG763Th9e8NhZ rw4KCIbEeeBZRxKgu/WJu8oRcdS5gkmwYg9No/ksav7ariyuAKFL+/QaUFrVbZsPb2Ui W6JwpNJ74M0x3qpeGplUDZPFXOhmU+GMf0ndaKAWSWPqmHApMTwdwSnrVUz9Y87B46OP DEyg== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=none (p=none dis=none) header.from=resnulli.us X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=cPIjnCwq Subject: Re: [Intel-wired-lan] [PATCH] igb: cope with large MAX_SKB_FRAGS. X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" Tue, Apr 23, 2024 at 03:54:05PM CEST, vinschen@redhat.com wrote: >Hi Jiri, > >On Apr 23 13:26, Jiri Pirko wrote: >> Tue, Apr 23, 2024 at 12:24:46PM CEST, vinschen@redhat.com wrote: >> >From: Paolo Abeni >> > >> >Sabrina reports that the igb driver does not cope well with large >> >MAX_SKB_FRAG values: setting MAX_SKB_FRAG to 45 causes payload >> >corruption on TX. >> > >> >The root cause of the issue is that the driver does not take into >> >account properly the (possibly large) shared info size when selecting >> >the ring layout, and will try to fit two packets inside the same 4K >> >page even when the 1st fraglist will trump over the 2nd head. >> > >> >Address the issue forcing the driver to fit a single packet per page, >> >leaving there enough room to store the (currently) largest possible >> >skb_shared_info. >> > >> >Fixes: 3948b05950fd ("net: introduce a config option to tweak MAX_SKB_FRAG") >> >Reported-by: Jan Tluka >> >Reported-by: Jirka Hladky >> >Reported-by: Sabrina Dubroca >> >Tested-by: Sabrina Dubroca >> >Tested-by: Corinna Vinschen >> >Signed-off-by: Paolo Abeni >> >--- >> > drivers/net/ethernet/intel/igb/igb_main.c | 1 + >> >> Also, please use get_maintainer.pl script to get cclist. > >done and done in v2 (for which I forgot the "in-reply-to" now, d'uh) In-reply-to is not needed. Send each V to separate thread. > >Thanks, >Corinna > > From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4167513C80C for ; Tue, 23 Apr 2024 15:30:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713886222; cv=none; b=udKNOah4s6PDoZkjxe8hX5nibPOQVcuGUCQvUk5LbDFotTHzCyrb7YRbhtxEznvjOy6cThaTKifl1by3OHF1gLp8K8HOt1kOy4edMWiHs/+zAw3AFEN/0qUBvH52F/DGG3pw7++X//wb5EfAMNF3H7V4BaeX8JjdbICroLmvaFs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713886222; c=relaxed/simple; bh=e8wuBSzLvfX5kN29uOikR0cOQbSak6iCsOgk+EzmlHw=; h=Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=C39ukT2U9HCqRl3qRqmmlgLobO+BitKglnT73T63vvWNrfZE2h+gDqZCxuxO3iF/J8viixrSEu7dNZdG6JWFQ1uVxI0D4iSyp7dArR06mZB7qNodL6BCd+1ygQZwVIuPLM/PnT/QYvA+skFO0HMWhlvdroqDzyW2gQv+eaLOf/Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us; spf=none smtp.mailfrom=resnulli.us; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b=3XvHWjB+; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=resnulli.us Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b="3XvHWjB+" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4187c47405aso39376675e9.3 for ; Tue, 23 Apr 2024 08:30:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1713886207; x=1714491007; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2PasE5zHDUZQpfPlcoJSnFo4u5YpglCrOsGZQUACmWk=; b=3XvHWjB+p1nZ+ARYiZ78mlfiCqD69ReM4nUeAQM7zzz5Z5QdtsssyIPvW4sV/tLQYD vdlzxZfoP+4FO2Ky8lXylnWQ5BU/Di3IJQ///cDmIME8ERbHAAw/BXkhb54Kcl0ACS5s airV5cngXPfcCdG5nx7lLewxHWGBqrda1xh6R39DIDi8a/wIw/1kBcBk7QeL2ZyvC2Hq rGdCHqKovVfYE3O/cbYPL2MT+4DUOCDj+fqc3cI4ziGdtTa93skPz6YUzqBYKZLZkoP2 9YMqL4mAqqXRg+7ZHkI8rf7F8XzD/uoSpJtbCD0ZMTzE7Q7dc9j4Gol8x//u75H8RTm3 JLGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713886207; x=1714491007; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2PasE5zHDUZQpfPlcoJSnFo4u5YpglCrOsGZQUACmWk=; b=S7w0Ub8FWpxBzKPqBqp5Gd47N35xE8B1hHFuokHua2vMOl8BBaaaIUOA0x9VqZjHcK rRWDqO4BfWdpxheYEH6Lweqi+ejNMMUy5GiImlj3ibWkkTIY3bGkK7nTv9QSF/jaiM9x GldQS2Msk92BceDzIcdHFun2gD9IS/FhvDZHzlZtjb4QlNEDRHJSjGEsGkAdWWUfux83 lj2g1oiQ5mKGoKyi4EZbQvZVmPiSXSj6uPBGxey74hBemp5+7On8DW6O1GwuU9zkLWKO PGq271TQyRWAgtkCOew51sKpfpcRZ4QsZt9Kj6P9MLSIYMTl5x5I+M8bxi6oEpc8tUU7 nQSQ== X-Gm-Message-State: AOJu0YwOLlsFShGEhTZDQ1ub3s+XpKoJbtHCAdopebz6h00VfoMSwvL9 UGAeqteyZBiWl64ZjSdpfOTU0dDRBrw3/r1KcPNraQcrUEEOdGkCTd3pWjYl4ut/LLLqhrFs1zd F/lg= X-Google-Smtp-Source: AGHT+IGtEkEhcb5mQc3KY/J9uWfPMgymkhpoR4p6Es6H93bP2NJvAnRHhoqtAk124PPyocNsK1fuzQ== X-Received: by 2002:adf:ec4d:0:b0:34a:2852:f119 with SMTP id w13-20020adfec4d000000b0034a2852f119mr8476258wrn.36.1713886207063; Tue, 23 Apr 2024 08:30:07 -0700 (PDT) Received: from localhost ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id p5-20020a5d48c5000000b0034afaa9ca47sm6577931wrs.1.2024.04.23.08.30.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Apr 2024 08:30:06 -0700 (PDT) Date: Tue, 23 Apr 2024 17:30:02 +0200 From: Jiri Pirko To: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org Subject: Re: [PATCH] igb: cope with large MAX_SKB_FRAGS. Message-ID: References: <20240423102446.901450-1-vinschen@redhat.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Tue, Apr 23, 2024 at 03:54:05PM CEST, vinschen@redhat.com wrote: >Hi Jiri, > >On Apr 23 13:26, Jiri Pirko wrote: >> Tue, Apr 23, 2024 at 12:24:46PM CEST, vinschen@redhat.com wrote: >> >From: Paolo Abeni >> > >> >Sabrina reports that the igb driver does not cope well with large >> >MAX_SKB_FRAG values: setting MAX_SKB_FRAG to 45 causes payload >> >corruption on TX. >> > >> >The root cause of the issue is that the driver does not take into >> >account properly the (possibly large) shared info size when selecting >> >the ring layout, and will try to fit two packets inside the same 4K >> >page even when the 1st fraglist will trump over the 2nd head. >> > >> >Address the issue forcing the driver to fit a single packet per page, >> >leaving there enough room to store the (currently) largest possible >> >skb_shared_info. >> > >> >Fixes: 3948b05950fd ("net: introduce a config option to tweak MAX_SKB_FRAG") >> >Reported-by: Jan Tluka >> >Reported-by: Jirka Hladky >> >Reported-by: Sabrina Dubroca >> >Tested-by: Sabrina Dubroca >> >Tested-by: Corinna Vinschen >> >Signed-off-by: Paolo Abeni >> >--- >> > drivers/net/ethernet/intel/igb/igb_main.c | 1 + >> >> Also, please use get_maintainer.pl script to get cclist. > >done and done in v2 (for which I forgot the "in-reply-to" now, d'uh) In-reply-to is not needed. Send each V to separate thread. > >Thanks, >Corinna > >