All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gao Xiang <xiang@kernel.org>
To: Noboru Asai <asai@sijam.com>, linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH v2] erofs-utils: add missing block counting
Date: Wed, 24 Apr 2024 18:37:55 +0800	[thread overview]
Message-ID: <ZijhA4IJFSO7FYUy@debian> (raw)
In-Reply-To: <288873a1-f594-4f5b-b3a1-881ad7ced1cf@linux.alibaba.com>

On Wed, Apr 24, 2024 at 02:15:58PM +0800, Gao Xiang wrote:
> 
> 
> On 2024/4/24 13:59, Noboru Asai wrote:
> > Add missing block counting when the data to be inlined is not inlined.
> > 
> > ---
> > v2:
> > - move from erofs_write_tail_end() to erofs_prepare_tail_block()
> > 
> > Signed-off-by: Noboru Asai <asai@sijam.com>
> 
> Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>
> 
> Thanks,
> Gao Xiang

I applied the following version since v2 caused CI failure:
https://github.com/erofs/erofsnightly/actions/runs/8812585654


From 89e76dda5fd4956709bbb88b76063ef165fa3882 Mon Sep 17 00:00:00 2001
From: Noboru Asai <asai@sijam.com>
Date: Wed, 24 Apr 2024 14:59:23 +0900
Subject: [PATCH] erofs-utils: add missing block counting

Add missing block counting when the data to be inlined is not inlined.

Signed-off-by: Noboru Asai <asai@sijam.com>
Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
---
 lib/inode.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/inode.c b/lib/inode.c
index 7508c74..896a257 100644
--- a/lib/inode.c
+++ b/lib/inode.c
@@ -664,6 +664,8 @@ static int erofs_prepare_tail_block(struct erofs_inode *inode)
 	} else {
 		inode->lazy_tailblock = true;
 	}
+	if (is_inode_layout_compression(inode))
+		inode->u.i_blocks += 1;
 	return 0;
 }
 
-- 
2.30.2


  reply	other threads:[~2024-04-24 10:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-24  5:59 [PATCH v2] erofs-utils: add missing block counting Noboru Asai
2024-04-24  6:15 ` Gao Xiang
2024-04-24 10:37   ` Gao Xiang [this message]
2024-04-25  2:48     ` Noboru Asai
2024-04-25  7:36       ` Gao Xiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZijhA4IJFSO7FYUy@debian \
    --to=xiang@kernel.org \
    --cc=asai@sijam.com \
    --cc=linux-erofs@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.