From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE772C4345F for ; Wed, 24 Apr 2024 13:01:17 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.711437.1111409 (Exim 4.92) (envelope-from ) id 1rzcFK-0004hC-8S; Wed, 24 Apr 2024 13:01:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 711437.1111409; Wed, 24 Apr 2024 13:01:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rzcFK-0004h5-4X; Wed, 24 Apr 2024 13:01:10 +0000 Received: by outflank-mailman (input) for mailman id 711437; Wed, 24 Apr 2024 13:01:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rzcFI-0004gt-SI for xen-devel@lists.xenproject.org; Wed, 24 Apr 2024 13:01:08 +0000 Received: from mail-oo1-xc29.google.com (mail-oo1-xc29.google.com [2607:f8b0:4864:20::c29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b6ebf509-023a-11ef-909a-e314d9c70b13; Wed, 24 Apr 2024 15:01:08 +0200 (CEST) Received: by mail-oo1-xc29.google.com with SMTP id 006d021491bc7-5aa4204bacdso4018253eaf.2 for ; Wed, 24 Apr 2024 06:01:08 -0700 (PDT) Received: from localhost ([213.195.114.223]) by smtp.gmail.com with ESMTPSA id i6-20020ac87646000000b004377f87147bsm6015666qtr.69.2024.04.24.06.01.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 06:01:06 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b6ebf509-023a-11ef-909a-e314d9c70b13 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1713963666; x=1714568466; darn=lists.xenproject.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=JNddJ5SL36xynIazkoX3Jrx5SgGYvPv5TYSv+gHNmFg=; b=cAPrxdSBzJH72FIIty1sMml8GoTbczHIhAtHmFyVBBifE1KO2bky7mA3/Vfd6dGF6N FEe9Q6gNWKEIOkVDsQry0S2ubnG0rnMTlElh7zSPVo/cerjv2O/3zDGQBQ+JCI+F8OMv VEpj3zW3Rgvf6koG6UG6bMB4Uj+c4cZb+GcvQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713963666; x=1714568466; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JNddJ5SL36xynIazkoX3Jrx5SgGYvPv5TYSv+gHNmFg=; b=BdveUhUDzysh0jYFu+QuxOJzm3PQBWXS6z1NtJ9wui7r+N7o2hw9C29kEwEH2IbBLX Nqw2uBy+z63L+TvRe6/wdxJNbyl4zfD74s2XcpRk66ODClr7UYRnHzc9zqvRKwi8NppY ylWEI34IMA242x8eNoJS57YZR963/hm7CYk5jLV3buKtI6NRNxJ9EQz0pWnDaGHEAvCU 866wJK0RvnNWlEYhpoUoFUKvIV+Abs/iY3JBsEGTAge1sXBE5UuGXF1qNHJL++FV57gY IDpgIO1Z5lqdRr8phDokau6PQlz12vDEhoWisSTnRqLsvfJU6Mu/N4pKgCFssTP7mygs rWgA== X-Gm-Message-State: AOJu0YzcEhVi1q/dUQMHud2j57dnaDHodq/W3naEZ8PUqCoFzhqffdWN KysRab/PjDRnCB5JRNtly3i/OEHDhqIAo0qXJP+HWckcR5f3MF5bkFL6vGISPW0= X-Google-Smtp-Source: AGHT+IHkk0aIEvSsII2USdraviI9Pop/uTbRrizdoV6nyR+voBubUNZAMCDLUh2hcPjcg4JsolnXWQ== X-Received: by 2002:a05:6358:4b02:b0:17f:5ef7:15cc with SMTP id kr2-20020a0563584b0200b0017f5ef715ccmr2582221rwc.3.1713963666571; Wed, 24 Apr 2024 06:01:06 -0700 (PDT) Date: Wed, 24 Apr 2024 15:01:04 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap Subject: Re: [PATCH 3/4] x86/paging: vCPU host mode is always set Message-ID: References: <0d846228-323b-4427-87d1-684c3d0047c5@suse.com> <67805c1f-7187-446c-a5c4-14be8f170f11@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Apr 24, 2024 at 01:41:25PM +0200, Jan Beulich wrote: > On 24.04.2024 11:34, Roger Pau Monné wrote: > > On Tue, Apr 23, 2024 at 04:32:32PM +0200, Jan Beulich wrote: > >> ... thanks to paging_vcpu_init() being part of vCPU creation. Further > >> if paging is enabled on a domain, it's also guaranteed to be either HAP > >> or shadow. Drop respective unnecessary (parts of) conditionals. > > > > Is there some commit that changed when arch.paging.mode gets set, so > > that this is actually safe to do now, but not when the code in > > paging_dump_vcpu_info() was introduced? > > > > I get the feeling we want to reference some change here in order to > > explain why is now always guaranteed to be set. > > I was indeed meaning to, but when I found the same even in 3.2, I stopped > searching further. Fair enough :). Thanks, Roger.