From: Sean Christopherson <seanjc@google.com>
To: Andrew Jones <ajones@ventanamicro.com>
Cc: Markus Elfring <Markus.Elfring@web.de>,
Kunwu Chan <chentao@kylinos.cn>,
linux-kselftest@vger.kernel.org, kvm@vger.kernel.org,
kernel-janitors@vger.kernel.org,
Muhammad Usama Anjum <usama.anjum@collabora.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Shuah Khan <shuah@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Kunwu Chan <kunwu.chan@hotmail.com>,
Anup Patel <anup@brainfault.org>, Thomas Huth <thuth@redhat.com>,
Oliver Upton <oliver.upton@linux.dev>
Subject: Re: [PATCH] KVM: selftests: Add 'malloc' failure check in test_vmx_nested_state
Date: Wed, 24 Apr 2024 07:51:44 -0700 [thread overview]
Message-ID: <ZikcgIhyRbz5APPZ@google.com> (raw)
In-Reply-To: <20240424-e31c64bda7872b0be52e4c16@orel>
On Wed, Apr 24, 2024, Andrew Jones wrote:
> On Tue, Apr 23, 2024 at 12:15:47PM -0700, Sean Christopherson wrote:
> ...
> > I almost wonder if we should just pick a prefix that's less obviously connected
> > to KVM and/or selftests, but unique and short.
> >
>
> How about kvmsft_ ? It's based on the ksft_ prefix of kselftest.h. Maybe
> it's too close to ksft though and would be confusing when using both in
> the same test?
I would prefer something short, and for whatever reason I have a mental block
with ksft. I always read it as "k soft", which is completely nonsensical :-)
> I'm not a huge fan of capital letters, but we could also do something like
> MALLOC()/CALLOC().
Hmm, I'm not usually a fan either, but that could actually work quite well in this
case. It would be quite intuitive, easy to visually parse whereas tmalloc() vs
malloc() kinda looks like a typo, and would more clearly communicate that they're
macros.
next prev parent reply other threads:[~2024-04-24 14:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 7:39 [PATCH] KVM: selftests: Add 'malloc' failure check in test_vmx_nested_state Kunwu Chan
2024-04-23 8:49 ` Muhammad Usama Anjum
2024-04-23 10:45 ` Markus Elfring
2024-04-23 14:56 ` Sean Christopherson
2024-04-23 15:14 ` Andrew Jones
2024-04-23 19:15 ` Sean Christopherson
2024-04-24 2:59 ` Kunwu Chan
2024-04-24 5:41 ` Dan Carpenter
2024-04-24 14:47 ` Sean Christopherson
2024-04-24 7:50 ` Andrew Jones
2024-04-24 14:51 ` Sean Christopherson [this message]
2024-04-24 17:18 ` Oliver Upton
2024-04-25 16:25 ` Sean Christopherson
2024-05-10 8:40 ` Kunwu Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZikcgIhyRbz5APPZ@google.com \
--to=seanjc@google.com \
--cc=Markus.Elfring@web.de \
--cc=ajones@ventanamicro.com \
--cc=anup@brainfault.org \
--cc=chentao@kylinos.cn \
--cc=kernel-janitors@vger.kernel.org \
--cc=kunwu.chan@hotmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=oliver.upton@linux.dev \
--cc=pbonzini@redhat.com \
--cc=shuah@kernel.org \
--cc=thuth@redhat.com \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.