From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f169.google.com (mail-yb1-f169.google.com [209.85.219.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E081E15EFD5 for ; Wed, 24 Apr 2024 15:13:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713971626; cv=none; b=nm60siayRCaYVADmHjVqf7E1c2AGgf5bupaAcuv8wXoyrbeLQumQLQv1p4H9GvVA47rkRX5ClOnXxGs8Aw5j1LSCNqfK5/tEUT79zYgaMVsHkTxIzqjNQRiDtjIBbkDCRIFqhGbnGUn2kqiODmXlWT1LAdrpcgPAH0KuygYPiD8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713971626; c=relaxed/simple; bh=tEDlSX60cFF3XIZCRG8/CfaawTF3zEUuH5YM6XnT0N0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=P2Q0lsC33ZsAS6L5RT4HRPrS6w7dqmlicY/9pVlPHwzgA14WjiNBP6BKSw3WQ4+STE/R40/LlKfKJuoVE+1jsFI7mI0TrVoCelPAAE3ahJgB25ocQaKBX58VW80VEJUZAHRNGPF/5gIp8Ujrn9ykdzR4s40u8K+Op7nrgEG20BM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=zLfthbTS; arc=none smtp.client-ip=209.85.219.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="zLfthbTS" Received: by mail-yb1-f169.google.com with SMTP id 3f1490d57ef6-d9b9adaf291so6759111276.1 for ; Wed, 24 Apr 2024 08:13:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1713971623; x=1714576423; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DAuwXMJJnpPJzeS/QdiiNtiBKl3H6rCtZl+q9pQNJBs=; b=zLfthbTS7c1drv/pKmPJo6pEB4SEyr12UYCnlEzLK+7jUqg1QT4VpMMfSEf8zJ+tRf ZJ1r6n2Bta7gk8tb9mmnUyc4lVovzkaKtCAu06rcPteUDdrGILU30EJuxWsH8ae6k527 y0C8e97FsDxuXqFY4QOx+97woh/xkfJrPT2U+HnVI5p5WWNsnZ3A8mLCAItpgBjzE6wc KTpg+iiMMtytJAkTZSQ+zPH9etwMJrXAUQGrZuYi/5NnxNL88tvvfPy7Htk8TIl7h5Y/ pzOLiTPfAABY3C4L4nAKI5u1R3FiuUNhQs5x0VKtsICRj9iEXa+n40LS+okznaJfGnEk U0Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713971623; x=1714576423; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DAuwXMJJnpPJzeS/QdiiNtiBKl3H6rCtZl+q9pQNJBs=; b=LdeFWoyjjnb7GazGLwF7L6mGZZTeT899Jj45BJF5HHJH1HOJp7fwRAXY6mWv7OpD05 U2TTToYMPeyfZIFh1qSdLMqmmhbhFcSYDRDT4fTi1L3XU65vV9MTBBoJjWwxu6eYW1ud +yGyPxVUo41wY0epwMh3bn862k6naps9cpi1ZAUSwR9Cy/I/eq9tuo1Z8jCua3JKtpso qj+tLOytS8vw9ccnScq1K0h+XmHYM0c0rOn5vYSjVZH2SLLY/qAQKlxdZOT7ghlC/VRO bWBQqB3Qu5mhwu6lOJoJwpW1Fkk6mhxoHz6KIO9DIrOrM1/mNK/ZK/+zJoKAYUwinGoZ hP8A== X-Forwarded-Encrypted: i=1; AJvYcCVZarzU1jyfHpcR78i2f/eJv1Nc7Fqry7WVNjbj0fnfZrUOl1hHRHaqSn82NdN+Ht/fIiswRW/gsYZzETvq4lAL0478yx/CWPzb X-Gm-Message-State: AOJu0Yz63vZPECQz6J8lWer30Qu11Z4PqgpoAvChu0XAYkiwvIQXuDFU LQzl91/clOwE0Q+0CRKbw45+dEulswRCI8DVFcOpG41RkSEpTs26aGiNmK+6fsU= X-Google-Smtp-Source: AGHT+IHhTz3fBZ7peK0ohgK/fsX2BIM1DNpAIBuTraurnQaZqdLiFfMgwIqo7gYns2h/SqUcyMxIMQ== X-Received: by 2002:a05:6902:238a:b0:de5:51d0:9a8d with SMTP id dp10-20020a056902238a00b00de551d09a8dmr3433052ybb.55.1713971622828; Wed, 24 Apr 2024 08:13:42 -0700 (PDT) Received: from ghost ([50.146.0.2]) by smtp.gmail.com with ESMTPSA id s13-20020a056902120d00b00dc73705ec59sm3141332ybu.0.2024.04.24.08.13.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 08:13:42 -0700 (PDT) Date: Wed, 24 Apr 2024 11:13:40 -0400 From: Charlie Jenkins To: Conor Dooley Cc: Alexandre Ghiti , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Guo Ren , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Conor Dooley , Evan Green , =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= , Jonathan Corbet , Shuah Khan , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Palmer Dabbelt , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v3 06/17] riscv: Fix extension subset checking Message-ID: References: <20240420-dev-charlie-support_thead_vector_6_9-v3-0-67cff4271d1d@rivosinc.com> <20240420-dev-charlie-support_thead_vector_6_9-v3-6-67cff4271d1d@rivosinc.com> <6c624361-a968-498b-a9fb-ea2aaec70ce8@ghiti.fr> <20240424-wildly-goofy-c81aac6f8cd7@spud> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240424-wildly-goofy-c81aac6f8cd7@spud> On Wed, Apr 24, 2024 at 03:51:54PM +0100, Conor Dooley wrote: > On Wed, Apr 24, 2024 at 04:22:02PM +0200, Alexandre Ghiti wrote: > > Hi Charlie, > > > > On 21/04/2024 03:04, Charlie Jenkins wrote: > > > This loop is supposed to check if ext->subset_ext_ids[j] is valid, rather > > > than if ext->subset_ext_ids[i] is valid, before setting the extension > > > id ext->subset_ext_ids[j] in isainfo->isa. > > > > > > Signed-off-by: Charlie Jenkins > > > Reviewed-by: Conor Dooley > > > Fixes: 0d8295ed975b ("riscv: add ISA extension parsing for scalar crypto") > > > --- > > > arch/riscv/kernel/cpufeature.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/arch/riscv/kernel/cpufeature.c b/arch/riscv/kernel/cpufeature.c > > > index 48874aac4871..b537731cadef 100644 > > > --- a/arch/riscv/kernel/cpufeature.c > > > +++ b/arch/riscv/kernel/cpufeature.c > > > @@ -609,7 +609,7 @@ static int __init riscv_fill_hwcap_from_ext_list(unsigned long *isa2hwcap) > > > if (ext->subset_ext_size) { > > > for (int j = 0; j < ext->subset_ext_size; j++) { > > > - if (riscv_isa_extension_check(ext->subset_ext_ids[i])) > > > + if (riscv_isa_extension_check(ext->subset_ext_ids[j])) > > > set_bit(ext->subset_ext_ids[j], isainfo->isa); > > > } > > > } > > > > > > > I think this should go into -fixes, let's check with Palmer if he wants to > > take this patch only or if you should send the patch on its own. > > I think splitting out this and patch 1 into a new series targeting fixes > would probably make things clearer? Okay I can do that. I will give it a bit more time before I send this series split into two to allow time for the rest of the patches to gather comments so I avoid sending too many duplicate patches. - Charlie From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D991DC4345F for ; Wed, 24 Apr 2024 15:13:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9kBWfUe7um54rBOnWVIQ8mugu4VSN0eOtB20ypJgiGw=; b=bjG5DjYCJlhcvs u1tOL7TbFRJ05GZlIECisHJNXl5mmAovu9V8rs/Em2ijivD5iUU6SeFU9UTsconNCm7cSLrTFtM3r a6F5GABBzFKYLMI+9k9vQQpBLhycEsNPUhrADJi6Jdyvm9DhQujg/yGsrs/N3kU1yMItlb8WZigSY jTfhh3UW3RfvLAjXiLJNkfIkdBtNucKLkXdUgyAdpGevPXnvTey73eONz6Onj5YEiTVIsVtcID7cM XXebIQIxIQA9u0gBPBCAySeGxnRftcSyP9Lr1A8EPcxKWVDxRq+SQPGSg/fzSqYiQXvvpP9qIJOQD tTe1n2q4o34qbgyUeT3Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzeJh-00000004eIG-2G5d; Wed, 24 Apr 2024 15:13:49 +0000 Received: from mail-yb1-xb30.google.com ([2607:f8b0:4864:20::b30]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzeJd-00000004eHJ-0Yy1 for linux-riscv@lists.infradead.org; Wed, 24 Apr 2024 15:13:47 +0000 Received: by mail-yb1-xb30.google.com with SMTP id 3f1490d57ef6-de45dba15feso7134448276.3 for ; Wed, 24 Apr 2024 08:13:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1713971623; x=1714576423; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DAuwXMJJnpPJzeS/QdiiNtiBKl3H6rCtZl+q9pQNJBs=; b=C+yWrqwV3hdDEZb/OPTlzupbzMQI/N+6+AaPbPCW9qmybMYuanC10LRl1nLt3FPSaf SAuKyL0RqQA9ogOcJ7jDiiAgJWDi7ODOg527+a5mJ9hxPKdFVbl5QuL1x+2UAv0BU90d KMgNuOfhosGDjl1RgyFOGxj0CyaNOEskK+ZD4FoJAdnHXV7hxo3wOuzht8gObvN0aZvh 6+dlDNWwpTnbXtslzMyg3bB0YJLAU1jl9FAiGwpQwccfpY2ZxacJxc4a9PxDMU5WwOjB PMJ4icN7H6gHOneSJwkzreQ96C6fWQdEjEBNiUpiACMVlUojx6kfU13ljPpNjDaYbeuh KEfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713971623; x=1714576423; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DAuwXMJJnpPJzeS/QdiiNtiBKl3H6rCtZl+q9pQNJBs=; b=UZQqxaUyN+JvxoNjF2FzLkaN7ohfBRzDwc+B3G6KjCKeCB795jXls6LARQOWs6mH2g JXwr5VoOvJ6FRJsvePIOuALim23NKL1d4TTBjubZl9WuAmhyuYWX5B72tBFy2nGaLzIF K385iJtuW9SKB5wvhderq6eFIBj2vlYzS00Kc8ISYjM8vTAelTdRlNQGii1bsb12VCAY rnrQWyCCql712c2g9ajSYNk2dZnjqg7MkD9tJ3vnqG9ZcjD7mrkjs1Otq6XbunOjCmgV 7uxPbJosl9/BweQQvVO0qEPbdN4Oszn266TvOQOXUZ5Sg9AZJUAVeXQwCqFDRNxL1qr8 YjdQ== X-Forwarded-Encrypted: i=1; AJvYcCW9UIDmCmqW8jPBGYAVAwQcxWj/A9mNkO6yR3V0Qu6L+B18udW21Psl4DG5rzIsLtIyY+pz5CUxb6txMS2mbFY8Kdaq9SqTb67ylwCk21A2 X-Gm-Message-State: AOJu0YxEiaDTUE0KTQqAEQhntXc39Rq9D2ueG+Lw42LnB/CLAmBdEVfI W/lH+UdX/YVWU33jcUUXZO44TmSaLcmkOwmof4Zm281z2XsopjJl5kKXkYwJUM4= X-Google-Smtp-Source: AGHT+IHhTz3fBZ7peK0ohgK/fsX2BIM1DNpAIBuTraurnQaZqdLiFfMgwIqo7gYns2h/SqUcyMxIMQ== X-Received: by 2002:a05:6902:238a:b0:de5:51d0:9a8d with SMTP id dp10-20020a056902238a00b00de551d09a8dmr3433052ybb.55.1713971622828; Wed, 24 Apr 2024 08:13:42 -0700 (PDT) Received: from ghost ([50.146.0.2]) by smtp.gmail.com with ESMTPSA id s13-20020a056902120d00b00dc73705ec59sm3141332ybu.0.2024.04.24.08.13.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 08:13:42 -0700 (PDT) Date: Wed, 24 Apr 2024 11:13:40 -0400 From: Charlie Jenkins To: Conor Dooley Cc: Alexandre Ghiti , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Guo Ren , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Conor Dooley , Evan Green , =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= , Jonathan Corbet , Shuah Khan , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Palmer Dabbelt , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v3 06/17] riscv: Fix extension subset checking Message-ID: References: <20240420-dev-charlie-support_thead_vector_6_9-v3-0-67cff4271d1d@rivosinc.com> <20240420-dev-charlie-support_thead_vector_6_9-v3-6-67cff4271d1d@rivosinc.com> <6c624361-a968-498b-a9fb-ea2aaec70ce8@ghiti.fr> <20240424-wildly-goofy-c81aac6f8cd7@spud> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240424-wildly-goofy-c81aac6f8cd7@spud> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240424_081345_300331_E2663736 X-CRM114-Status: GOOD ( 25.21 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Wed, Apr 24, 2024 at 03:51:54PM +0100, Conor Dooley wrote: > On Wed, Apr 24, 2024 at 04:22:02PM +0200, Alexandre Ghiti wrote: > > Hi Charlie, > > > > On 21/04/2024 03:04, Charlie Jenkins wrote: > > > This loop is supposed to check if ext->subset_ext_ids[j] is valid, rather > > > than if ext->subset_ext_ids[i] is valid, before setting the extension > > > id ext->subset_ext_ids[j] in isainfo->isa. > > > > > > Signed-off-by: Charlie Jenkins > > > Reviewed-by: Conor Dooley > > > Fixes: 0d8295ed975b ("riscv: add ISA extension parsing for scalar crypto") > > > --- > > > arch/riscv/kernel/cpufeature.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/arch/riscv/kernel/cpufeature.c b/arch/riscv/kernel/cpufeature.c > > > index 48874aac4871..b537731cadef 100644 > > > --- a/arch/riscv/kernel/cpufeature.c > > > +++ b/arch/riscv/kernel/cpufeature.c > > > @@ -609,7 +609,7 @@ static int __init riscv_fill_hwcap_from_ext_list(unsigned long *isa2hwcap) > > > if (ext->subset_ext_size) { > > > for (int j = 0; j < ext->subset_ext_size; j++) { > > > - if (riscv_isa_extension_check(ext->subset_ext_ids[i])) > > > + if (riscv_isa_extension_check(ext->subset_ext_ids[j])) > > > set_bit(ext->subset_ext_ids[j], isainfo->isa); > > > } > > > } > > > > > > > I think this should go into -fixes, let's check with Palmer if he wants to > > take this patch only or if you should send the patch on its own. > > I think splitting out this and patch 1 into a new series targeting fixes > would probably make things clearer? Okay I can do that. I will give it a bit more time before I send this series split into two to allow time for the rest of the patches to gather comments so I avoid sending too many duplicate patches. - Charlie _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB62BC4345F for ; Wed, 24 Apr 2024 15:14:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FCYlz19cVFnAVDjiL8HBJbJpdsXR37acC6kGOzChB9E=; b=Qlyatncn1CEhvW qK/8jYuZu74KjvBJM04udSSdWzTGn/JvBPesF0z4APCdunTIlK/tBOMQXjE2bj5cojKSiyN1anOAa KALohqZnCcX27whzEJVgoAwyZhVBIHi7i4KrlEMYCy3cPv+oDK/WjLC6lK+iTPXiYu/GuYmq0XhE0 xz24jLLv2QtSAX0Ny836WDf/DZy560DDq3bxY9uW2KfCzQCFCMEsn1fUMfp42BTH7t/n3EXf78UHk ykcfb3/E3vRmbku73RPyL8xuYday9823Z3v4DbPtHtHJKJdD9Vr38j6MrcwouE305KW67mjbLbVS/ QzQhB23DqA3tc3fsHxAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzeJg-00000004eIC-3yJ5; Wed, 24 Apr 2024 15:13:48 +0000 Received: from mail-yb1-xb31.google.com ([2607:f8b0:4864:20::b31]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzeJd-00000004eHK-0Yow for linux-arm-kernel@lists.infradead.org; Wed, 24 Apr 2024 15:13:47 +0000 Received: by mail-yb1-xb31.google.com with SMTP id 3f1490d57ef6-de45dba15feso7134449276.3 for ; Wed, 24 Apr 2024 08:13:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1713971623; x=1714576423; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DAuwXMJJnpPJzeS/QdiiNtiBKl3H6rCtZl+q9pQNJBs=; b=C+yWrqwV3hdDEZb/OPTlzupbzMQI/N+6+AaPbPCW9qmybMYuanC10LRl1nLt3FPSaf SAuKyL0RqQA9ogOcJ7jDiiAgJWDi7ODOg527+a5mJ9hxPKdFVbl5QuL1x+2UAv0BU90d KMgNuOfhosGDjl1RgyFOGxj0CyaNOEskK+ZD4FoJAdnHXV7hxo3wOuzht8gObvN0aZvh 6+dlDNWwpTnbXtslzMyg3bB0YJLAU1jl9FAiGwpQwccfpY2ZxacJxc4a9PxDMU5WwOjB PMJ4icN7H6gHOneSJwkzreQ96C6fWQdEjEBNiUpiACMVlUojx6kfU13ljPpNjDaYbeuh KEfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713971623; x=1714576423; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DAuwXMJJnpPJzeS/QdiiNtiBKl3H6rCtZl+q9pQNJBs=; b=qG1XHG26cq3o+RKRkICxt/3qEIZg0YCrVnBpdqkfBC/3Oi3X9X7aVT8bbsjW6Sc4cL wvsJYe8QwrMcJTP5oYwmV98YjqbpDKsBZYPzSGRutc7nX+XQNOiaj6C6zOYvARVbY4H0 dve5VJ2zPNm46IniyBCszjdYBQrBhPTlVmaCXUcYIC/Yd3NsKZiU80gu6dkLaRI/9Sdv FKJWwQ6GN5dIedis+R3hsZqNTPH0jU8bA0mrLoLBkFQc95Tkd09+6mtwqclMeN5lzTPk PslU4sVcm7KP3r9F3Vehv2/v2LMcafiLZGopnDzk5qkBGzFBphJcxE5lHUjrYZC8snRM 8LbQ== X-Forwarded-Encrypted: i=1; AJvYcCVA0SXXzGsMYjlv8QrzGOSA6UE6OqApnMhYfSKkiF1uc33Uh/vk5lrn247nVzhmH0LMjrkjHUfv/jv9JWTNMLxXeouVDT0p95YjW6BOpMFdQ+mRh4Y= X-Gm-Message-State: AOJu0YzgxpVdRGCkl7RjQDLXG64HY9Gw2DAf9Q+aDpiBIqHyd5dSRUDI c5Es/e6Mq+Z1btG2BKzPzqNfTR28FQgL4O+H2mYwZOvrlFxiT9OlnecONUkxksU= X-Google-Smtp-Source: AGHT+IHhTz3fBZ7peK0ohgK/fsX2BIM1DNpAIBuTraurnQaZqdLiFfMgwIqo7gYns2h/SqUcyMxIMQ== X-Received: by 2002:a05:6902:238a:b0:de5:51d0:9a8d with SMTP id dp10-20020a056902238a00b00de551d09a8dmr3433052ybb.55.1713971622828; Wed, 24 Apr 2024 08:13:42 -0700 (PDT) Received: from ghost ([50.146.0.2]) by smtp.gmail.com with ESMTPSA id s13-20020a056902120d00b00dc73705ec59sm3141332ybu.0.2024.04.24.08.13.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 08:13:42 -0700 (PDT) Date: Wed, 24 Apr 2024 11:13:40 -0400 From: Charlie Jenkins To: Conor Dooley Cc: Alexandre Ghiti , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Guo Ren , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Conor Dooley , Evan Green , =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= , Jonathan Corbet , Shuah Khan , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Palmer Dabbelt , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v3 06/17] riscv: Fix extension subset checking Message-ID: References: <20240420-dev-charlie-support_thead_vector_6_9-v3-0-67cff4271d1d@rivosinc.com> <20240420-dev-charlie-support_thead_vector_6_9-v3-6-67cff4271d1d@rivosinc.com> <6c624361-a968-498b-a9fb-ea2aaec70ce8@ghiti.fr> <20240424-wildly-goofy-c81aac6f8cd7@spud> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240424-wildly-goofy-c81aac6f8cd7@spud> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240424_081345_303630_C418562A X-CRM114-Status: GOOD ( 26.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 24, 2024 at 03:51:54PM +0100, Conor Dooley wrote: > On Wed, Apr 24, 2024 at 04:22:02PM +0200, Alexandre Ghiti wrote: > > Hi Charlie, > > > > On 21/04/2024 03:04, Charlie Jenkins wrote: > > > This loop is supposed to check if ext->subset_ext_ids[j] is valid, rather > > > than if ext->subset_ext_ids[i] is valid, before setting the extension > > > id ext->subset_ext_ids[j] in isainfo->isa. > > > > > > Signed-off-by: Charlie Jenkins > > > Reviewed-by: Conor Dooley > > > Fixes: 0d8295ed975b ("riscv: add ISA extension parsing for scalar crypto") > > > --- > > > arch/riscv/kernel/cpufeature.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/arch/riscv/kernel/cpufeature.c b/arch/riscv/kernel/cpufeature.c > > > index 48874aac4871..b537731cadef 100644 > > > --- a/arch/riscv/kernel/cpufeature.c > > > +++ b/arch/riscv/kernel/cpufeature.c > > > @@ -609,7 +609,7 @@ static int __init riscv_fill_hwcap_from_ext_list(unsigned long *isa2hwcap) > > > if (ext->subset_ext_size) { > > > for (int j = 0; j < ext->subset_ext_size; j++) { > > > - if (riscv_isa_extension_check(ext->subset_ext_ids[i])) > > > + if (riscv_isa_extension_check(ext->subset_ext_ids[j])) > > > set_bit(ext->subset_ext_ids[j], isainfo->isa); > > > } > > > } > > > > > > > I think this should go into -fixes, let's check with Palmer if he wants to > > take this patch only or if you should send the patch on its own. > > I think splitting out this and patch 1 into a new series targeting fixes > would probably make things clearer? Okay I can do that. I will give it a bit more time before I send this series split into two to allow time for the rest of the patches to gather comments so I avoid sending too many duplicate patches. - Charlie _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel