From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45587C4345F for ; Thu, 25 Apr 2024 09:02:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tvACK5git9WpWSrstT0kGFb7bKtSP7Oj9178I7kw6ME=; b=RpjE4YTL631N9SpeZgMs4lt1QL KaARhl6EdZCUWOzGINR08E6eEfWSyd76WyZJQV9jh4yEkG5aMFJfD9aBmfVEo12ujyqLta2tfx5EO 53gPdCV348xjsYXyfR5ye5r4jS2leyOhxygaUfP5c7tOhVmDPqCkbRy/M79EqmPB3mGzzFWFQjO6o UBBmGV/fqLgbczT87DQQeIsROejNpLsYIExwVooqggsdOtLmwoBfrpAXXWA7JQ3Gl/pb44YmjuWV9 Eie6xvG8xq0uKndbrWI/OkIkatNi52JCNCypMxBpyfg/JNXsRv4SvX+kh24rg6FqNI2lFcldXK93N +Qa+svVQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzv05-00000007WFj-2yyW; Thu, 25 Apr 2024 09:02:41 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzv00-00000007WCd-2bPD; Thu, 25 Apr 2024 09:02:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=tvACK5git9WpWSrstT0kGFb7bKtSP7Oj9178I7kw6ME=; b=BgY5Mwnj2I06U3tZLcTSnD0qEp HSfXf05N1JTTR7Mkd/4ep9P+YimNnkYcd2TQ2IcjY02wxn056O+0FN2JdtBR6EAfTwSQs4bWXWODB fxmXsbYkxGt9qQlH/fdrWaIdvz1KrIMmxcjWTV5xQ85D+RT1d4RAOK14rMUEejSGX7IuNcSNnckaH KKDL3KobcVNDFZChxcq8sCZ03wyYKROEG9LgXx83Mkt/xz11jVsDpnn8JOh2GK+7K6Ubatrd9+ThQ D1FarkpP2G0qZVdRGAKLn6Oxe62dZE1AeVQOSxDrD5+rTzDycy5qo0IAtbbejq3u559KNqx6D1U/g wy/F+Fuw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:58892) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rzuzU-00077v-2p; Thu, 25 Apr 2024 10:02:05 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1rzuzO-0005Td-Gu; Thu, 25 Apr 2024 10:01:58 +0100 Date: Thu, 25 Apr 2024 10:01:58 +0100 From: "Russell King (Oracle)" To: Sky Huang Cc: Andrew Lunn , Heiner Kallweit , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Daniel Golle , Qingfang Deng , Matthias Brugger , AngeloGioacchino Del Regno , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Steven Liu Subject: Re: [PATCH 3/3] net: phy: mediatek: add support for built-in 2.5G ethernet PHY on MT7988 Message-ID: References: <20240425023325.15586-1-SkyLake.Huang@mediatek.com> <20240425023325.15586-4-SkyLake.Huang@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240425023325.15586-4-SkyLake.Huang@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240425_020237_023010_8853D512 X-CRM114-Status: GOOD ( 18.08 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, Apr 25, 2024 at 10:33:25AM +0800, Sky Huang wrote: > +static int mt7988_2p5ge_phy_config_init(struct phy_device *phydev) > +{ > + int ret, i; > + const struct firmware *fw; > + struct device *dev = &phydev->mdio.dev; > + struct device_node *np; > + void __iomem *pmb_addr; > + void __iomem *md32_en_cfg_base; > + struct mtk_i2p5ge_phy_priv *priv = phydev->priv; > + u16 reg; > + struct pinctrl *pinctrl; > + > + if (!priv->fw_loaded) { > + np = of_find_compatible_node(NULL, NULL, "mediatek,2p5gphy-fw"); > + if (!np) > + return -ENOENT; > + pmb_addr = of_iomap(np, 0); > + if (!pmb_addr) > + return -ENOMEM; > + md32_en_cfg_base = of_iomap(np, 1); > + if (!md32_en_cfg_base) > + return -ENOMEM; Wouldn't it be better to do this in the probe function rather than here? > + > + ret = request_firmware(&fw, MT7988_2P5GE_PMB, dev); > + if (ret) { > + dev_err(dev, "failed to load firmware: %s, ret: %d\n", > + MT7988_2P5GE_PMB, ret); > + return ret; > + } This will block for userspace while holding phydev->lock and the RTNL. That blocks much of the networking APIs, which is not a good idea. If you have a number of these PHYs, then the RTNL will serialise the loading of firmware. > + > + reg = readw(md32_en_cfg_base); > + if (reg & MD32_EN) { > + phy_set_bits(phydev, 0, BIT(15)); This is probably the BMCR, so if it is, please use the established definitions. > + usleep_range(10000, 11000); > + } > + phy_set_bits(phydev, 0, BIT(11)); This also looks like it's probably the BMCR. > + > + /* Write magic number to safely stall MCU */ > + phy_write_mmd(phydev, MDIO_MMD_VEND1, 0x800e, 0x1100); > + phy_write_mmd(phydev, MDIO_MMD_VEND1, 0x800f, 0x00df); > + > + for (i = 0; i < fw->size - 1; i += 4) > + writel(*((uint32_t *)(fw->data + i)), pmb_addr + i); > + release_firmware(fw); > + > + writew(reg & ~MD32_EN, md32_en_cfg_base); > + writew(reg | MD32_EN, md32_en_cfg_base); > + phy_set_bits(phydev, 0, BIT(15)); And also probably the BMCR. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F23CC4345F for ; Thu, 25 Apr 2024 09:03:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cCDU+7Yh6O51OMGa8F2IsvmzKAkmAOUHyEZEs7tKZfQ=; b=v6WFAGa9bhXdOH AxUCc3NkN8g2Rtcmi/MJEYBZreVtqkZl/hC7AkHNSGt9dslan9SHFvJKLKvqO30bLOmMFDYHiMEcA m/DATZvA3Qbo+booQrs9T1lL/lyA97PeI7xNpoX+l63lg4E7S7rUWftFyPIyp1s5k/uISEjP4lmrD 6WqlbQNJvvngnyuNWn8Jhxs4XtTbw3o/tilmOEPP2Mgf1v7jl5CJav5TMTld8yMCigTWvu1k7bKoB 0o8Y7kDJ7Qvzetcd8+hgQGUaS7SfaG7truIWK1Q+KgOIcxkKIrhkAP4URgK+jsxqX6MfibQUes8id UuSND0EmsNZOUwOnwVaw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzv05-00000007WFG-0QIG; Thu, 25 Apr 2024 09:02:41 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzv00-00000007WCd-2bPD; Thu, 25 Apr 2024 09:02:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=tvACK5git9WpWSrstT0kGFb7bKtSP7Oj9178I7kw6ME=; b=BgY5Mwnj2I06U3tZLcTSnD0qEp HSfXf05N1JTTR7Mkd/4ep9P+YimNnkYcd2TQ2IcjY02wxn056O+0FN2JdtBR6EAfTwSQs4bWXWODB fxmXsbYkxGt9qQlH/fdrWaIdvz1KrIMmxcjWTV5xQ85D+RT1d4RAOK14rMUEejSGX7IuNcSNnckaH KKDL3KobcVNDFZChxcq8sCZ03wyYKROEG9LgXx83Mkt/xz11jVsDpnn8JOh2GK+7K6Ubatrd9+ThQ D1FarkpP2G0qZVdRGAKLn6Oxe62dZE1AeVQOSxDrD5+rTzDycy5qo0IAtbbejq3u559KNqx6D1U/g wy/F+Fuw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:58892) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rzuzU-00077v-2p; Thu, 25 Apr 2024 10:02:05 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1rzuzO-0005Td-Gu; Thu, 25 Apr 2024 10:01:58 +0100 Date: Thu, 25 Apr 2024 10:01:58 +0100 From: "Russell King (Oracle)" To: Sky Huang Cc: Andrew Lunn , Heiner Kallweit , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Daniel Golle , Qingfang Deng , Matthias Brugger , AngeloGioacchino Del Regno , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Steven Liu Subject: Re: [PATCH 3/3] net: phy: mediatek: add support for built-in 2.5G ethernet PHY on MT7988 Message-ID: References: <20240425023325.15586-1-SkyLake.Huang@mediatek.com> <20240425023325.15586-4-SkyLake.Huang@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240425023325.15586-4-SkyLake.Huang@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240425_020237_023010_8853D512 X-CRM114-Status: GOOD ( 18.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 25, 2024 at 10:33:25AM +0800, Sky Huang wrote: > +static int mt7988_2p5ge_phy_config_init(struct phy_device *phydev) > +{ > + int ret, i; > + const struct firmware *fw; > + struct device *dev = &phydev->mdio.dev; > + struct device_node *np; > + void __iomem *pmb_addr; > + void __iomem *md32_en_cfg_base; > + struct mtk_i2p5ge_phy_priv *priv = phydev->priv; > + u16 reg; > + struct pinctrl *pinctrl; > + > + if (!priv->fw_loaded) { > + np = of_find_compatible_node(NULL, NULL, "mediatek,2p5gphy-fw"); > + if (!np) > + return -ENOENT; > + pmb_addr = of_iomap(np, 0); > + if (!pmb_addr) > + return -ENOMEM; > + md32_en_cfg_base = of_iomap(np, 1); > + if (!md32_en_cfg_base) > + return -ENOMEM; Wouldn't it be better to do this in the probe function rather than here? > + > + ret = request_firmware(&fw, MT7988_2P5GE_PMB, dev); > + if (ret) { > + dev_err(dev, "failed to load firmware: %s, ret: %d\n", > + MT7988_2P5GE_PMB, ret); > + return ret; > + } This will block for userspace while holding phydev->lock and the RTNL. That blocks much of the networking APIs, which is not a good idea. If you have a number of these PHYs, then the RTNL will serialise the loading of firmware. > + > + reg = readw(md32_en_cfg_base); > + if (reg & MD32_EN) { > + phy_set_bits(phydev, 0, BIT(15)); This is probably the BMCR, so if it is, please use the established definitions. > + usleep_range(10000, 11000); > + } > + phy_set_bits(phydev, 0, BIT(11)); This also looks like it's probably the BMCR. > + > + /* Write magic number to safely stall MCU */ > + phy_write_mmd(phydev, MDIO_MMD_VEND1, 0x800e, 0x1100); > + phy_write_mmd(phydev, MDIO_MMD_VEND1, 0x800f, 0x00df); > + > + for (i = 0; i < fw->size - 1; i += 4) > + writel(*((uint32_t *)(fw->data + i)), pmb_addr + i); > + release_firmware(fw); > + > + writew(reg & ~MD32_EN, md32_en_cfg_base); > + writew(reg | MD32_EN, md32_en_cfg_base); > + phy_set_bits(phydev, 0, BIT(15)); And also probably the BMCR. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel