Re: [PATCH 01/29] include: move include/qapi/qmp/ to include/qobject/

["Daniel P. Berrangé" <berrange@redhat.com>]

On Thu, Apr 25, 2024 at 11:34:46AM +0200, Markus Armbruster wrote:
> I just realized I dropped this on the floor.  I apologize for the delay.
> 
> Daniel P. Berrangé <berrange@redhat.com> writes:
> 
> > On Mon, Jan 08, 2024 at 06:23:37PM +0000, Daniel P. Berrangé wrote:
> >> The general expectation is that header files should follow the same
> >> file/path naming scheme as the corresponding source file. There are
> >> various historical exceptions to this practice in QEMU, with one of
> >> the most notable being the include/qapi/qmp/ directory. Most of the
> >> headers there correspond to source files in qobject/.
> >> 
> >> This patch corrects that inconsistency by creating include/qobject/.
> 
> Yes, there's inconsistency, but is it worth cleaning up?  Since you did
> the work already, and sunk cost doesn't count, ...

The motivation is my own inability to remaember that the qboject/*.c
header files are in include/qapi/qmp/. I only need to find them
every 6-12 months or so, and thus I've always forgotten their wierd
location by that point !

> >> To allow the code to continue to build, symlinks are temporarily
> >> added in $QEMU/qapi/qmp/ to point to the new location. They will
> >> be removed in a later commit.
> 
> Only necessary to let you split the patch updating #include directives.
> The update is entirely mechanical, isn't it?  I doubt splitting is worth
> the trouble then.

Yes, it was to allow succesfully building at each patch.
Changes were basically a sed/perl command IIRC.


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|