From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
Juergen Gross <jgross@suse.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
Julien Grall <julien@xen.org>,
Stefano Stabellini <sstabellini@kernel.org>,
Ross Lagerwall <ross.lagerwall@citrix.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v4 2/4] livepatch: introduce --force option
Date: Fri, 26 Apr 2024 09:15:06 +0200 [thread overview]
Message-ID: <ZitUeq8ugOKHb_QA@macbook> (raw)
In-Reply-To: <a7dd1c1e-76b8-437e-bfbc-111a904ab861@suse.com>
On Fri, Apr 26, 2024 at 08:41:48AM +0200, Jan Beulich wrote:
> On 24.04.2024 10:19, Roger Pau Monne wrote:
> > @@ -571,6 +575,19 @@ int main(int argc, char *argv[])
> > show_help();
> > return 0;
> > }
> > +
> > + if ( strcmp("--force", argv[1]) )
>
> I guess this missing ! or "== 0" is the reason for osstest reporting a
> livepatch-run failure.
Bah, seems like I dropped it when changing from strncmp to strcmp, as
it's present in v3.
Will send a fix ASAP.
Thanks, Roger.
next prev parent reply other threads:[~2024-04-26 7:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 8:19 [PATCH v4 0/4] livepatch: minor bug fixes and improvements Roger Pau Monne
2024-04-24 8:19 ` [PATCH v4 1/4] xen-livepatch: fix parameter name parsing Roger Pau Monne
2024-04-24 15:29 ` Anthony PERARD
2024-04-25 14:33 ` Ross Lagerwall
2024-04-24 8:19 ` [PATCH v4 2/4] livepatch: introduce --force option Roger Pau Monne
2024-04-26 6:41 ` Jan Beulich
2024-04-26 7:15 ` Roger Pau Monné [this message]
2024-04-24 8:19 ` [PATCH v4 3/4] livepatch: refuse to resolve symbols that belong to init sections Roger Pau Monne
2024-04-25 11:46 ` Roger Pau Monné
2024-04-24 8:19 ` [PATCH v4 4/4] x86/livepatch: perform sanity checks on the payload exception table contents Roger Pau Monne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZitUeq8ugOKHb_QA@macbook \
--to=roger.pau@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=julien@xen.org \
--cc=ross.lagerwall@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.