From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA0783610A; Fri, 26 Apr 2024 15:45:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714146323; cv=none; b=GovL7xmeGUPSDesLZvh4LJfuwL60VQFhOksXe5b9kgodOIQS2kqbT0EbNxKx8AukJ6tMiPYs/3JgwKxZyq/Nzn3lbT/5V95JUG9lQkVZjw5+7NdKeYJw3Y+egNTvO4NcIg4lIqgfubPmdkclevaM9L5sVWMnWwZdUPBtfgzRw/U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714146323; c=relaxed/simple; bh=3q1rFP3fkaatP7Ce6Ut88qG5Pe9hnHyuLRWNk6LfS88=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kjowSdSgTqQWNvECRScvim9V/WTbCedjRRaM60UI8Yg/kPIiFyE2ovnpU6QZylyWTfgHM+4PBODNGbrTi1x+p75hjLJOQTiz850l3T6IPIAkTBS3P5S9nbKxaTA0DRBAmBZdy6ZTGZsq0CHVRnhf+o/GQ4cJG+qzNzJI4KHpmgE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=jX+fdv+m; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="jX+fdv+m" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714146322; x=1745682322; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=3q1rFP3fkaatP7Ce6Ut88qG5Pe9hnHyuLRWNk6LfS88=; b=jX+fdv+maG1jCfhEv+k6iK/shwOK0AUioa5fRQ+oRfltFiYEU7A3cs6N fQEV5XzunP2PBAKGB/pfc+r3MBpDchuX90Rrx3H4kta+zMjOHEeK55IVt RBdjSKpz+F2GuuC7qNSbbiuaGS1QwOej0VprikuDjLZG8M57vJvZTk9e7 VtF79/Iq0t+1e1xh1TNAXPPoDhcsmRZlEWrNIN3EphK5xZEeOOhtwHhTR oz7XRyNcR5M88xiNyHMKMV+tSnzDw4F49Wdk7LLBRZxzrj6707podIF22 YMdUqMob5HpTZnUtBl+dJzhWkag3fXyIcc8nq/jGijX3kgvDbwe7KZqW+ A==; X-CSE-ConnectionGUID: P2hQ1tn3QvWSo8TYAUe4xA== X-CSE-MsgGUID: FezPcpM6QsCyiaQYTJW2Iw== X-IronPort-AV: E=McAfee;i="6600,9927,11056"; a="13674278" X-IronPort-AV: E=Sophos;i="6.07,233,1708416000"; d="scan'208";a="13674278" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2024 08:45:20 -0700 X-CSE-ConnectionGUID: HgJh5Oz/QCykWNGoswnlEQ== X-CSE-MsgGUID: WUOakU+kRoCAt0hmLCwqCQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,233,1708416000"; d="scan'208";a="25531266" Received: from smile.fi.intel.com ([10.237.72.54]) by fmviesa010.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2024 08:45:18 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1s0NlD-00000001Mo4-0ney; Fri, 26 Apr 2024 18:45:15 +0300 Date: Fri, 26 Apr 2024 18:45:14 +0300 From: Andy Shevchenko To: Jernej =?utf-8?Q?=C5=A0krabec?= Cc: Samuel Holland , linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Pavel Machek , Lee Jones , Chen-Yu Tsai Subject: Re: [PATCH v1 1/1] leds: sun50i-a100: Use match_string() helper to simplify the code Message-ID: References: <20240426152515.872917-1-andriy.shevchenko@linux.intel.com> <3557566.iIbC2pHGDl@jernej-laptop> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3557566.iIbC2pHGDl@jernej-laptop> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Fri, Apr 26, 2024 at 05:37:42PM +0200, Jernej Škrabec wrote: > Dne petek, 26. april 2024 ob 17:25:15 GMT +2 je Andy Shevchenko napisal(a): ... > > + return dev_err_probe(dev, i, "Bad pixel format '%s'\n", format); > > I know that old code used dev_err_probe() without reason, but could you change > it to ordinary dev_err()? First of all, it's out of scope of _this_ patch. > dev_err_probe() is useful only when return code could be -EPROBE_DEFER. This is simply not true. We are trying to have a uniform output in ->probe() and even documentation for dev_err_probe() was changed long time ago to encourage using it for non deferred probe cases. > This is clearly not the case here. Is it a problem? -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3EE63C4345F for ; Fri, 26 Apr 2024 15:45:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=i+PNwEUQMgTTr71jVlRsiEGLG1BrumtyqgTm1scT+Rg=; b=CPj4h2nrq58ENv dbGGL4XGaOQuzq70c+kq+q+nfxT1r7DBcdenccsTnWU+8CnP4xBsuzJVxHq80BXFPXAPMXk41M4PV SG7ac2a3m/4RelYS/Xc003g7AlfNWtUQjB6OCkvHsMXfBbw/yP26kiei9EaRpZckHhp1afEoRjQvF 9azT7ZSLjjvqLLViwZnW/G6a9SlSO+3dNV3VuEk6TifFc2CBErwaOWM8tmi53G0pXpQnQzOi/Lq4v zWK9xqI8yu7SQoh9syQayCxz1E/694SBwIzCvSxL0c/Msgsnbkf/cKvqHOYSzgfxpSvWDDMBBPl0s RCbmSHiiI+4xt1iqpGpA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s0NlQ-0000000D7Bf-2GTD; Fri, 26 Apr 2024 15:45:28 +0000 Received: from mgamail.intel.com ([192.198.163.12]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s0NlJ-0000000D79l-20Qr for linux-arm-kernel@lists.infradead.org; Fri, 26 Apr 2024 15:45:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714146322; x=1745682322; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=3q1rFP3fkaatP7Ce6Ut88qG5Pe9hnHyuLRWNk6LfS88=; b=jX+fdv+maG1jCfhEv+k6iK/shwOK0AUioa5fRQ+oRfltFiYEU7A3cs6N fQEV5XzunP2PBAKGB/pfc+r3MBpDchuX90Rrx3H4kta+zMjOHEeK55IVt RBdjSKpz+F2GuuC7qNSbbiuaGS1QwOej0VprikuDjLZG8M57vJvZTk9e7 VtF79/Iq0t+1e1xh1TNAXPPoDhcsmRZlEWrNIN3EphK5xZEeOOhtwHhTR oz7XRyNcR5M88xiNyHMKMV+tSnzDw4F49Wdk7LLBRZxzrj6707podIF22 YMdUqMob5HpTZnUtBl+dJzhWkag3fXyIcc8nq/jGijX3kgvDbwe7KZqW+ A==; X-CSE-ConnectionGUID: MQrBzT5VTsWmBrGy5Cq2tg== X-CSE-MsgGUID: 3vAjj0IdSHq9jSYrzOq2PQ== X-IronPort-AV: E=McAfee;i="6600,9927,11056"; a="13674280" X-IronPort-AV: E=Sophos;i="6.07,233,1708416000"; d="scan'208";a="13674280" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2024 08:45:20 -0700 X-CSE-ConnectionGUID: HgJh5Oz/QCykWNGoswnlEQ== X-CSE-MsgGUID: WUOakU+kRoCAt0hmLCwqCQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,233,1708416000"; d="scan'208";a="25531266" Received: from smile.fi.intel.com ([10.237.72.54]) by fmviesa010.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2024 08:45:18 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1s0NlD-00000001Mo4-0ney; Fri, 26 Apr 2024 18:45:15 +0300 Date: Fri, 26 Apr 2024 18:45:14 +0300 From: Andy Shevchenko To: Jernej =?utf-8?Q?=C5=A0krabec?= Cc: Samuel Holland , linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Pavel Machek , Lee Jones , Chen-Yu Tsai Subject: Re: [PATCH v1 1/1] leds: sun50i-a100: Use match_string() helper to simplify the code Message-ID: References: <20240426152515.872917-1-andriy.shevchenko@linux.intel.com> <3557566.iIbC2pHGDl@jernej-laptop> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3557566.iIbC2pHGDl@jernej-laptop> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240426_084521_574985_001E5FB1 X-CRM114-Status: GOOD ( 11.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBBcHIgMjYsIDIwMjQgYXQgMDU6Mzc6NDJQTSArMDIwMCwgSmVybmVqIMWga3JhYmVj IHdyb3RlOgo+IERuZSBwZXRlaywgMjYuIGFwcmlsIDIwMjQgb2IgMTc6MjU6MTUgR01UICsyIGpl IEFuZHkgU2hldmNoZW5rbyBuYXBpc2FsKGEpOgoKLi4uCgo+ID4gKwkJcmV0dXJuIGRldl9lcnJf cHJvYmUoZGV2LCBpLCAiQmFkIHBpeGVsIGZvcm1hdCAnJXMnXG4iLCBmb3JtYXQpOwo+IAo+IEkg a25vdyB0aGF0IG9sZCBjb2RlIHVzZWQgZGV2X2Vycl9wcm9iZSgpIHdpdGhvdXQgcmVhc29uLCBi dXQgY291bGQgeW91IGNoYW5nZQo+IGl0IHRvIG9yZGluYXJ5IGRldl9lcnIoKT8KCkZpcnN0IG9m IGFsbCwgaXQncyBvdXQgb2Ygc2NvcGUgb2YgX3RoaXNfIHBhdGNoLgoKPiBkZXZfZXJyX3Byb2Jl KCkgaXMgdXNlZnVsIG9ubHkgd2hlbiByZXR1cm4gY29kZSBjb3VsZCBiZSAtRVBST0JFX0RFRkVS LgoKVGhpcyBpcyBzaW1wbHkgbm90IHRydWUuIFdlIGFyZSB0cnlpbmcgdG8gaGF2ZSBhIHVuaWZv cm0gb3V0cHV0IGluIC0+cHJvYmUoKQphbmQgZXZlbiBkb2N1bWVudGF0aW9uIGZvciBkZXZfZXJy X3Byb2JlKCkgd2FzIGNoYW5nZWQgbG9uZyB0aW1lIGFnbyB0bwplbmNvdXJhZ2UgdXNpbmcgaXQg Zm9yIG5vbiBkZWZlcnJlZCBwcm9iZSBjYXNlcy4KCj4gVGhpcyBpcyBjbGVhcmx5IG5vdCB0aGUg Y2FzZSBoZXJlLgoKSXMgaXQgYSBwcm9ibGVtPwoKLS0gCldpdGggQmVzdCBSZWdhcmRzLApBbmR5 IFNoZXZjaGVua28KCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0 cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtYXJtLWtlcm5lbAo=