From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81A468248D; Fri, 26 Apr 2024 16:33:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714149199; cv=none; b=j/pL5GNSj6zPehvWvnSLbGF8nXwW3lyAiqtGyYyjkv0PzqO3gRD7LNDYTb4b66/S2Kd/UIviHRyPg3c9O9Suillrco6Gon4YUJR9p5+IURnSgBB4+iFh59D/diiFjbUTcK2xUS0P62F9nnncrj/gtstoL5Mpmvgtq0KqFar9lK4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714149199; c=relaxed/simple; bh=5wObAx7pU4rmk/jDQAZhcRGAbFX+y+N7wcbVVWc1/3U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FLMBxzOXudS1IVqNmJ6mFrMFFl2hBQXmOOeAn98AKW6jjHOYwzL+GaZoztHApBDa8A0+u+gPRhBoV1M/QbWXn+SK3UC6WNhEXj9hYnNl1HDPQTkgD+PGlBo1mRPm6aosPIXTOQnmE2+jW1qjUVNr0Lvx5lcvNPoPFXdiEIcZoNk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=IH7Ns+tZ; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="IH7Ns+tZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714149198; x=1745685198; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=5wObAx7pU4rmk/jDQAZhcRGAbFX+y+N7wcbVVWc1/3U=; b=IH7Ns+tZz+NoqNpLWMCL78NqBPVyv33qDPXlrth233acrEk90zArqTY+ PK7mmF+Zt82Rl1KGsyykrGiKiMj51p60wqBb2sJ+cfqAaV41Yk3wRH0y9 rEK1LXMmAYQTl4BNLjNwO4klKWlhTAqBfMcBQrX41OEZpSMDeFB0NcuEU 7GVWi0gfB+pc/h0Qzz0NFj1zjqcvhvNJw1mhYvAcT/zKczT+fDjngsm1W Pog/dm54BQESIdzqOlgY22evmTD7vhgk0I6jPlnPlPn9UH5ZlDkq/H5PI o7tKtUMSDm1SBgLB6WlDbpXZTlWXEtSugnc7DGc0ck14b5NnzkkPSUwd+ g==; X-CSE-ConnectionGUID: AimtCasHReq1hl9FmwSQiQ== X-CSE-MsgGUID: mXzcWK/tTM6XpDaDXjWxQg== X-IronPort-AV: E=McAfee;i="6600,9927,11056"; a="21299055" X-IronPort-AV: E=Sophos;i="6.07,233,1708416000"; d="scan'208";a="21299055" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2024 09:33:17 -0700 X-CSE-ConnectionGUID: GrHn9nksTE+kgmSKxHHj+Q== X-CSE-MsgGUID: oqLZWI5HQyK6FZgPEVDJWA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,233,1708416000"; d="scan'208";a="25470044" Received: from smile.fi.intel.com ([10.237.72.54]) by fmviesa007.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2024 09:33:09 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1s0OVT-00000001OBZ-2UXq; Fri, 26 Apr 2024 19:33:03 +0300 Date: Fri, 26 Apr 2024 19:33:03 +0300 From: Andy Shevchenko To: Jernej =?utf-8?Q?=C5=A0krabec?= Cc: Samuel Holland , linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Pavel Machek , Lee Jones , Chen-Yu Tsai Subject: Re: [PATCH v1 1/1] leds: sun50i-a100: Use match_string() helper to simplify the code Message-ID: References: <20240426152515.872917-1-andriy.shevchenko@linux.intel.com> <3557566.iIbC2pHGDl@jernej-laptop> <8403927.NyiUUSuA9g@jernej-laptop> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8403927.NyiUUSuA9g@jernej-laptop> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Fri, Apr 26, 2024 at 05:55:22PM +0200, Jernej Škrabec wrote: > Dne petek, 26. april 2024 ob 17:45:14 GMT +2 je Andy Shevchenko napisal(a): > > On Fri, Apr 26, 2024 at 05:37:42PM +0200, Jernej Škrabec wrote: > > > Dne petek, 26. april 2024 ob 17:25:15 GMT +2 je Andy Shevchenko napisal(a): ... > > > > + return dev_err_probe(dev, i, "Bad pixel format '%s'\n", format); > > > > > > I know that old code used dev_err_probe() without reason, but could you change > > > it to ordinary dev_err()? > > > > First of all, it's out of scope of _this_ patch. > > > > > dev_err_probe() is useful only when return code could be -EPROBE_DEFER. > > > > This is simply not true. We are trying to have a uniform output in ->probe() > > and even documentation for dev_err_probe() was changed long time ago to > > encourage using it for non deferred probe cases. > > > > > This is clearly not the case here. > > > > Is it a problem? > > Sorry, I missed added note for non -EPROBE_DEFER cases. No problem. > Reviewed-by: Jernej Skrabec Thank you for the review! -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC267C4345F for ; Fri, 26 Apr 2024 16:33:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6uGqLtjURLdnk859tHrlLYc9D93cAnP1hyhTSzeebpg=; b=mjZBETmjyMVq1o ywrSntZOZC8i1nZRRREj/lfJdpUvYzY4ovxZZZfpaipP2doS0fXTxKrCXlg6keEw+SRmTlJtWEmEI pvUzZlbbpIpoyfpxtjRgHq9sQaGPoYJkMk62N866V7Hz95DAtoOy58b+5+fMm3MLiJGXZzSQeoVFT 4/0VRwc+c+/VpoRQI9KZI6NmROeDo0JOFIJLH5Xz+xyNhThNlEfGWIdayPDfgqqoc9HjXKRTdF97e VgL87pccLzf//y4ixPZSC4pgPCLQt0c1aEDwOHhka6i/qSS/b7hAYkjjpWYBc1l6+xNVop5j+G0kU GHrAkX+zvZD56rgHPlKA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s0OVl-0000000DGpa-1blJ; Fri, 26 Apr 2024 16:33:21 +0000 Received: from mgamail.intel.com ([192.198.163.10]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s0OVi-0000000DGnm-19MZ for linux-arm-kernel@lists.infradead.org; Fri, 26 Apr 2024 16:33:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714149198; x=1745685198; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=5wObAx7pU4rmk/jDQAZhcRGAbFX+y+N7wcbVVWc1/3U=; b=IH7Ns+tZz+NoqNpLWMCL78NqBPVyv33qDPXlrth233acrEk90zArqTY+ PK7mmF+Zt82Rl1KGsyykrGiKiMj51p60wqBb2sJ+cfqAaV41Yk3wRH0y9 rEK1LXMmAYQTl4BNLjNwO4klKWlhTAqBfMcBQrX41OEZpSMDeFB0NcuEU 7GVWi0gfB+pc/h0Qzz0NFj1zjqcvhvNJw1mhYvAcT/zKczT+fDjngsm1W Pog/dm54BQESIdzqOlgY22evmTD7vhgk0I6jPlnPlPn9UH5ZlDkq/H5PI o7tKtUMSDm1SBgLB6WlDbpXZTlWXEtSugnc7DGc0ck14b5NnzkkPSUwd+ g==; X-CSE-ConnectionGUID: hyXGaE3vSLGYUuuhYH4Tpw== X-CSE-MsgGUID: As6F4hWOTHa5LQs3WnjtOw== X-IronPort-AV: E=McAfee;i="6600,9927,11056"; a="21299057" X-IronPort-AV: E=Sophos;i="6.07,233,1708416000"; d="scan'208";a="21299057" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2024 09:33:17 -0700 X-CSE-ConnectionGUID: GrHn9nksTE+kgmSKxHHj+Q== X-CSE-MsgGUID: oqLZWI5HQyK6FZgPEVDJWA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,233,1708416000"; d="scan'208";a="25470044" Received: from smile.fi.intel.com ([10.237.72.54]) by fmviesa007.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2024 09:33:09 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1s0OVT-00000001OBZ-2UXq; Fri, 26 Apr 2024 19:33:03 +0300 Date: Fri, 26 Apr 2024 19:33:03 +0300 From: Andy Shevchenko To: Jernej =?utf-8?Q?=C5=A0krabec?= Cc: Samuel Holland , linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Pavel Machek , Lee Jones , Chen-Yu Tsai Subject: Re: [PATCH v1 1/1] leds: sun50i-a100: Use match_string() helper to simplify the code Message-ID: References: <20240426152515.872917-1-andriy.shevchenko@linux.intel.com> <3557566.iIbC2pHGDl@jernej-laptop> <8403927.NyiUUSuA9g@jernej-laptop> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8403927.NyiUUSuA9g@jernej-laptop> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240426_093318_380307_3B5FF5E1 X-CRM114-Status: GOOD ( 18.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBBcHIgMjYsIDIwMjQgYXQgMDU6NTU6MjJQTSArMDIwMCwgSmVybmVqIMWga3JhYmVj IHdyb3RlOgo+IERuZSBwZXRlaywgMjYuIGFwcmlsIDIwMjQgb2IgMTc6NDU6MTQgR01UICsyIGpl IEFuZHkgU2hldmNoZW5rbyBuYXBpc2FsKGEpOgo+ID4gT24gRnJpLCBBcHIgMjYsIDIwMjQgYXQg MDU6Mzc6NDJQTSArMDIwMCwgSmVybmVqIMWga3JhYmVjIHdyb3RlOgo+ID4gPiBEbmUgcGV0ZWss IDI2LiBhcHJpbCAyMDI0IG9iIDE3OjI1OjE1IEdNVCArMiBqZSBBbmR5IFNoZXZjaGVua28gbmFw aXNhbChhKToKCi4uLgoKPiA+ID4gPiArCQlyZXR1cm4gZGV2X2Vycl9wcm9iZShkZXYsIGksICJC YWQgcGl4ZWwgZm9ybWF0ICclcydcbiIsIGZvcm1hdCk7Cj4gPiA+IAo+ID4gPiBJIGtub3cgdGhh dCBvbGQgY29kZSB1c2VkIGRldl9lcnJfcHJvYmUoKSB3aXRob3V0IHJlYXNvbiwgYnV0IGNvdWxk IHlvdSBjaGFuZ2UKPiA+ID4gaXQgdG8gb3JkaW5hcnkgZGV2X2VycigpPwo+ID4gCj4gPiBGaXJz dCBvZiBhbGwsIGl0J3Mgb3V0IG9mIHNjb3BlIG9mIF90aGlzXyBwYXRjaC4KPiA+IAo+ID4gPiBk ZXZfZXJyX3Byb2JlKCkgaXMgdXNlZnVsIG9ubHkgd2hlbiByZXR1cm4gY29kZSBjb3VsZCBiZSAt RVBST0JFX0RFRkVSLgo+ID4gCj4gPiBUaGlzIGlzIHNpbXBseSBub3QgdHJ1ZS4gV2UgYXJlIHRy eWluZyB0byBoYXZlIGEgdW5pZm9ybSBvdXRwdXQgaW4gLT5wcm9iZSgpCj4gPiBhbmQgZXZlbiBk b2N1bWVudGF0aW9uIGZvciBkZXZfZXJyX3Byb2JlKCkgd2FzIGNoYW5nZWQgbG9uZyB0aW1lIGFn byB0bwo+ID4gZW5jb3VyYWdlIHVzaW5nIGl0IGZvciBub24gZGVmZXJyZWQgcHJvYmUgY2FzZXMu Cj4gPiAKPiA+ID4gVGhpcyBpcyBjbGVhcmx5IG5vdCB0aGUgY2FzZSBoZXJlLgo+ID4gCj4gPiBJ cyBpdCBhIHByb2JsZW0/Cj4gCj4gU29ycnksIEkgbWlzc2VkIGFkZGVkIG5vdGUgZm9yIG5vbiAt RVBST0JFX0RFRkVSIGNhc2VzLgoKTm8gcHJvYmxlbS4KCj4gUmV2aWV3ZWQtYnk6IEplcm5laiBT a3JhYmVjIDxqZXJuZWouc2tyYWJlY0BnbWFpbC5jb20+CgpUaGFuayB5b3UgZm9yIHRoZSByZXZp ZXchCgotLSAKV2l0aCBCZXN0IFJlZ2FyZHMsCkFuZHkgU2hldmNoZW5rbwoKCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1h aWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==