From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 06/10] drm/i915: pass dev_priv explicitly to TRANS_VRR_VTOTAL_PREV
Date: Thu, 9 May 2024 21:50:40 -0400 [thread overview]
Message-ID: <Zj19cOhGEfglmhPY@intel.com> (raw)
In-Reply-To: <de2c305ffef3df1112234baeae944b8dc84d0707.1715183162.git.jani.nikula@intel.com>
On Wed, May 08, 2024 at 06:47:52PM +0300, Jani Nikula wrote:
> Avoid the implicit dev_priv local variable use, and pass dev_priv
> explicitly to the TRANS_VRR_VTOTAL_PREV register macro.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/i915_reg.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index df43b9eb5374..745ef9a32d88 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -1291,7 +1291,7 @@
> #define _TRANS_VRR_VTOTAL_PREV_B 0x61480
> #define _TRANS_VRR_VTOTAL_PREV_C 0x62480
> #define _TRANS_VRR_VTOTAL_PREV_D 0x63480
> -#define TRANS_VRR_VTOTAL_PREV(trans) _MMIO_TRANS2(dev_priv, trans, \
> +#define TRANS_VRR_VTOTAL_PREV(dev_priv, trans) _MMIO_TRANS2(dev_priv, trans, \
> _TRANS_VRR_VTOTAL_PREV_A)
ditto,
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> #define VRR_VTOTAL_FLIP_BEFR_BNDR REG_BIT(31)
> #define VRR_VTOTAL_FLIP_AFTER_BNDR REG_BIT(30)
> --
> 2.39.2
>
next prev parent reply other threads:[~2024-05-10 1:50 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 15:47 [PATCH 00/10] drm/i915/display: remove implicit dev_priv from VRR Jani Nikula
2024-05-08 15:47 ` [PATCH 01/10] drm/i915: pass dev_priv explicitly to TRANS_VRR_CTL Jani Nikula
2024-05-10 1:47 ` Rodrigo Vivi
2024-05-08 15:47 ` [PATCH 02/10] drm/i915: pass dev_priv explicitly to TRANS_VRR_VMAX Jani Nikula
2024-05-10 1:48 ` Rodrigo Vivi
2024-05-08 15:47 ` [PATCH 03/10] drm/i915: pass dev_priv explicitly to TRANS_VRR_VMIN Jani Nikula
2024-05-10 1:48 ` Rodrigo Vivi
2024-05-08 15:47 ` [PATCH 04/10] drm/i915: pass dev_priv explicitly to TRANS_VRR_VMAXSHIFT Jani Nikula
2024-05-10 1:49 ` Rodrigo Vivi
2024-05-10 8:48 ` Jani Nikula
2024-05-08 15:47 ` [PATCH 05/10] drm/i915: pass dev_priv explicitly to TRANS_VRR_STATUS Jani Nikula
2024-05-10 1:50 ` Rodrigo Vivi
2024-05-08 15:47 ` [PATCH 06/10] drm/i915: pass dev_priv explicitly to TRANS_VRR_VTOTAL_PREV Jani Nikula
2024-05-10 1:50 ` Rodrigo Vivi [this message]
2024-05-08 15:47 ` [PATCH 07/10] drm/i915: pass dev_priv explicitly to TRANS_VRR_FLIPLINE Jani Nikula
2024-05-10 1:51 ` Rodrigo Vivi
2024-05-08 15:47 ` [PATCH 08/10] drm/i915: pass dev_priv explicitly to TRANS_VRR_STATUS2 Jani Nikula
2024-05-10 1:51 ` Rodrigo Vivi
2024-05-08 15:47 ` [PATCH 09/10] drm/i915: pass dev_priv explicitly to TRANS_PUSH Jani Nikula
2024-05-10 1:52 ` Rodrigo Vivi
2024-05-08 15:47 ` [PATCH 10/10] drm/i915: pass dev_priv explicitly to TRANS_VRR_VSYNC Jani Nikula
2024-05-10 1:52 ` Rodrigo Vivi
2024-05-08 16:40 ` ✓ Fi.CI.BAT: success for drm/i915/display: remove implicit dev_priv from VRR Patchwork
2024-05-08 16:41 ` ✗ Fi.CI.CHECKPATCH: warning " Patchwork
2024-05-09 7:53 ` ✓ Fi.CI.IGT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zj19cOhGEfglmhPY@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.