From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6AA8C25B10 for ; Fri, 10 May 2024 03:37:16 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1s5H4O-0006v4-3t; Fri, 10 May 2024 03:37:16 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1s5H4J-0006ut-OA for linux-f2fs-devel@lists.sourceforge.net; Fri, 10 May 2024 03:37:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=kGe4qIaRc1Ut7ElN23G404cZtQ0Mzx+LDFsgIok31nA=; b=I+AshtgAL/pVuoN/ff5Al00+0I CdCbwl21JSEU60UJaDhy5Dumj9Vcw4rasZ2ufN22/Qpb2Wd4wlevn5OSuWsQvMh4Z1Q89yzs70v+Q xi7G+271c3a4U0OT2HE5V2fUt1BkwAZV6tcFetZWci7VRpXIWE2dt4oSRbZGLCuRQERs=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=kGe4qIaRc1Ut7ElN23G404cZtQ0Mzx+LDFsgIok31nA=; b=mnKIhHwRYZOFnxj40CTnctb5S8 My0TZGqE8MPCx7ZmVmKlfnUUByLOB8ssjQanaVAZtT7Bvei2PXzJNQUgDp7580H9DKWmbo833gnG5 ToV7IFvrYadwtPCSgHu72FtHri7VYn1aX9LEqwSYkA1fhHCga48sz5twz7NrvzNdkkCo=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1s5H4K-0004rh-1d for linux-f2fs-devel@lists.sourceforge.net; Fri, 10 May 2024 03:37:12 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id DE92B61DE8; Fri, 10 May 2024 03:37:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84BBFC2BBFC; Fri, 10 May 2024 03:37:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715312220; bh=bmveony39CMa25FCZXSkYDZL0nL3DNLv+Xv3RlFohoE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OI7yOx0TT1hkxx9leCibqOQiWLpaOk+wR/xGfuRJ9qxMXewLUK4fSLQUoL63y1bjL R+wsTCybkLT4fqoamN018cstiHsVtYuVrF4aYavF9xM2WvO+2GFg5X//ZjHH50wDHf d0UK8F6JmsdvR8k6pJXruX7thFDtYWBa5Q/PI47XGCx7Lhr91xYMgjhcD3LWzSz3ms 8GkF1GxtDhxX9jsFhRgLufOPtJy6CILLAopcCWDzOq0l4F9i4/x1tKFQ7SlKTnhMqH oYLTSgpFq9C+Y1JaebwDEhO3U8+ppfBn/NLyYGgdE2JIhJ+OVs1Hdjcd/AkurK5LNc nb4K63bO/2XAg== Date: Fri, 10 May 2024 03:36:58 +0000 From: Jaegeuk Kim To: Chao Yu Message-ID: References: <20240506103313.773503-1-chao@kernel.org> <20240506103313.773503-3-chao@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1s5H4K-0004rh-1d Subject: Re: [f2fs-dev] [PATCH 3/3] f2fs: fix to do sanity check on i_nid for inline_data inode X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, syzbot+848062ba19c8782ca5c8@syzkaller.appspotmail.com, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 05/10, Chao Yu wrote: > On 2024/5/9 23:52, Jaegeuk Kim wrote: > > On 05/06, Chao Yu wrote: > > > syzbot reports a f2fs bug as below: > > > > > > ------------[ cut here ]------------ > > > kernel BUG at fs/f2fs/inline.c:258! > > > CPU: 1 PID: 34 Comm: kworker/u8:2 Not tainted 6.9.0-rc6-syzkaller-00012-g9e4bc4bcae01 #0 > > > RIP: 0010:f2fs_write_inline_data+0x781/0x790 fs/f2fs/inline.c:258 > > > Call Trace: > > > f2fs_write_single_data_page+0xb65/0x1d60 fs/f2fs/data.c:2834 > > > f2fs_write_cache_pages fs/f2fs/data.c:3133 [inline] > > > __f2fs_write_data_pages fs/f2fs/data.c:3288 [inline] > > > f2fs_write_data_pages+0x1efe/0x3a90 fs/f2fs/data.c:3315 > > > do_writepages+0x35b/0x870 mm/page-writeback.c:2612 > > > __writeback_single_inode+0x165/0x10b0 fs/fs-writeback.c:1650 > > > writeback_sb_inodes+0x905/0x1260 fs/fs-writeback.c:1941 > > > wb_writeback+0x457/0xce0 fs/fs-writeback.c:2117 > > > wb_do_writeback fs/fs-writeback.c:2264 [inline] > > > wb_workfn+0x410/0x1090 fs/fs-writeback.c:2304 > > > process_one_work kernel/workqueue.c:3254 [inline] > > > process_scheduled_works+0xa12/0x17c0 kernel/workqueue.c:3335 > > > worker_thread+0x86d/0xd70 kernel/workqueue.c:3416 > > > kthread+0x2f2/0x390 kernel/kthread.c:388 > > > ret_from_fork+0x4d/0x80 arch/x86/kernel/process.c:147 > > > ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244 > > > > > > The root cause is: inline_data inode can be fuzzed, so that there may > > > be valid blkaddr in its direct node, once f2fs triggers background GC > > > to migrate the block, it will hit f2fs_bug_on() during dirty page > > > writeback. > > > > > > Let's add sanity check on i_nid field for inline_data inode, meanwhile, > > > forbid to migrate inline_data inode's data block to fix this issue. > > > > > > Reported-by: syzbot+848062ba19c8782ca5c8@syzkaller.appspotmail.com > > > Closes: https://lore.kernel.org/linux-f2fs-devel/000000000000d103ce06174d7ec3@google.com > > > Signed-off-by: Chao Yu > > > --- > > > fs/f2fs/f2fs.h | 2 +- > > > fs/f2fs/gc.c | 6 ++++++ > > > fs/f2fs/inline.c | 17 ++++++++++++++++- > > > fs/f2fs/inode.c | 2 +- > > > 4 files changed, 24 insertions(+), 3 deletions(-) > > > > > > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h > > > index fced2b7652f4..c876813b5532 100644 > > > --- a/fs/f2fs/f2fs.h > > > +++ b/fs/f2fs/f2fs.h > > > @@ -4146,7 +4146,7 @@ extern struct kmem_cache *f2fs_inode_entry_slab; > > > * inline.c > > > */ > > > bool f2fs_may_inline_data(struct inode *inode); > > > -bool f2fs_sanity_check_inline_data(struct inode *inode); > > > +bool f2fs_sanity_check_inline_data(struct inode *inode, struct page *ipage); > > > bool f2fs_may_inline_dentry(struct inode *inode); > > > void f2fs_do_read_inline_data(struct page *page, struct page *ipage); > > > void f2fs_truncate_inline_inode(struct inode *inode, > > > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c > > > index e86c7f01539a..041957750478 100644 > > > --- a/fs/f2fs/gc.c > > > +++ b/fs/f2fs/gc.c > > > @@ -1563,6 +1563,12 @@ static int gc_data_segment(struct f2fs_sb_info *sbi, struct f2fs_summary *sum, > > > continue; > > > } > > > + if (f2fs_has_inline_data(inode)) { > > > + iput(inode); > > > + set_sbi_flag(sbi, SBI_NEED_FSCK); > > > + continue; > > > > Any race condtion to get this as false alarm? > > Since there is no reproducer for the bug, I doubt it was caused by metadata > fuzzing, something like this: > > - inline inode has one valid blkaddr in i_addr or in dnode reference by i_nid; > - SIT/SSA entry of the block is valid; > - background GC migrates the block; > - kworker writeback it, and trigger the bug_on(). Wasn't detected by sanity_check_inode? > > Thoughts? > > Thanks, > > > > > > + } > > > + > > > err = f2fs_gc_pinned_control(inode, gc_type, segno); > > > if (err == -EAGAIN) { > > > iput(inode); > > > diff --git a/fs/f2fs/inline.c b/fs/f2fs/inline.c > > > index ac00423f117b..067600fed3d4 100644 > > > --- a/fs/f2fs/inline.c > > > +++ b/fs/f2fs/inline.c > > > @@ -33,11 +33,26 @@ bool f2fs_may_inline_data(struct inode *inode) > > > return !f2fs_post_read_required(inode); > > > } > > > -bool f2fs_sanity_check_inline_data(struct inode *inode) > > > +static bool has_node_blocks(struct inode *inode, struct page *ipage) > > > +{ > > > + struct f2fs_inode *ri = F2FS_INODE(ipage); > > > + int i; > > > + > > > + for (i = 0; i < DEF_NIDS_PER_INODE; i++) { > > > + if (ri->i_nid[i]) > > > + return true; > > > + } > > > + return false; > > > +} > > > + > > > +bool f2fs_sanity_check_inline_data(struct inode *inode, struct page *ipage) > > > { > > > if (!f2fs_has_inline_data(inode)) > > > return false; > > > + if (has_node_blocks(inode, ipage)) > > > + return false; > > > + > > > if (!support_inline_data(inode)) > > > return true; > > > diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c > > > index c26effdce9aa..1423cd27a477 100644 > > > --- a/fs/f2fs/inode.c > > > +++ b/fs/f2fs/inode.c > > > @@ -343,7 +343,7 @@ static bool sanity_check_inode(struct inode *inode, struct page *node_page) > > > } > > > } > > > - if (f2fs_sanity_check_inline_data(inode)) { > > > + if (f2fs_sanity_check_inline_data(inode, node_page)) { > > > f2fs_warn(sbi, "%s: inode (ino=%lx, mode=%u) should not have inline_data, run fsck to fix", > > > __func__, inode->i_ino, inode->i_mode); > > > return false; > > > -- > > > 2.40.1 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3FC4524C4 for ; Fri, 10 May 2024 03:37:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715312220; cv=none; b=a6hOLW98+MPJswm3BqqrKnhXIfNA/xtuRHmx/iowxmsO1c1vvdyhXnv0lGIwIH5y2w6ivkFBL2hcHXR+A8Ol2dSEEDHI+rK9IkcIVFM0byUni/phkyPmvoTJd8Ke4EBNgGRhehmzCMcuFRM71xCgvH6oHkrVjC4cbjY1aMf6swY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715312220; c=relaxed/simple; bh=bmveony39CMa25FCZXSkYDZL0nL3DNLv+Xv3RlFohoE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Le+Ig2TXsPtYfanH22NRmaCwNIf+nGj6J6YKtgkbMvYcW61e0OgG3ish+UC4dduh4nJi0FoYXqXzfaFe+WZoB8rf7gwSTotnzIl6dSad7HOcwEI836pq03bUZH3FBnYvG5EhOBv1gTLYZTWAC2Nh1p0un9yLZaedsIulLXHupwo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OI7yOx0T; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OI7yOx0T" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84BBFC2BBFC; Fri, 10 May 2024 03:37:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715312220; bh=bmveony39CMa25FCZXSkYDZL0nL3DNLv+Xv3RlFohoE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OI7yOx0TT1hkxx9leCibqOQiWLpaOk+wR/xGfuRJ9qxMXewLUK4fSLQUoL63y1bjL R+wsTCybkLT4fqoamN018cstiHsVtYuVrF4aYavF9xM2WvO+2GFg5X//ZjHH50wDHf d0UK8F6JmsdvR8k6pJXruX7thFDtYWBa5Q/PI47XGCx7Lhr91xYMgjhcD3LWzSz3ms 8GkF1GxtDhxX9jsFhRgLufOPtJy6CILLAopcCWDzOq0l4F9i4/x1tKFQ7SlKTnhMqH oYLTSgpFq9C+Y1JaebwDEhO3U8+ppfBn/NLyYGgdE2JIhJ+OVs1Hdjcd/AkurK5LNc nb4K63bO/2XAg== Date: Fri, 10 May 2024 03:36:58 +0000 From: Jaegeuk Kim To: Chao Yu Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, syzbot+848062ba19c8782ca5c8@syzkaller.appspotmail.com Subject: Re: [PATCH 3/3] f2fs: fix to do sanity check on i_nid for inline_data inode Message-ID: References: <20240506103313.773503-1-chao@kernel.org> <20240506103313.773503-3-chao@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 05/10, Chao Yu wrote: > On 2024/5/9 23:52, Jaegeuk Kim wrote: > > On 05/06, Chao Yu wrote: > > > syzbot reports a f2fs bug as below: > > > > > > ------------[ cut here ]------------ > > > kernel BUG at fs/f2fs/inline.c:258! > > > CPU: 1 PID: 34 Comm: kworker/u8:2 Not tainted 6.9.0-rc6-syzkaller-00012-g9e4bc4bcae01 #0 > > > RIP: 0010:f2fs_write_inline_data+0x781/0x790 fs/f2fs/inline.c:258 > > > Call Trace: > > > f2fs_write_single_data_page+0xb65/0x1d60 fs/f2fs/data.c:2834 > > > f2fs_write_cache_pages fs/f2fs/data.c:3133 [inline] > > > __f2fs_write_data_pages fs/f2fs/data.c:3288 [inline] > > > f2fs_write_data_pages+0x1efe/0x3a90 fs/f2fs/data.c:3315 > > > do_writepages+0x35b/0x870 mm/page-writeback.c:2612 > > > __writeback_single_inode+0x165/0x10b0 fs/fs-writeback.c:1650 > > > writeback_sb_inodes+0x905/0x1260 fs/fs-writeback.c:1941 > > > wb_writeback+0x457/0xce0 fs/fs-writeback.c:2117 > > > wb_do_writeback fs/fs-writeback.c:2264 [inline] > > > wb_workfn+0x410/0x1090 fs/fs-writeback.c:2304 > > > process_one_work kernel/workqueue.c:3254 [inline] > > > process_scheduled_works+0xa12/0x17c0 kernel/workqueue.c:3335 > > > worker_thread+0x86d/0xd70 kernel/workqueue.c:3416 > > > kthread+0x2f2/0x390 kernel/kthread.c:388 > > > ret_from_fork+0x4d/0x80 arch/x86/kernel/process.c:147 > > > ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244 > > > > > > The root cause is: inline_data inode can be fuzzed, so that there may > > > be valid blkaddr in its direct node, once f2fs triggers background GC > > > to migrate the block, it will hit f2fs_bug_on() during dirty page > > > writeback. > > > > > > Let's add sanity check on i_nid field for inline_data inode, meanwhile, > > > forbid to migrate inline_data inode's data block to fix this issue. > > > > > > Reported-by: syzbot+848062ba19c8782ca5c8@syzkaller.appspotmail.com > > > Closes: https://lore.kernel.org/linux-f2fs-devel/000000000000d103ce06174d7ec3@google.com > > > Signed-off-by: Chao Yu > > > --- > > > fs/f2fs/f2fs.h | 2 +- > > > fs/f2fs/gc.c | 6 ++++++ > > > fs/f2fs/inline.c | 17 ++++++++++++++++- > > > fs/f2fs/inode.c | 2 +- > > > 4 files changed, 24 insertions(+), 3 deletions(-) > > > > > > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h > > > index fced2b7652f4..c876813b5532 100644 > > > --- a/fs/f2fs/f2fs.h > > > +++ b/fs/f2fs/f2fs.h > > > @@ -4146,7 +4146,7 @@ extern struct kmem_cache *f2fs_inode_entry_slab; > > > * inline.c > > > */ > > > bool f2fs_may_inline_data(struct inode *inode); > > > -bool f2fs_sanity_check_inline_data(struct inode *inode); > > > +bool f2fs_sanity_check_inline_data(struct inode *inode, struct page *ipage); > > > bool f2fs_may_inline_dentry(struct inode *inode); > > > void f2fs_do_read_inline_data(struct page *page, struct page *ipage); > > > void f2fs_truncate_inline_inode(struct inode *inode, > > > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c > > > index e86c7f01539a..041957750478 100644 > > > --- a/fs/f2fs/gc.c > > > +++ b/fs/f2fs/gc.c > > > @@ -1563,6 +1563,12 @@ static int gc_data_segment(struct f2fs_sb_info *sbi, struct f2fs_summary *sum, > > > continue; > > > } > > > + if (f2fs_has_inline_data(inode)) { > > > + iput(inode); > > > + set_sbi_flag(sbi, SBI_NEED_FSCK); > > > + continue; > > > > Any race condtion to get this as false alarm? > > Since there is no reproducer for the bug, I doubt it was caused by metadata > fuzzing, something like this: > > - inline inode has one valid blkaddr in i_addr or in dnode reference by i_nid; > - SIT/SSA entry of the block is valid; > - background GC migrates the block; > - kworker writeback it, and trigger the bug_on(). Wasn't detected by sanity_check_inode? > > Thoughts? > > Thanks, > > > > > > + } > > > + > > > err = f2fs_gc_pinned_control(inode, gc_type, segno); > > > if (err == -EAGAIN) { > > > iput(inode); > > > diff --git a/fs/f2fs/inline.c b/fs/f2fs/inline.c > > > index ac00423f117b..067600fed3d4 100644 > > > --- a/fs/f2fs/inline.c > > > +++ b/fs/f2fs/inline.c > > > @@ -33,11 +33,26 @@ bool f2fs_may_inline_data(struct inode *inode) > > > return !f2fs_post_read_required(inode); > > > } > > > -bool f2fs_sanity_check_inline_data(struct inode *inode) > > > +static bool has_node_blocks(struct inode *inode, struct page *ipage) > > > +{ > > > + struct f2fs_inode *ri = F2FS_INODE(ipage); > > > + int i; > > > + > > > + for (i = 0; i < DEF_NIDS_PER_INODE; i++) { > > > + if (ri->i_nid[i]) > > > + return true; > > > + } > > > + return false; > > > +} > > > + > > > +bool f2fs_sanity_check_inline_data(struct inode *inode, struct page *ipage) > > > { > > > if (!f2fs_has_inline_data(inode)) > > > return false; > > > + if (has_node_blocks(inode, ipage)) > > > + return false; > > > + > > > if (!support_inline_data(inode)) > > > return true; > > > diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c > > > index c26effdce9aa..1423cd27a477 100644 > > > --- a/fs/f2fs/inode.c > > > +++ b/fs/f2fs/inode.c > > > @@ -343,7 +343,7 @@ static bool sanity_check_inode(struct inode *inode, struct page *node_page) > > > } > > > } > > > - if (f2fs_sanity_check_inline_data(inode)) { > > > + if (f2fs_sanity_check_inline_data(inode, node_page)) { > > > f2fs_warn(sbi, "%s: inode (ino=%lx, mode=%u) should not have inline_data, run fsck to fix", > > > __func__, inode->i_ino, inode->i_mode); > > > return false; > > > -- > > > 2.40.1