From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Devarsh Thakkar <devarsht@ti.com>
Cc: mchehab@kernel.org, hverkuil-cisco@xs4all.nl,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
benjamin.gaignard@collabora.com, sebastian.fricke@collabora.com,
dri-devel@lists.freedesktop.org,
laurent.pinchart@ideasonboard.com, praneeth@ti.com, nm@ti.com,
vigneshr@ti.com, a-bhatia1@ti.com, j-luthra@ti.com,
b-brnich@ti.com, detheridge@ti.com, p-mantena@ti.com,
vijayp@ti.com, andrzej.p@collabora.com, nicolas@ndufresne.ca,
p.zabel@pengutronix.de, airlied@gmail.com, daniel@ffwll.ch,
akpm@linux-foundation.org, gregkh@linuxfoundation.org,
adobriyan@gmail.com, jani.nikula@intel.com
Subject: Re: [PATCH v7 7/8] media: imagination: Round to closest multiple for cropping region
Date: Fri, 10 May 2024 18:10:37 +0300 [thread overview]
Message-ID: <Zj447ePSnccbj76v@smile.fi.intel.com> (raw)
In-Reply-To: <20240509184001.4064820-1-devarsht@ti.com>
On Fri, May 10, 2024 at 12:10:01AM +0530, Devarsh Thakkar wrote:
> If neither of the flags to round down (V4L2_SEL_FLAG_LE) or round up
> (V4L2_SEL_FLAG_GE) are specified by the user, then round to nearest
> multiple of requested value while updating the crop rectangle coordinates.
>
> Use the rounding macro which gives preference to rounding down in case two
> nearest values (high and low) are possible to raise the probability of
> cropping rectangle falling inside the bound region.
This is arguable. How do we know that the bigger range is supported?
The safest side is to go smaller than bigger.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-05-10 15:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 18:40 [PATCH v7 7/8] media: imagination: Round to closest multiple for cropping region Devarsh Thakkar
2024-05-10 15:10 ` Andy Shevchenko [this message]
2024-05-11 17:08 ` Devarsh Thakkar
2024-05-14 20:22 ` Nicolas Dufresne
2024-05-15 5:06 ` Devarsh Thakkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zj447ePSnccbj76v@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=a-bhatia1@ti.com \
--cc=adobriyan@gmail.com \
--cc=airlied@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andrzej.p@collabora.com \
--cc=b-brnich@ti.com \
--cc=benjamin.gaignard@collabora.com \
--cc=daniel@ffwll.ch \
--cc=detheridge@ti.com \
--cc=devarsht@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=j-luthra@ti.com \
--cc=jani.nikula@intel.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nicolas@ndufresne.ca \
--cc=nm@ti.com \
--cc=p-mantena@ti.com \
--cc=p.zabel@pengutronix.de \
--cc=praneeth@ti.com \
--cc=sebastian.fricke@collabora.com \
--cc=vigneshr@ti.com \
--cc=vijayp@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.