From: Zhao Liu <zhao1.liu@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] target/i386: remove PCOMMIT from TCG, deprecate property
Date: Fri, 10 May 2024 20:53:39 +0800 [thread overview]
Message-ID: <Zj4Y08cAVkLZvDE0@intel.com> (raw)
In-Reply-To: <20240508154421.61419-1-pbonzini@redhat.com>
On Wed, May 08, 2024 at 05:44:21PM +0200, Paolo Bonzini wrote:
> Date: Wed, 8 May 2024 17:44:21 +0200
> From: Paolo Bonzini <pbonzini@redhat.com>
> Subject: [PATCH] target/i386: remove PCOMMIT from TCG, deprecate property
> X-Mailer: git-send-email 2.45.0
>
> The PCOMMIT instruction was never included in any physical processor.
> TCG implements it as a no-op instruction, but its utility is debatable
> to say the least. Drop it from the decoder since it is only available
> with "-cpu max", which does not guarantee migration compatibility
> across versions, and deprecate the property just in case someone is
> using it as "pcommit=off".
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> docs/about/deprecated.rst | 8 ++++++++
> target/i386/cpu.h | 2 --
> target/i386/cpu.c | 2 +-
> target/i386/tcg/translate.c | 12 +-----------
> 4 files changed, 10 insertions(+), 14 deletions(-)
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
prev parent reply other threads:[~2024-05-10 12:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 15:44 [PATCH] target/i386: remove PCOMMIT from TCG, deprecate property Paolo Bonzini
2024-05-09 13:40 ` Richard Henderson
2024-05-10 12:53 ` Zhao Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zj4Y08cAVkLZvDE0@intel.com \
--to=zhao1.liu@intel.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.