From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B95C017109C; Fri, 10 May 2024 15:52:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715356356; cv=none; b=L58/itCy454pAg8Fjc2cWzQkhAgiWxyZ8YNV4/1aVjF6QZd2ZKPHvclGhtkKgSqWxnkN50Y2Tfs5dqCpm7baKsQ5dYHQ0qyZQvJiBnQWswJrhTkBPdayoQcRekDZ0++Nl58CoJk3rnINnZFzSWv+s4Icr4IhIw87oVyU+548iHk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715356356; c=relaxed/simple; bh=KbDSJ8sPoqUrtBTRtD44bCSBAhAd8j8GTBlXUJayVTo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SVElIey4VASUxiRGNxSAJPUR6Fj3MSfLFpCmZT1MrJfh0hVT5caitDmvJi2fWOoqN+fo760DkwIn+zo35Aw1PTfTX9NEI7IbZXRHVReo5nSSCCA0KyiXhatwibiNN1Dv5E2eyL4aTMKmFeYpUy/2HjB9hfovdfYwApBRxjVMEbA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=cPmonIHv; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="cPmonIHv" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=kgU5xDXwFs4QEjcHU4kuuCpha5X8eRsJv6GJUqZKdTQ=; b=cPmonIHvlTOPUe5pIJgg2HJ/qz eAOZt0HRWk9ANyinjkSfgJ96aPpC8iEoLUnqkZLpC1H3whU5XEbtPFsBxCJpkJ1HbW21YeWHlUGFr eUgFQE2DmtPSFNv2giA0Cx9DVQ4U1RCKFQfOqGr7CNMMs5mxILIOW1NbwizV1Lx0nr7/JRNthmKHV TMTAKiNii1V+8WvX+LyK3lfodxtZC1OgeSh7QfMWGwqWzVzbi/k4sY402xw1XF5g+gNvej+0gcTpE SvcRfQMjHRgEZMb1/TfH7yMYXzM2ZdMVj0ARRaE+artlqr1bUkUq5g7BCmBuaK5wja37qrWhmKEUQ 6c87ObCA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:42940) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1s5SXW-0007aJ-2n; Fri, 10 May 2024 16:52:07 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1s5SXT-0003Qx-Bi; Fri, 10 May 2024 16:52:03 +0100 Date: Fri, 10 May 2024 16:52:03 +0100 From: "Russell King (Oracle)" To: Romain Gantois Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Alexandre Torgue , Jose Abreu , Maxime Coquelin , =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= , Serge Semin , Thomas Petazzoni , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next v6 2/7] net: stmmac: Add dedicated XPCS cleanup method Message-ID: References: <20240510-rzn1-gmac1-v6-0-b63942be334c@bootlin.com> <20240510-rzn1-gmac1-v6-2-b63942be334c@bootlin.com> Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240510-rzn1-gmac1-v6-2-b63942be334c@bootlin.com> Sender: Russell King (Oracle) On Fri, May 10, 2024 at 09:38:09AM +0200, Romain Gantois wrote: > From: Serge Semin > > Currently the XPCS handler destruction is performed in the > stmmac_mdio_unregister() method. It doesn't look good because the handler > isn't originally created in the corresponding protagonist > stmmac_mdio_unregister(), but in the stmmac_xpcs_setup() function. In > order to have more coherent MDIO and XPCS setup/cleanup procedures, > let's move the DW XPCS destruction to the dedicated stmmac_pcs_clean() > method. > > This method will also be used to cleanup PCS hardware using the > pcs_exit() callback that will be introduced to stmmac in a subsequent > patch. > > Signed-off-by: Serge Semin > Co-developed-by: Romain Gantois Reviewed-by: Russell King (Oracle) Thanks! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 978FEC25B5F for ; Fri, 10 May 2024 15:52:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=h8o5FPHYtNaNGX8Z+h92yuWPmqfiGMNWB1k77jt18cY=; b=1MtOcHblPzyVVB j/sd7sXsVhXU8a86DrJJXtRjlJrtDazbLp/IiZT+sdaOarJXHNrZZP7DJplMPwUnfKfEl+BHVDT6v IP768L8s3owHdraXxWvSeK0o3DOT3rpwLZt9IzvAImjPxnzNRpaKo71tyfJq+nBhISBHRwg/hOk6K V4WA1Pk2aw1j8Ck75U1LWIX2lHX0PaA5ljGM/Q4fTUdLvAxtCGF9Q6EUsclLYLnoWliTgI42vPj9J kqb6DfmdRvmgVFpV3A9yQdDzpspf/6mbutxcRH9WNrk8L5HpiG7mHFahxXINsiJJkIyl4q5fguWQ8 FscBxozbeTV66ouEHXZw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s5SY7-00000005m8v-42Ei; Fri, 10 May 2024 15:52:43 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s5SY4-00000005m5J-0vsO for linux-arm-kernel@lists.infradead.org; Fri, 10 May 2024 15:52:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=kgU5xDXwFs4QEjcHU4kuuCpha5X8eRsJv6GJUqZKdTQ=; b=cPmonIHvlTOPUe5pIJgg2HJ/qz eAOZt0HRWk9ANyinjkSfgJ96aPpC8iEoLUnqkZLpC1H3whU5XEbtPFsBxCJpkJ1HbW21YeWHlUGFr eUgFQE2DmtPSFNv2giA0Cx9DVQ4U1RCKFQfOqGr7CNMMs5mxILIOW1NbwizV1Lx0nr7/JRNthmKHV TMTAKiNii1V+8WvX+LyK3lfodxtZC1OgeSh7QfMWGwqWzVzbi/k4sY402xw1XF5g+gNvej+0gcTpE SvcRfQMjHRgEZMb1/TfH7yMYXzM2ZdMVj0ARRaE+artlqr1bUkUq5g7BCmBuaK5wja37qrWhmKEUQ 6c87ObCA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:42940) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1s5SXW-0007aJ-2n; Fri, 10 May 2024 16:52:07 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1s5SXT-0003Qx-Bi; Fri, 10 May 2024 16:52:03 +0100 Date: Fri, 10 May 2024 16:52:03 +0100 From: "Russell King (Oracle)" To: Romain Gantois Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Alexandre Torgue , Jose Abreu , Maxime Coquelin , =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= , Serge Semin , Thomas Petazzoni , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next v6 2/7] net: stmmac: Add dedicated XPCS cleanup method Message-ID: References: <20240510-rzn1-gmac1-v6-0-b63942be334c@bootlin.com> <20240510-rzn1-gmac1-v6-2-b63942be334c@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240510-rzn1-gmac1-v6-2-b63942be334c@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240510_085240_575378_6065CB71 X-CRM114-Status: GOOD ( 13.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 10, 2024 at 09:38:09AM +0200, Romain Gantois wrote: > From: Serge Semin > > Currently the XPCS handler destruction is performed in the > stmmac_mdio_unregister() method. It doesn't look good because the handler > isn't originally created in the corresponding protagonist > stmmac_mdio_unregister(), but in the stmmac_xpcs_setup() function. In > order to have more coherent MDIO and XPCS setup/cleanup procedures, > let's move the DW XPCS destruction to the dedicated stmmac_pcs_clean() > method. > > This method will also be used to cleanup PCS hardware using the > pcs_exit() callback that will be introduced to stmmac in a subsequent > patch. > > Signed-off-by: Serge Semin > Co-developed-by: Romain Gantois Reviewed-by: Russell King (Oracle) Thanks! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel