All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] gpiolib: Return label, if set, for IRQ only line
Date: Fri, 10 May 2024 19:06:10 +0300	[thread overview]
Message-ID: <Zj5F8tidsVPkDGEi@smile.fi.intel.com> (raw)
In-Reply-To: <Zj5B5ONDI7DB86on@smile.fi.intel.com>

On Fri, May 10, 2024 at 06:48:52PM +0300, Andy Shevchenko wrote:
> On Fri, May 10, 2024 at 06:42:28PM +0300, Andy Shevchenko wrote:
> > On Thu, May 09, 2024 at 04:23:07PM +0200, Bartosz Golaszewski wrote:
> > > On Thu, May 9, 2024 at 3:58 PM Andy Shevchenko
> > > <andy.shevchenko@gmail.com> wrote:

...

> > > Fair enough but I would like to know what your bigger plan is before
> > > picking this up.
> > 
> > I stand corrected, this patch has an immediate effect on the generic
> > gpiolib_dbg_show() which does *not* use the above mentioned call..
> 
> Ah, but it doesn't use gpiod_get_label() in the else branch either...
> 
> I want to amend the else branch there to print similar or reuse the main one.
> For the latter I have locally a patch to modify gpiolib_dbg_show() to show
> the interrupt lines as well even if they are not requested.

I just shared that patch, if you are okay with both, it would be nice
to have them applied.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2024-05-10 16:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-08 14:47 [PATCH v1 1/1] gpiolib: Return label, if set, for IRQ only line Andy Shevchenko
2024-05-09 13:15 ` Bartosz Golaszewski
2024-05-09 13:58   ` Andy Shevchenko
2024-05-09 14:23     ` Bartosz Golaszewski
2024-05-10 15:42       ` Andy Shevchenko
2024-05-10 15:48         ` Andy Shevchenko
2024-05-10 16:06           ` Andy Shevchenko [this message]
2024-05-10 17:30             ` Bartosz Golaszewski
2024-05-10 17:47               ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zj5F8tidsVPkDGEi@smile.fi.intel.com \
    --to=andy.shevchenko@gmail.com \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=brgl@bgdev.pl \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.