Re: [Buildroot] [git commit] package/kodi: bump version to 21.0-Omega

[Waldemar Brodkorb <wbx@openadk.org>]

Hello Bernd,

I have another build issue when compiling for uClibc-ng:

/home/wbx/buildroot/output/host/lib/gcc/aarch64-buildroot-linux-uclibc/12.3.0/../../../../aarch64-buildroot-linux-uclibc/bin/ld:
build/utils/utils.a(CharsetConverter.cpp.o): undefined reference to symbol 'libiconv_open'
/home/wbx/buildroot/output/host/lib/gcc/aarch64-buildroot-linux-uclibc/12.3.0/../../../../aarch64-buildroot-linux-uclibc/bin/ld:
/home/wbx/buildroot/output/host/aarch64-buildroot-linux-uclibc/sysroot/usr/lib64/libiconv.so.2:
error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
make[3]: *** [CMakeFiles/kodi.dir/build.make:535: kodi.bin] Error 1

What is the best fix for adding -liconv to the target LDFLAGS?

> Hello Bernd,
> 
> On Thu, 9 May 2024 19:00:54 +0200
> Thomas Petazzoni via buildroot <buildroot@buildroot.org> wrote:
> 
> > Added new required dependency to libudfread: Since upstream commit
> > https://github.com/xbmc/xbmc/commit/5f9b9cfa26f274e381e92d73cfa33fb55582436e
> > kodi does not build anymore without libudfread.
> 
> There is a mistake in your patch on this, causing a build failure, see
> below.
> 
> >  	depends on !BR2_PACKAGE_KODI_PLATFORM_SUPPORTS
> > @@ -56,6 +58,7 @@ menuconfig BR2_PACKAGE_KODI
> >  	depends on BR2_INSTALL_LIBSTDCPP
> >  	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # libass -> harfbuzz
> >  	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_9 # C++17
> > +	depends on BR2_HOST_GCC_AT_LEAST_9 # C++17
> >  	depends on BR2_TOOLCHAIN_HAS_THREADS
> >  	depends on !BR2_TOOLCHAIN_USES_MUSL
> >  	depends on BR2_USE_WCHAR
> > @@ -103,6 +106,7 @@ menuconfig BR2_PACKAGE_KODI
> >  	select BR2_PACKAGE_SQLITE
> >  	select BR2_PACKAGE_TAGLIB
> >  	select BR2_PACKAGE_TINYXML
> > +	select BR2_PACKAGE_TINYXML2
> >  	select BR2_PACKAGE_ZLIB
> >  	select BR2_TOOLCHAIN_GLIBC_GCONV_LIBS_COPY if BR2_TOOLCHAIN_USES_GLIBC # runtime UTF conversion support
> >  	select BR2_PACKAGE_LIBINPUT if BR2_PACKAGE_KODI_PLATFORM_SUPPORTS_GBM
> > @@ -162,6 +166,7 @@ config BR2_PACKAGE_KODI_EVENTCLIENTS
> >  config BR2_PACKAGE_KODI_LIBBLURAY
> >  	bool "blu-ray"
> >  	select BR2_PACKAGE_LIBBLURAY
> > +	select BR2_PACKAGE_LIBUDFREAD
> 
> You're indeed adding the "select" on BR2_PACKAGE_LIBUDFREAD, but in a
> sub-option of kodi, BR2_PACKAGE_KODI_LIBBLURAY, while...
> 
> >  KODI_LICENSE = GPL-2.0
> > @@ -45,6 +45,7 @@ KODI_DEPENDENCIES = \
> >  	libfribidi \
> >  	libplist \
> >  	libpng \
> > +	libudfread \
> 
> here you're adding libudfread to the unconditional dependencies,
> unrelated to the sub-option.
> 
> Which one is correct? Having a sub-option, or marking libudfread a
> mandatory dependency whenever kodi is enabled?

Thanks
 Waldemar
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot