From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 90BD313D268 for ; Tue, 30 Apr 2024 10:22:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714472569; cv=none; b=uHxVIh74zdbwht5O8eDvw8adrPlw6/9EnzE0aEcpM63tNb3eucLWiejqb1O5nVNxAzvTza8JaYGAFKGn23aEu9UAlIqjLAnfkzr7QKadEB+kgwFtN4vKlf8qX4JFLq1YXi0607v6bPIh/7/0RCUBtUa9bBOQ5sdBxIMmn0BWkBE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714472569; c=relaxed/simple; bh=krf2c1GkUobPI6NrzHHAPV2pd3geJngPoEGsQX9XiYg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Cal1xZLlaE5Bu1S9T9BCJUt7uMjB6V9j2WpzxoW3OyStDqQkNXbUwe8il4VjrXFVJZcBRr+uloOflqzRAxyo0cf3Es4rs4INNvwvWdy7S69ljVUzdmWwAJYhQ77U/V96uguT2iTFVWkv1uQUQ70SQCasSVQhTFu21nYtUlZz77g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 74057339 for ; Tue, 30 Apr 2024 03:23:13 -0700 (PDT) Received: from e110455-lin.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id BF2203F73F for ; Tue, 30 Apr 2024 03:22:46 -0700 (PDT) Date: Tue, 30 Apr 2024 11:22:29 +0100 From: Liviu Dudau To: Jean-Philippe Brucker Cc: will@kernel.org, lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, bhelgaas@google.com, krzk+dt@kernel.org, conor+dt@kernel.org, sudeep.holla@arm.com, joro@8bytes.org, robin.murphy@arm.com, nicolinc@nvidia.com, ketanp@nvidia.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, devicetree@vger.kernel.org Subject: Re: [PATCH 1/3] dt-bindings: PCI: generic: Add ats-supported property Message-ID: References: <20240429113938.192706-2-jean-philippe@linaro.org> <20240429113938.192706-3-jean-philippe@linaro.org> Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240429113938.192706-3-jean-philippe@linaro.org> On Mon, Apr 29, 2024 at 12:39:37PM +0100, Jean-Philippe Brucker wrote: > Add a way for firmware to tell the OS that ATS is supported by the PCI > root complex. An endpoint with ATS enabled may send Translation Requests > and Translated Memory Requests, which look just like Normal Memory > Requests with a non-zero AT field. So a root controller that ignores the > AT field may simply forward the request to the IOMMU as a Normal Memory > Request, which could end badly. In any case, the endpoint will be > unusable. > > The ats-supported property allows the OS to only enable ATS in endpoints > if the root controller can handle ATS requests. Only add the property to > pcie-host-ecam-generic for the moment. For non-generic root controllers, > availability of ATS can be inferred from the compatible string. > > Signed-off-by: Jean-Philippe Brucker > Reviewed-by: Rob Herring Reviewed-by: Liviu Dudau > --- > From a while ago: https://lore.kernel.org/all/20200219222454.GA16221@bogus/ > --- > Documentation/devicetree/bindings/pci/host-generic-pci.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/host-generic-pci.yaml b/Documentation/devicetree/bindings/pci/host-generic-pci.yaml > index d25423aa71674..94d4a4914a483 100644 > --- a/Documentation/devicetree/bindings/pci/host-generic-pci.yaml > +++ b/Documentation/devicetree/bindings/pci/host-generic-pci.yaml > @@ -110,6 +110,12 @@ properties: > iommu-map-mask: true > msi-parent: true > > + ats-supported: > + description: > + Indicates that a PCIe host controller supports ATS, and can handle Memory > + Requests with Address Type (AT). > + type: boolean > + > required: > - compatible > - reg > -- > 2.44.0 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7F7B5C4345F for ; Tue, 30 Apr 2024 10:23:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GvbYJGfLZsHw5agWw4AEMYxy8KQivT2tYVCXKV0cEOY=; b=XwROQaHN6WXdii ltpzepc1G5w4/2O2VpFXHuU/Ng90ofjf/r9selw0CoPGpq8rEjGlpX4HLnkiUy/TPF57scX0xvAJd +vF3GwJwl2t3nA9CDWnpTsKhx6e+UFmHyCLxaE9kJb5y29n8shd9rI1lzCiclFGURO+9AAFjXM+gN JnRK/ol5S09Kjkwy76GOqKE+vQh6o0RI9t8N/MaqVAaPBkdZKDMKQyQfahID9VdZlIr0MJ9B4TZWk yxXHrVB0ektdjJ/facCcgpoehil5wMbafe2UypztFIuGuHjOu9/lSmnHF/u3ZIjO1nGa1pttxmgEr F9oXDAHRPj99z+H+OpUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1kda-00000006013-397p; Tue, 30 Apr 2024 10:23:02 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1kdM-00000005zsn-0UD0 for linux-arm-kernel@lists.infradead.org; Tue, 30 Apr 2024 10:22:50 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 72EF1113E for ; Tue, 30 Apr 2024 03:23:12 -0700 (PDT) Received: from e110455-lin.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id BE4DA3F73F for ; Tue, 30 Apr 2024 03:22:45 -0700 (PDT) Date: Tue, 30 Apr 2024 11:22:29 +0100 From: Liviu Dudau To: Jean-Philippe Brucker Cc: will@kernel.org, lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, bhelgaas@google.com, krzk+dt@kernel.org, conor+dt@kernel.org, sudeep.holla@arm.com, joro@8bytes.org, robin.murphy@arm.com, nicolinc@nvidia.com, ketanp@nvidia.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, devicetree@vger.kernel.org Subject: Re: [PATCH 1/3] dt-bindings: PCI: generic: Add ats-supported property Message-ID: References: <20240429113938.192706-2-jean-philippe@linaro.org> <20240429113938.192706-3-jean-philippe@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240429113938.192706-3-jean-philippe@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240430_032248_320085_85723F13 X-CRM114-Status: GOOD ( 20.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBBcHIgMjksIDIwMjQgYXQgMTI6Mzk6MzdQTSArMDEwMCwgSmVhbi1QaGlsaXBwZSBC cnVja2VyIHdyb3RlOgo+IEFkZCBhIHdheSBmb3IgZmlybXdhcmUgdG8gdGVsbCB0aGUgT1MgdGhh dCBBVFMgaXMgc3VwcG9ydGVkIGJ5IHRoZSBQQ0kKPiByb290IGNvbXBsZXguIEFuIGVuZHBvaW50 IHdpdGggQVRTIGVuYWJsZWQgbWF5IHNlbmQgVHJhbnNsYXRpb24gUmVxdWVzdHMKPiBhbmQgVHJh bnNsYXRlZCBNZW1vcnkgUmVxdWVzdHMsIHdoaWNoIGxvb2sganVzdCBsaWtlIE5vcm1hbCBNZW1v cnkKPiBSZXF1ZXN0cyB3aXRoIGEgbm9uLXplcm8gQVQgZmllbGQuIFNvIGEgcm9vdCBjb250cm9s bGVyIHRoYXQgaWdub3JlcyB0aGUKPiBBVCBmaWVsZCBtYXkgc2ltcGx5IGZvcndhcmQgdGhlIHJl cXVlc3QgdG8gdGhlIElPTU1VIGFzIGEgTm9ybWFsIE1lbW9yeQo+IFJlcXVlc3QsIHdoaWNoIGNv dWxkIGVuZCBiYWRseS4gSW4gYW55IGNhc2UsIHRoZSBlbmRwb2ludCB3aWxsIGJlCj4gdW51c2Fi bGUuCj4gCj4gVGhlIGF0cy1zdXBwb3J0ZWQgcHJvcGVydHkgYWxsb3dzIHRoZSBPUyB0byBvbmx5 IGVuYWJsZSBBVFMgaW4gZW5kcG9pbnRzCj4gaWYgdGhlIHJvb3QgY29udHJvbGxlciBjYW4gaGFu ZGxlIEFUUyByZXF1ZXN0cy4gT25seSBhZGQgdGhlIHByb3BlcnR5IHRvCj4gcGNpZS1ob3N0LWVj YW0tZ2VuZXJpYyBmb3IgdGhlIG1vbWVudC4gRm9yIG5vbi1nZW5lcmljIHJvb3QgY29udHJvbGxl cnMsCj4gYXZhaWxhYmlsaXR5IG9mIEFUUyBjYW4gYmUgaW5mZXJyZWQgZnJvbSB0aGUgY29tcGF0 aWJsZSBzdHJpbmcuCj4gCj4gU2lnbmVkLW9mZi1ieTogSmVhbi1QaGlsaXBwZSBCcnVja2VyIDxq ZWFuLXBoaWxpcHBlQGxpbmFyby5vcmc+Cj4gUmV2aWV3ZWQtYnk6IFJvYiBIZXJyaW5nIDxyb2Jo QGtlcm5lbC5vcmc+CgpSZXZpZXdlZC1ieTogTGl2aXUgRHVkYXUgPGxpdml1LmR1ZGF1QGFybS5j b20+Cgo+IC0tLQo+IEZyb20gYSB3aGlsZSBhZ286IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2Fs bC8yMDIwMDIxOTIyMjQ1NC5HQTE2MjIxQGJvZ3VzLwo+IC0tLQo+ICBEb2N1bWVudGF0aW9uL2Rl dmljZXRyZWUvYmluZGluZ3MvcGNpL2hvc3QtZ2VuZXJpYy1wY2kueWFtbCB8IDYgKysrKysrCj4g IDEgZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvRG9jdW1l bnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3BjaS9ob3N0LWdlbmVyaWMtcGNpLnlhbWwgYi9E b2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGNpL2hvc3QtZ2VuZXJpYy1wY2kueWFt bAo+IGluZGV4IGQyNTQyM2FhNzE2NzQuLjk0ZDRhNDkxNGE0ODMgMTAwNjQ0Cj4gLS0tIGEvRG9j dW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3BjaS9ob3N0LWdlbmVyaWMtcGNpLnlhbWwK PiArKysgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGNpL2hvc3QtZ2VuZXJp Yy1wY2kueWFtbAo+IEBAIC0xMTAsNiArMTEwLDEyIEBAIHByb3BlcnRpZXM6Cj4gICAgaW9tbXUt bWFwLW1hc2s6IHRydWUKPiAgICBtc2ktcGFyZW50OiB0cnVlCj4gIAo+ICsgIGF0cy1zdXBwb3J0 ZWQ6Cj4gKyAgICBkZXNjcmlwdGlvbjoKPiArICAgICAgSW5kaWNhdGVzIHRoYXQgYSBQQ0llIGhv c3QgY29udHJvbGxlciBzdXBwb3J0cyBBVFMsIGFuZCBjYW4gaGFuZGxlIE1lbW9yeQo+ICsgICAg ICBSZXF1ZXN0cyB3aXRoIEFkZHJlc3MgVHlwZSAoQVQpLgo+ICsgICAgdHlwZTogYm9vbGVhbgo+ ICsKPiAgcmVxdWlyZWQ6Cj4gICAgLSBjb21wYXRpYmxlCj4gICAgLSByZWcKPiAtLSAKPiAyLjQ0 LjAKPiAKCi0tIAo9PT09PT09PT09PT09PT09PT09PQp8IEkgd291bGQgbGlrZSB0byB8CnwgZml4 IHRoZSB3b3JsZCwgIHwKfCBidXQgdGhleSdyZSBub3QgfAp8IGdpdmluZyBtZSB0aGUgICB8CiBc IHNvdXJjZSBjb2RlISAgLwogIC0tLS0tLS0tLS0tLS0tLQogICAgwq9cXyjjg4QpXy/CrwoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtl cm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5l bAo=