All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Marzinski <bmarzins@redhat.com>
To: Liao Yuanhong <liaoyuanhong@vivo.com>
Cc: bo.wu@vivo.com, dm-devel@lists.linux.dev, snitzer@kernel.org,
	Pankaj Raghav <p.raghav@samsung.com>,
	damien.lemoal@opensource.wdc.com,
	Bart Van Assche <bvanassche@acm.org>,
	Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH] dm-table:remove the restriction on zone sector being align to pow2
Date: Tue, 30 Apr 2024 18:35:44 -0400	[thread overview]
Message-ID: <ZjFyQH7gr6-_9yIL@redhat.com> (raw)
In-Reply-To: <20240430033207.875-1-liaoyuanhong@vivo.com>

On Tue, Apr 30, 2024 at 11:32:07AM +0800, Liao Yuanhong wrote:
> Currently, the zone size of the ZoneUFS provided by Hynix is not aligned
> to pow2. After testing on the mobile platform with this fix, we found 
> that basic functionality can be executed. May we merge this patch first?

The issue is that device-mapper makes assumptions in multiple places
that zones are power of 2 sized. Simply removing this check will allow
users to create broken device-mapper devices on top of non-power-of-2
devices.

A better solution would be to see if Pankaj Raghav's non-power-of-2 zone
size patchset can be revisited.

-Ben 


      reply	other threads:[~2024-04-30 22:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-29  2:50 [PATCH] dm-table:remove the restriction on zone sector being align to pow2 Liao Yuanhong
2024-04-29 18:51 ` Benjamin Marzinski
2024-04-30  3:32   ` Liao Yuanhong
2024-04-30 22:35     ` Benjamin Marzinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZjFyQH7gr6-_9yIL@redhat.com \
    --to=bmarzins@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=bo.wu@vivo.com \
    --cc=bvanassche@acm.org \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=dm-devel@lists.linux.dev \
    --cc=liaoyuanhong@vivo.com \
    --cc=p.raghav@samsung.com \
    --cc=snitzer@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.