All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adam Goldman <adamg@pobox.com>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firewire: ohci: mask bus reset interrupts between ISR and bottom half
Date: Wed, 1 May 2024 04:39:23 -0700	[thread overview]
Message-ID: <ZjIp68AqHhegFmDv@iguana.24-8.net> (raw)
In-Reply-To: <20240401121800.GA220025@workstation.local>

Hi Takashi,

On Mon, Apr 01, 2024 at 09:18:00PM +0900, Takashi Sakamoto wrote:
> I sent an additional patch[1] to handle the bus-reset event at the first
> time. I'd like you to review and test it as well, especially under your
> environment in which 1394:1995 and 1394a phys exist.
> 
> [1] https://lore.kernel.org/lkml/20240401121200.220013-1-o-takashi@sakamocchi.jp/

I'm sorry for another very late reply.

Now that we eliminated the IRQ storm, it makes sense to always enable 
the bus-reset interrupt at startup. I tested your patch with various 
devices, with a FW800 repeater, with a FW400 hub, without a hub, etc. 
Everything works OK. However, I only tested with XIO2213B OHCI.

-- Adam

  reply	other threads:[~2024-05-01 11:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <ZfqpJ061hLtPT8XL@iguana.24-8.net>
2024-03-25  0:58 ` [PATCH] firewire: ohci: mask bus reset interrupts between ISR and bottom half Takashi Sakamoto
2024-04-01 12:18   ` Takashi Sakamoto
2024-05-01 11:39     ` Adam Goldman [this message]
2024-05-01 23:19       ` Takashi Sakamoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZjIp68AqHhegFmDv@iguana.24-8.net \
    --to=adamg@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=o-takashi@sakamocchi.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.