Re: [PATCH v3 0/6] migration removals & deprecations

[Peter Xu <peterx@redhat.com>]

On Tue, Apr 30, 2024 at 11:27:31AM -0300, Fabiano Rosas wrote:
> since v2:
> 
> - removed some more stuff which I missed:
>    blk/inc options from hmp-commands.hx
>    the entire ram-compress.h
>    unused declarations from options.h
>    unused compression functions from qemu-file.c
> 
> - removed must_remove_block_options earlier in the 'blk' patch
> 
> - added a deprecation warning to outgoing/incoming fd
> 
> CI run: https://gitlab.com/farosas/qemu/-/pipelines/1272385260
> 
> v2:
> https://lore.kernel.org/r/20240426131408.25410-1-farosas@suse.de
> v1:
> https://lore.kernel.org/r/20240425150939.19268-1-farosas@suse.de
> 
> Hi everyone,
> 
> Here's some cleaning up of deprecated code. It removes the old block
> migration and compression code. Both have suitable replacements in the
> form of the blockdev-mirror driver and multifd compression,
> respectively.
> 
> There's also a deprecation for fd: + file to cope with the fact that
> the new MigrationAddress API defines transports instead of protocols
> (loose terms) like the old string API did. So we cannot map 1:1 from
> fd: to any transport because fd: allows *both* file migration and
> socket migration.
> 
> Fabiano Rosas (6):
>   migration: Remove 'skipped' field from MigrationStats
>   migration: Remove 'inc' option from migrate command
>   migration: Remove 'blk/-b' option from migrate commands
>   migration: Remove block migration
>   migration: Remove non-multifd compression
>   migration: Deprecate fd: for file migration

Reviewed-by: Peter Xu <peterx@redhat.com>

-- 
Peter Xu