From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D5911581E3 for ; Wed, 1 May 2024 18:37:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714588661; cv=none; b=mX1b9o6GSbDAAjflifG1jY8F2zF6/BlIjo1BOoiIudiYExAo5xwK8HJgFcvYBMT7yPOpQ7QC5rTdm0tllFK+BUKKSFDt1CN4HUarOiX5kwuVqfVLcTia6d5ByrmCRqYt3qiLyaF2I+1eYUChP261sKat6eP4B5XKhnNJ6d8aXS4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714588661; c=relaxed/simple; bh=JuEww4VdQj0DUkQJJy7CdW/ah+PwXXtcE+4baSBSWmg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=r9ZjHrX+mOBQGfCJeGGW3e0obXswAZz52wK+uVbN6kScBKLJg7uIk6mrOhUmu753Co4qrBnDEhXKsXiqb2jHppbK6IebRmBozrwgz3/ukdF8ZSN92qCByi2i16UXvVyTumSKV5vrfDHUsnXCq3QAH+sq1GipxWWNcpBWccLdY78= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=SU9geB7W; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="SU9geB7W" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-6ecec796323so6782135b3a.3 for ; Wed, 01 May 2024 11:37:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1714588659; x=1715193459; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=UPPZ5LFjy8shqZnGR3m66PAl3+HNQfmLTm+BXjtgDiI=; b=SU9geB7WtsRPik19lbwiTnZkq4+Ugy3cwxvvTohX8CwkOWxS4p3goKGUICi9jfPssK 7g5/wiAocpqguorU9SNgQ1nx/XfxmKxwoFUbPr2HKeW25SxpPTXLnAHSBlQqWsY7lCZs 0AOdHXAyUQmjEfhBvOi/3/yi1vaQJhLHnqJklizccrsiu0CAkvAyVhoZaLbvZwjuBtrg As07tNkCkn56pecg8Y5kBlmfjH9TLr4gXZtilMp1vuEfUKpc6QJ2CTtvkQlhLp9V66tH s1HdQWPF9RNpMyCAU2Ps3R42M4kQo9BpeqqTSDs+ImWlSIWHVriCowOSOzmpdQ3zxvaJ exyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714588659; x=1715193459; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UPPZ5LFjy8shqZnGR3m66PAl3+HNQfmLTm+BXjtgDiI=; b=qi6CDc6+xBeau9VDwKfW/yY1kRA0gMo0hOqytWUMEZNCwdot3YzyNgtus2l4kU/VCG 8f3phhP4Kwd2hCobwryZd23LtmOHCsiZ/DNXwOZTnFaH2KzVKmEEgxj1JuwGMaQV9VL8 rErLkY/hjO4bnHINmSM9jfRFo+7U9hduYyg7g35ePqaTMoA+h5+GLPtETmY7ZxLL2IRq YrkH3CEAAMjsd7FLni8hTNdtQqhPOFSw84VaydhVmiaDqo43QE5WYBogfmsKY1XMoHOC JrK8D8we8nbWjboNzBZgCrfHhRW9NiwowXIhispS6z9CiK157+qDwIahpmzSBMz7u+SL 6Lyw== X-Forwarded-Encrypted: i=1; AJvYcCWlenPhXpU22nfMMn3kMMvmFQgIBLHPEZSMk5fmGXaecZiQAfZ7Ja6/sF/MaAqTZs01UiLPFnqLuuAaZvX90MvKkUU5vpXf+8o5 X-Gm-Message-State: AOJu0YwBVTsrZygNZbVHlSEOC7NDq5xFOgrGeQvfqy7UWFz6isS6RqdP SjO4cUquJ9U0LO4wQH268q7Q8tBR9yfZ888baJIucNIbVNzfPFCt8dT/f7ewGE4= X-Google-Smtp-Source: AGHT+IFvmfcgG9gsaJ1/osT3hsX+JLkHUCdFQSUoli8OLgDET6zbJ2GqgYGb+4vjIsoV+zp3JnL2Pg== X-Received: by 2002:a05:6a20:8425:b0:1a7:3b4a:3e8 with SMTP id c37-20020a056a20842500b001a73b4a03e8mr4113035pzd.7.1714588659240; Wed, 01 May 2024 11:37:39 -0700 (PDT) Received: from ghost ([2601:647:5700:6860:1dcc:e03e:dc61:895d]) by smtp.gmail.com with ESMTPSA id m8-20020a17090ab78800b002b15e6ec4efsm1672349pjr.15.2024.05.01.11.37.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 11:37:38 -0700 (PDT) Date: Wed, 1 May 2024 11:37:35 -0700 From: Charlie Jenkins To: Conor Dooley Cc: Evan Green , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Guo Ren , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Conor Dooley , =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= , Jonathan Corbet , Shuah Khan , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Palmer Dabbelt , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v4 05/16] riscv: Extend cpufeature.c to detect vendor extensions Message-ID: References: <20240426-dev-charlie-support_thead_vector_6_9-v4-0-b692f3c516ec@rivosinc.com> <20240426-dev-charlie-support_thead_vector_6_9-v4-5-b692f3c516ec@rivosinc.com> <20240501-banner-sniff-4c5958eb15ef@spud> <20240501-moneyless-shifter-a54bbaecc4e7@spud> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240501-moneyless-shifter-a54bbaecc4e7@spud> On Wed, May 01, 2024 at 07:09:28PM +0100, Conor Dooley wrote: > On Wed, May 01, 2024 at 07:03:46PM +0100, Conor Dooley wrote: > > On Wed, May 01, 2024 at 10:51:38AM -0700, Charlie Jenkins wrote: > > > On Wed, May 01, 2024 at 09:44:15AM -0700, Evan Green wrote: > > > > On Fri, Apr 26, 2024 at 2:29 PM Charlie Jenkins wrote: > > > > > + for (int i = 0; i < riscv_isa_vendor_ext_list_size; i++) { > > > > > + const struct riscv_isa_vendor_ext_data_list *ext_list = riscv_isa_vendor_ext_list[i]; > > > > > + > > > > > + if (bitmap_empty(ext_list->vendor_bitmap, ext_list->bitmap_size)) > > > > > + bitmap_copy(ext_list->vendor_bitmap, > > > > > + ext_list->per_hart_vendor_bitmap[cpu].isa, > > > > > + ext_list->bitmap_size); > > > > > > > > Could you get into trouble here if the set of vendor extensions > > > > reduces to zero, and then becomes non-zero? To illustrate, consider > > > > these masks: > > > > cpu 0: 0x0000C000 > > > > cpu 1: 0x00000003 <<< vendor_bitmap ANDs out to 0 > > > > cpu 2: 0x00000010 <<< oops, we end up copying this into vendor_bitmap > > > > > > > > > > Huh that's a good point. The standard extensions have that same bug too? > > > > > > if (bitmap_empty(riscv_isa, RISCV_ISA_EXT_MAX)) > > > bitmap_copy(riscv_isa, isainfo->isa, RISCV_ISA_EXT_MAX); > > > else > > > bitmap_and(riscv_isa, riscv_isa, isainfo->isa, RISCV_ISA_EXT_MAX); > > > > I suppose it could in theory, but the boot hart needs ima to even get > > this far. I think you'd only end up with this happening if there were > > enabled harts that supported rvXXe, but I don't think we even add those > > to the possible set of CPUs. I'll have to check. > > Ye, you don't get marked possible if you don't have ima, so I don't > think this is possible to have happen. Maybe a comment here is > sufficient, explaining why this cannot reduce to zeros? Okay cool. A comment is sufficient then. - Charlie > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 651D7C4345F for ; Wed, 1 May 2024 18:37:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=buf0G+kvG+ziHrlo81CFxnEYfx3NlGYahqJRvUoiK7Q=; b=U6MsU8tIRPv4yd X7OxA04X7N1PwuEtFfKbzEfpTUtGJBP/mLYYePshwOMjhEplVfsSNrXA2ybmoHfjrJahywBh06HKf aQo3MCRbeZQzKCCbDWB5Hvi4ocETmuFVuxovPaYrrZgPo8t3otVOORU5ck4SMHsAn/W2CzacyOcpx Iir5baoYGHTmCSdPJGauyIfO6n5Q67ZCB6UDUClXmCP3/eS6fZAo/XAkiqPGl9X/mNVk4mJiN928P 5ZRfZpW7DIeGWciLI9OlsGYjH9nevM9864AekuQfaQQbmPl5rkTdCvnzCEQsbAXgJcND0rAWEFanr hOUi6ZNVipSZHdYDFCvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2Epu-0000000AR9G-0rzF; Wed, 01 May 2024 18:37:46 +0000 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2Epp-0000000AR7W-24DI for linux-riscv@lists.infradead.org; Wed, 01 May 2024 18:37:43 +0000 Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-6ed627829e6so8378453b3a.1 for ; Wed, 01 May 2024 11:37:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1714588659; x=1715193459; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=UPPZ5LFjy8shqZnGR3m66PAl3+HNQfmLTm+BXjtgDiI=; b=F5MljuIp5A13QK5wreLhYPpt0DU9chosuEtDQ088/b71Tta16zyG2YrfQEn82LfAy4 6QQx582863iR0Ziu9A4SMwXP6Li2TnF4u7zj9+PHoKpsHPLh5lW0ToD6DnDJtyz601y+ AM2cfVB7m0wBJCOYHVQtzixBpFwFhYahzdv6onh71exJMGOJ8dty2rSuCDkrJog1LD7Z oCk8U+S0NcFwxYipdJOBwIaw/bqZ9BGRAlQl/bqAD3s1zbp2dXjjmCQLiqHfBeApKFFG KDt6Y2j75saANl48LBidvUT3xy7RfWjc1/Vz9+lxZa2qzO1rj4AkZE/+rsYp5Ts76Vve PyAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714588659; x=1715193459; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UPPZ5LFjy8shqZnGR3m66PAl3+HNQfmLTm+BXjtgDiI=; b=L+T3+qNDpug0RwG90qLX8dEdPb1X+T6vKdAFZHb6NpRH61T7cgzJnVSXofC8MGsKxX /EySELOaW838ZiH6RopDlWKp5wRwNt+uxCzHpDrHbSga/HmZOvXpToqLRWqb8wxQ1ph2 5Oo/Yhv7E17eFRr+OfwHPUDv04dDRYhDeih2K8BlF4bpgJDpAdn7bOue2qLAMrMpOxcQ fhnYc+d4xst1j0DjNIay9vOcnel+krc93Ys8WtKVSSzx5I7TzDvecInM+4s3KIfBhg4B 24wC8RY2QtwqnnoEfL3UQpytoTKbMLAG93ipaYF/iMPhjuWW72oN9Fc4AHsyv1GVfzhQ LiRw== X-Forwarded-Encrypted: i=1; AJvYcCU39I20ee3bOj60j2Kg19MR8Zm4wpKthFkHIHAsPp6Lo43k0I8U7Ji+E/DoUELYeKclm2WViRlCZw5lEIbJ8srM/kBr2LjjfVnUb+e+emWa X-Gm-Message-State: AOJu0YwFNjF+4TaadNn/NH5Znkald5hMf7novTJ20BfuNXkth+FwsubH YjAAGLpE3EXaT5WHwNtmp54egKTly9FjKuEInXo0UKTtuRyjKIJ2Tyl6aAFU8rU= X-Google-Smtp-Source: AGHT+IFvmfcgG9gsaJ1/osT3hsX+JLkHUCdFQSUoli8OLgDET6zbJ2GqgYGb+4vjIsoV+zp3JnL2Pg== X-Received: by 2002:a05:6a20:8425:b0:1a7:3b4a:3e8 with SMTP id c37-20020a056a20842500b001a73b4a03e8mr4113035pzd.7.1714588659240; Wed, 01 May 2024 11:37:39 -0700 (PDT) Received: from ghost ([2601:647:5700:6860:1dcc:e03e:dc61:895d]) by smtp.gmail.com with ESMTPSA id m8-20020a17090ab78800b002b15e6ec4efsm1672349pjr.15.2024.05.01.11.37.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 11:37:38 -0700 (PDT) Date: Wed, 1 May 2024 11:37:35 -0700 From: Charlie Jenkins To: Conor Dooley Cc: Evan Green , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Guo Ren , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Conor Dooley , =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= , Jonathan Corbet , Shuah Khan , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Palmer Dabbelt , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v4 05/16] riscv: Extend cpufeature.c to detect vendor extensions Message-ID: References: <20240426-dev-charlie-support_thead_vector_6_9-v4-0-b692f3c516ec@rivosinc.com> <20240426-dev-charlie-support_thead_vector_6_9-v4-5-b692f3c516ec@rivosinc.com> <20240501-banner-sniff-4c5958eb15ef@spud> <20240501-moneyless-shifter-a54bbaecc4e7@spud> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240501-moneyless-shifter-a54bbaecc4e7@spud> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240501_113741_569630_51CEEE51 X-CRM114-Status: GOOD ( 23.51 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gV2VkLCBNYXkgMDEsIDIwMjQgYXQgMDc6MDk6MjhQTSArMDEwMCwgQ29ub3IgRG9vbGV5IHdy b3RlOgo+IE9uIFdlZCwgTWF5IDAxLCAyMDI0IGF0IDA3OjAzOjQ2UE0gKzAxMDAsIENvbm9yIERv b2xleSB3cm90ZToKPiA+IE9uIFdlZCwgTWF5IDAxLCAyMDI0IGF0IDEwOjUxOjM4QU0gLTA3MDAs IENoYXJsaWUgSmVua2lucyB3cm90ZToKPiA+ID4gT24gV2VkLCBNYXkgMDEsIDIwMjQgYXQgMDk6 NDQ6MTVBTSAtMDcwMCwgRXZhbiBHcmVlbiB3cm90ZToKPiA+ID4gPiBPbiBGcmksIEFwciAyNiwg MjAyNCBhdCAyOjI54oCvUE0gQ2hhcmxpZSBKZW5raW5zIDxjaGFybGllQHJpdm9zaW5jLmNvbT4g d3JvdGU6Cj4gPiA+ID4gPiArICAgICAgIGZvciAoaW50IGkgPSAwOyBpIDwgcmlzY3ZfaXNhX3Zl bmRvcl9leHRfbGlzdF9zaXplOyBpKyspIHsKPiA+ID4gPiA+ICsgICAgICAgICAgICAgICBjb25z dCBzdHJ1Y3QgcmlzY3ZfaXNhX3ZlbmRvcl9leHRfZGF0YV9saXN0ICpleHRfbGlzdCA9IHJpc2N2 X2lzYV92ZW5kb3JfZXh0X2xpc3RbaV07Cj4gPiA+ID4gPiArCj4gPiA+ID4gPiArICAgICAgICAg ICAgICAgaWYgKGJpdG1hcF9lbXB0eShleHRfbGlzdC0+dmVuZG9yX2JpdG1hcCwgZXh0X2xpc3Qt PmJpdG1hcF9zaXplKSkKPiA+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIGJpdG1hcF9j b3B5KGV4dF9saXN0LT52ZW5kb3JfYml0bWFwLAo+ID4gPiA+ID4gKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgZXh0X2xpc3QtPnBlcl9oYXJ0X3ZlbmRvcl9iaXRtYXBbY3B1XS5p c2EsCj4gPiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBleHRfbGlz dC0+Yml0bWFwX3NpemUpOwo+ID4gPiA+IAo+ID4gPiA+IENvdWxkIHlvdSBnZXQgaW50byB0cm91 YmxlIGhlcmUgaWYgdGhlIHNldCBvZiB2ZW5kb3IgZXh0ZW5zaW9ucwo+ID4gPiA+IHJlZHVjZXMg dG8gemVybywgYW5kIHRoZW4gYmVjb21lcyBub24temVybz8gVG8gaWxsdXN0cmF0ZSwgY29uc2lk ZXIKPiA+ID4gPiB0aGVzZSBtYXNrczoKPiA+ID4gPiBjcHUgMDogMHgwMDAwQzAwMAo+ID4gPiA+ IGNwdSAxOiAweDAwMDAwMDAzIDw8PCB2ZW5kb3JfYml0bWFwIEFORHMgb3V0IHRvIDAKPiA+ID4g PiBjcHUgMjogMHgwMDAwMDAxMCA8PDwgb29wcywgd2UgZW5kIHVwIGNvcHlpbmcgdGhpcyBpbnRv IHZlbmRvcl9iaXRtYXAKPiA+ID4gPiAKPiA+ID4gCj4gPiA+IEh1aCB0aGF0J3MgYSBnb29kIHBv aW50LiBUaGUgc3RhbmRhcmQgZXh0ZW5zaW9ucyBoYXZlIHRoYXQgc2FtZSBidWcgdG9vPwo+ID4g PiAKPiA+ID4gCWlmIChiaXRtYXBfZW1wdHkocmlzY3ZfaXNhLCBSSVNDVl9JU0FfRVhUX01BWCkp Cj4gPiA+IAkJYml0bWFwX2NvcHkocmlzY3ZfaXNhLCBpc2FpbmZvLT5pc2EsIFJJU0NWX0lTQV9F WFRfTUFYKTsKPiA+ID4gCWVsc2UKPiA+ID4gCQliaXRtYXBfYW5kKHJpc2N2X2lzYSwgcmlzY3Zf aXNhLCBpc2FpbmZvLT5pc2EsIFJJU0NWX0lTQV9FWFRfTUFYKTsKPiA+IAo+ID4gSSBzdXBwb3Nl IGl0IGNvdWxkIGluIHRoZW9yeSwgYnV0IHRoZSBib290IGhhcnQgbmVlZHMgaW1hIHRvIGV2ZW4g Z2V0Cj4gPiB0aGlzIGZhci4gSSB0aGluayB5b3UnZCBvbmx5IGVuZCB1cCB3aXRoIHRoaXMgaGFw cGVuaW5nIGlmIHRoZXJlIHdlcmUKPiA+IGVuYWJsZWQgaGFydHMgdGhhdCBzdXBwb3J0ZWQgcnZY WGUsIGJ1dCBJIGRvbid0IHRoaW5rIHdlIGV2ZW4gYWRkIHRob3NlCj4gPiB0byB0aGUgcG9zc2li bGUgc2V0IG9mIENQVXMuIEknbGwgaGF2ZSB0byBjaGVjay4KPiAKPiBZZSwgeW91IGRvbid0IGdl dCBtYXJrZWQgcG9zc2libGUgaWYgeW91IGRvbid0IGhhdmUgaW1hLCBzbyBJIGRvbid0Cj4gdGhp bmsgdGhpcyBpcyBwb3NzaWJsZSB0byBoYXZlIGhhcHBlbi4gTWF5YmUgYSBjb21tZW50IGhlcmUg aXMKPiBzdWZmaWNpZW50LCBleHBsYWluaW5nIHdoeSB0aGlzIGNhbm5vdCByZWR1Y2UgdG8gemVy b3M/CgpPa2F5IGNvb2wuIEEgY29tbWVudCBpcyBzdWZmaWNpZW50IHRoZW4uCgotIENoYXJsaWUK Cj4gCj4gCgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmxpbnV4LXJpc2N2IG1haWxpbmcgbGlzdApsaW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3Jn Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcmlzY3YK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E587DC4345F for ; Wed, 1 May 2024 18:37:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=a4DMn7nuVMTIBIAH4mt3x/b3pVRuamMBdBhPQWm7FI0=; b=HnfVloakof+zM7 OdMSzjdlUdYXuh9VaH/5pMjrSL7iJfwwogaWQzn7BOUi0WfYtV5WBtZml/CNAgVk/ZeqPX6QZD2nP herLWFQ/vEUfPfiGhETelur76qWtEL03h7Y+krVg5VuKjis5ud5oibQ9+jtHNpPdPlvKTYhf+g962 1k6VSpAbJ9MAiOklLDFJ+MwDyC4Ts8J035644LwirgbHWDq4igRW4DyI59Yri+tRIZqquVJSpaanz +5cOK4kLZMsI2ZsGhLJTAGAcmeFJRUPAtFz5/s2Apy3YD+nBAy7XVzVRIaJj5Rhwmjj5UQz9HKCLl eDk1kEkabfHe3thb6nGg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2Ept-0000000AR8f-29qN; Wed, 01 May 2024 18:37:45 +0000 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2Epp-0000000AR7X-23t9 for linux-arm-kernel@lists.infradead.org; Wed, 01 May 2024 18:37:43 +0000 Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-6ed04c91c46so6780918b3a.0 for ; Wed, 01 May 2024 11:37:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1714588659; x=1715193459; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=UPPZ5LFjy8shqZnGR3m66PAl3+HNQfmLTm+BXjtgDiI=; b=F5MljuIp5A13QK5wreLhYPpt0DU9chosuEtDQ088/b71Tta16zyG2YrfQEn82LfAy4 6QQx582863iR0Ziu9A4SMwXP6Li2TnF4u7zj9+PHoKpsHPLh5lW0ToD6DnDJtyz601y+ AM2cfVB7m0wBJCOYHVQtzixBpFwFhYahzdv6onh71exJMGOJ8dty2rSuCDkrJog1LD7Z oCk8U+S0NcFwxYipdJOBwIaw/bqZ9BGRAlQl/bqAD3s1zbp2dXjjmCQLiqHfBeApKFFG KDt6Y2j75saANl48LBidvUT3xy7RfWjc1/Vz9+lxZa2qzO1rj4AkZE/+rsYp5Ts76Vve PyAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714588659; x=1715193459; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UPPZ5LFjy8shqZnGR3m66PAl3+HNQfmLTm+BXjtgDiI=; b=N/kdun6Rng5Uct3p1Y893aHtweU23uoCFn9lq5BVDBV9HGmNr5GOOD7/inE8JKmvjK VrSjZWApW7zvCnxpMxWqxH45B5PqGQncvFqq1KsiYxIN0h2uJuRFWJJaAod6tyVcqsSH jA2YISd7AzQ/xuaF/MUmbIZA465bitxi4TE6/8L79vGzzGCQKeZ2hks+DpfMl0P+9YGM z4PQnqhDAyPPZBH4bYa6XZyepAXmZqEFx3rabC10P8g3Lt/HOe5fHb8A1PsOyQOZQttU HkNNUxCzXRxXLKrv7TBX0tOfNC0IoJl4WfFiw1OBEfgfLtCoBTrrc2BD0EXPe4wGJfig sStg== X-Forwarded-Encrypted: i=1; AJvYcCVYvIsWOowgca6Gvz1zQqGMPNlgNoUD/zbP6eTjQbrgy87aTOs94S1gsEUZt/MZUTCov1rKri6m4vMNlC2cCq2MDf/w4/dSm+NiSJNRk+DqBBtfajY= X-Gm-Message-State: AOJu0YwgHriRTyS27Jrrx7ztPSyGc3eJJli+0+yvu6dw8HGiaD42oTvn YrMBOLJgp4OHTKEpOM7Mma3hdljilZ11TOEtRuJ4IIaY4S9256bAk1RNHKejRrg= X-Google-Smtp-Source: AGHT+IFvmfcgG9gsaJ1/osT3hsX+JLkHUCdFQSUoli8OLgDET6zbJ2GqgYGb+4vjIsoV+zp3JnL2Pg== X-Received: by 2002:a05:6a20:8425:b0:1a7:3b4a:3e8 with SMTP id c37-20020a056a20842500b001a73b4a03e8mr4113035pzd.7.1714588659240; Wed, 01 May 2024 11:37:39 -0700 (PDT) Received: from ghost ([2601:647:5700:6860:1dcc:e03e:dc61:895d]) by smtp.gmail.com with ESMTPSA id m8-20020a17090ab78800b002b15e6ec4efsm1672349pjr.15.2024.05.01.11.37.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 11:37:38 -0700 (PDT) Date: Wed, 1 May 2024 11:37:35 -0700 From: Charlie Jenkins To: Conor Dooley Cc: Evan Green , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Guo Ren , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Conor Dooley , =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= , Jonathan Corbet , Shuah Khan , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Palmer Dabbelt , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v4 05/16] riscv: Extend cpufeature.c to detect vendor extensions Message-ID: References: <20240426-dev-charlie-support_thead_vector_6_9-v4-0-b692f3c516ec@rivosinc.com> <20240426-dev-charlie-support_thead_vector_6_9-v4-5-b692f3c516ec@rivosinc.com> <20240501-banner-sniff-4c5958eb15ef@spud> <20240501-moneyless-shifter-a54bbaecc4e7@spud> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240501-moneyless-shifter-a54bbaecc4e7@spud> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240501_113741_599879_E1D3DE81 X-CRM114-Status: GOOD ( 25.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBNYXkgMDEsIDIwMjQgYXQgMDc6MDk6MjhQTSArMDEwMCwgQ29ub3IgRG9vbGV5IHdy b3RlOgo+IE9uIFdlZCwgTWF5IDAxLCAyMDI0IGF0IDA3OjAzOjQ2UE0gKzAxMDAsIENvbm9yIERv b2xleSB3cm90ZToKPiA+IE9uIFdlZCwgTWF5IDAxLCAyMDI0IGF0IDEwOjUxOjM4QU0gLTA3MDAs IENoYXJsaWUgSmVua2lucyB3cm90ZToKPiA+ID4gT24gV2VkLCBNYXkgMDEsIDIwMjQgYXQgMDk6 NDQ6MTVBTSAtMDcwMCwgRXZhbiBHcmVlbiB3cm90ZToKPiA+ID4gPiBPbiBGcmksIEFwciAyNiwg MjAyNCBhdCAyOjI54oCvUE0gQ2hhcmxpZSBKZW5raW5zIDxjaGFybGllQHJpdm9zaW5jLmNvbT4g d3JvdGU6Cj4gPiA+ID4gPiArICAgICAgIGZvciAoaW50IGkgPSAwOyBpIDwgcmlzY3ZfaXNhX3Zl bmRvcl9leHRfbGlzdF9zaXplOyBpKyspIHsKPiA+ID4gPiA+ICsgICAgICAgICAgICAgICBjb25z dCBzdHJ1Y3QgcmlzY3ZfaXNhX3ZlbmRvcl9leHRfZGF0YV9saXN0ICpleHRfbGlzdCA9IHJpc2N2 X2lzYV92ZW5kb3JfZXh0X2xpc3RbaV07Cj4gPiA+ID4gPiArCj4gPiA+ID4gPiArICAgICAgICAg ICAgICAgaWYgKGJpdG1hcF9lbXB0eShleHRfbGlzdC0+dmVuZG9yX2JpdG1hcCwgZXh0X2xpc3Qt PmJpdG1hcF9zaXplKSkKPiA+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIGJpdG1hcF9j b3B5KGV4dF9saXN0LT52ZW5kb3JfYml0bWFwLAo+ID4gPiA+ID4gKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgZXh0X2xpc3QtPnBlcl9oYXJ0X3ZlbmRvcl9iaXRtYXBbY3B1XS5p c2EsCj4gPiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBleHRfbGlz dC0+Yml0bWFwX3NpemUpOwo+ID4gPiA+IAo+ID4gPiA+IENvdWxkIHlvdSBnZXQgaW50byB0cm91 YmxlIGhlcmUgaWYgdGhlIHNldCBvZiB2ZW5kb3IgZXh0ZW5zaW9ucwo+ID4gPiA+IHJlZHVjZXMg dG8gemVybywgYW5kIHRoZW4gYmVjb21lcyBub24temVybz8gVG8gaWxsdXN0cmF0ZSwgY29uc2lk ZXIKPiA+ID4gPiB0aGVzZSBtYXNrczoKPiA+ID4gPiBjcHUgMDogMHgwMDAwQzAwMAo+ID4gPiA+ IGNwdSAxOiAweDAwMDAwMDAzIDw8PCB2ZW5kb3JfYml0bWFwIEFORHMgb3V0IHRvIDAKPiA+ID4g PiBjcHUgMjogMHgwMDAwMDAxMCA8PDwgb29wcywgd2UgZW5kIHVwIGNvcHlpbmcgdGhpcyBpbnRv IHZlbmRvcl9iaXRtYXAKPiA+ID4gPiAKPiA+ID4gCj4gPiA+IEh1aCB0aGF0J3MgYSBnb29kIHBv aW50LiBUaGUgc3RhbmRhcmQgZXh0ZW5zaW9ucyBoYXZlIHRoYXQgc2FtZSBidWcgdG9vPwo+ID4g PiAKPiA+ID4gCWlmIChiaXRtYXBfZW1wdHkocmlzY3ZfaXNhLCBSSVNDVl9JU0FfRVhUX01BWCkp Cj4gPiA+IAkJYml0bWFwX2NvcHkocmlzY3ZfaXNhLCBpc2FpbmZvLT5pc2EsIFJJU0NWX0lTQV9F WFRfTUFYKTsKPiA+ID4gCWVsc2UKPiA+ID4gCQliaXRtYXBfYW5kKHJpc2N2X2lzYSwgcmlzY3Zf aXNhLCBpc2FpbmZvLT5pc2EsIFJJU0NWX0lTQV9FWFRfTUFYKTsKPiA+IAo+ID4gSSBzdXBwb3Nl IGl0IGNvdWxkIGluIHRoZW9yeSwgYnV0IHRoZSBib290IGhhcnQgbmVlZHMgaW1hIHRvIGV2ZW4g Z2V0Cj4gPiB0aGlzIGZhci4gSSB0aGluayB5b3UnZCBvbmx5IGVuZCB1cCB3aXRoIHRoaXMgaGFw cGVuaW5nIGlmIHRoZXJlIHdlcmUKPiA+IGVuYWJsZWQgaGFydHMgdGhhdCBzdXBwb3J0ZWQgcnZY WGUsIGJ1dCBJIGRvbid0IHRoaW5rIHdlIGV2ZW4gYWRkIHRob3NlCj4gPiB0byB0aGUgcG9zc2li bGUgc2V0IG9mIENQVXMuIEknbGwgaGF2ZSB0byBjaGVjay4KPiAKPiBZZSwgeW91IGRvbid0IGdl dCBtYXJrZWQgcG9zc2libGUgaWYgeW91IGRvbid0IGhhdmUgaW1hLCBzbyBJIGRvbid0Cj4gdGhp bmsgdGhpcyBpcyBwb3NzaWJsZSB0byBoYXZlIGhhcHBlbi4gTWF5YmUgYSBjb21tZW50IGhlcmUg aXMKPiBzdWZmaWNpZW50LCBleHBsYWluaW5nIHdoeSB0aGlzIGNhbm5vdCByZWR1Y2UgdG8gemVy b3M/CgpPa2F5IGNvb2wuIEEgY29tbWVudCBpcyBzdWZmaWNpZW50IHRoZW4uCgotIENoYXJsaWUK Cj4gCj4gCgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LWFybS1rZXJuZWwK