From: Roman Gushchin <roman.gushchin@linux.dev>
To: Shakeel Butt <shakeel.butt@linux.dev>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Muchun Song <muchun.song@linux.dev>,
Yosry Ahmed <yosryahmed@google.com>,
"T . J . Mercier" <tjmercier@google.com>,
kernel-team@meta.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 8/8] memcg: use proper type for mod_memcg_state
Date: Wed, 1 May 2024 16:23:52 -0700 [thread overview]
Message-ID: <ZjLPCE1F5oH91sHU@P9FQF9L96D> (raw)
In-Reply-To: <20240501172617.678560-9-shakeel.butt@linux.dev>
On Wed, May 01, 2024 at 10:26:17AM -0700, Shakeel Butt wrote:
> The memcg stats update functions can take arbitrary integer but the
> only input which make sense is enum memcg_stat_item and we don't
> want these functions to be called with arbitrary integer, so replace
> the parameter type with enum memcg_stat_item and compiler will be able
> to warn if memcg stat update functions are called with incorrect index
> value.
>
> Signed-off-by: Shakeel Butt <shakeel.butt@linux.dev>
> Reviewed-by: T.J. Mercier <tjmercier@google.com>
Reviewed-by: Roman Gushchin <roman.gushchin@linux.dev>
Thanks!
prev parent reply other threads:[~2024-05-01 23:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 17:26 [PATCH v4 0/8] memcg: reduce memory consumption by memcg stats Shakeel Butt
2024-05-01 17:26 ` [PATCH v4 1/8] memcg: reduce memory size of mem_cgroup_events_index Shakeel Butt
2024-05-01 17:26 ` [PATCH v4 2/8] memcg: dynamically allocate lruvec_stats Shakeel Butt
2024-05-01 23:19 ` Roman Gushchin
2024-05-01 17:26 ` [PATCH v4 3/8] mm: memcg: account memory used for memcg vmstats and lruvec stats Shakeel Butt
2024-05-01 17:26 ` [PATCH v4 4/8] memcg: reduce memory for the lruvec and memcg stats Shakeel Butt
2024-05-01 23:20 ` Roman Gushchin
2024-05-01 17:26 ` [PATCH v4 5/8] memcg: cleanup __mod_memcg_lruvec_state Shakeel Butt
2024-05-01 17:26 ` [PATCH v4 6/8] mm: cleanup WORKINGSET_NODES in workingset Shakeel Butt
2024-05-01 17:26 ` [PATCH v4 7/8] memcg: warn for unexpected events and stats Shakeel Butt
2024-05-01 23:23 ` Roman Gushchin
2024-05-01 17:26 ` [PATCH v4 8/8] memcg: use proper type for mod_memcg_state Shakeel Butt
2024-05-01 23:23 ` Roman Gushchin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjLPCE1F5oH91sHU@P9FQF9L96D \
--to=roman.gushchin@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=tjmercier@google.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.