Re: Fails to build on arm{el,hf} with 64bit time_t: export-cache.c:110:51: error: format ‘%ld’ expects argument of type ‘long int’, but argument 4 has type ‘time_t’ {aka ‘long long int’} [-Werror=format=]

[Salvatore Bonaccorso <carnil@debian.org>]

Hi all,

On Sat, Apr 06, 2024 at 07:28:58PM +0000, Chuck Lever III wrote:
> 
> 
> > On Apr 6, 2024, at 3:15 PM, Salvatore Bonaccorso <carnil@debian.org> wrote:
> > 
> > Hi Chuck, hi Steve,
> > 
> > In Debian, as you might have heard there is a 64bit time_t
> > transition[1] ongoing affecting the armel and armhf architectures.
> > While doing so, nfs-utils was found to fail to build for those
> > architectures after the switch, reported in Debian as [2]. Vladimir
> > Petko from Ubuntu has as well filled it in [3].
> > 
> > [1]: https://lists.debian.org/debian-devel-announce/2024/02/msg00005.html
> > [2]: https://bugs.debian.org/1067829
> > [3]: https://bugzilla.kernel.org/show_bug.cgi?id=218540
> > 
> > The report is full-quoted below. 
> > 
> > Vladimir Petko has created a patch in the bugzilla which I'm attaching
> > here as well. If this is not an acceptable format due to missing
> > Signed-off's I'm attaching a variant with a Suggested-by for Vladimir
> > to properly credit the patch origin.
> > 
> > Let me know if that works. I changed it slightly and only casting to
> > long long, and made it almost checkpatch clean.
> 
> I suppose strftime(3) might be nicer, but this works.
> 
> Reviewed-by: Chuck Lever <chuck.lever@oracle.com <mailto:chuck.lever@oracle.com>>

I noticed this is not yet applied to the repository, do you need
anything else from me or did it just felt trouch the cracks or
actually queued?

Asking since if you want to have it done differently I will then
follow suit downstream as well in Debian, where we have for now
applied the submitted patch.

Regards,
Salvatore