From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 31171C4345F for ; Thu, 2 May 2024 08:33:06 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 45A7610F034; Thu, 2 May 2024 08:33:05 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="TEheLKjG"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id EE95410F034 for ; Thu, 2 May 2024 08:33:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714638784; x=1746174784; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=b+TuzblpaPLNqK5y6jojd+QDA8Xbs2mf6a72pzvmDAE=; b=TEheLKjGLHU7o/iq0wrQYIfJ55KBaAtEk0YzBLUzYICaVC2FxQakfH70 oY0+F0tElAzEKIe6i/rXNNKnGMuO/4QGad8eLKiu27WNSQW2KxKnUbst2 szgoq2CvgCVQwsgyHFoVQrFv77FVCs+WzCOaLQ/TErnTeyuksnwVZmSaD wZuDeSaZiNNQVpwECCOShvZxI+62OL2c6IrIpnSxpWKkWp8fLfTi6PQRh BsF6fQpP6+u0rXuJ/IZqmFjO1556HXZv0hbj76oxjquveB6zhMjLMLDUV 4VgEjXmerXCq69+jzWa3uQySAebwNkSAjYG74/CuqMSbT4o+WCS/Fg5A8 A==; X-CSE-ConnectionGUID: 62J4FWQZRN62QOKnTqynGQ== X-CSE-MsgGUID: wpGHCKDdTgaEdYcO+4epfg== X-IronPort-AV: E=McAfee;i="6600,9927,11061"; a="10562676" X-IronPort-AV: E=Sophos;i="6.07,247,1708416000"; d="scan'208";a="10562676" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 May 2024 01:33:02 -0700 X-CSE-ConnectionGUID: JAgRKzqdSdq31tSxNlgi/g== X-CSE-MsgGUID: WvDCmPXcTl6Tok3RT2k4rw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,247,1708416000"; d="scan'208";a="27059626" Received: from smile.fi.intel.com ([10.237.72.54]) by fmviesa008.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 May 2024 01:32:12 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1s2RrM-00000003FFm-3aSR; Thu, 02 May 2024 11:32:08 +0300 Date: Thu, 2 May 2024 11:32:08 +0300 From: Andy Shevchenko To: Sui Jingfeng Cc: Neil Armstrong , Randy Dunlap , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter Subject: Re: [v1,1/3] drm/panel: ili9341: Correct use of device property APIs Message-ID: References: <20240425142706.2440113-2-andriy.shevchenko@linux.intel.com> <9e69b129-7539-4403-a621-bf3775aab995@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9e69b129-7539-4403-a621-bf3775aab995@linux.dev> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, May 01, 2024 at 12:27:14AM +0800, Sui Jingfeng wrote: > On 2024/4/30 22:13, Andy Shevchenko wrote: > > On Fri, Apr 26, 2024 at 05:13:43AM +0800, Sui Jingfeng wrote: ... > > the former might be subdivided to "is it swnode backed or real fwnode one?" > > > Yeah, > On non-DT cases, it can be subdivided to swnode backed case and ACPI fwnode backed case. > > - For swnode backed case: the device_get_match_data() don't has a implemented backend. > - For ACPI fwnode backed case: the device_get_match_data() has a implemented backend. > > But the driver has *neither* software node support True. > nor ACPI support, Not true. So, slow down and take your time to get into the code and understand how it works. > so that the rotation property can not get and ili9341_dpi_probe() will fails. > So in total, this is not a 100% correct use of device property APIs. > > But I'm fine that if you want to leave(ignore) those less frequent use cases temporarily, > there may have programmers want to post patches, to complete the missing in the future. > > So, there do have some gains on non-DT cases. > > - As you make it be able to compiled on X86 with the drm-misc-defconfig. > - You cleanup the code up (at least patch 2 in this series is no obvious problem). > - You allow people to modprobe it, and maybe half right and half undefined. > > But you do helps moving something forward, so congratulations for the wake up. -- With Best Regards, Andy Shevchenko