Re: [PATCH] migration/rdma: Allow building without on-demand paging support

["Daniel P. Berrangé" <berrange@redhat.com>]

On Thu, May 02, 2024 at 11:19:28AM +0200, Philippe Mathieu-Daudé wrote:
> On 2/5/24 11:10, Daniel P. Berrangé wrote:
> > On Thu, May 02, 2024 at 11:05:47AM +0200, Philippe Mathieu-Daudé wrote:
> > > On-demand paging support was added in libibverbs v1.2.0 in
> > > commit https://github.com/linux-rdma/rdma-core/commit/e500adc7b1
> > 
> > That is 9 years old, so I'm surprised any distro we target still
> > is so outdated. Can you say what distro you're seeing a problem
> > on and what version it has ?
> 
> This is Oracle Solaris 11.4 SRU, released 2 weeks ago:
> https://support.oracle.com/knowledge/Sun%20Microsystems/2433412_1.html

Solaris 11.4 was originally from 2018 IIUC, so that explains why
it is so ancient.

> I'm not sure how to detect the version, I'm seeing downstream
> patches applied on top.

When this was first introduced there was no pkg-config files
present, nor was it using cmake, or even library versioning
afaics.

The pkgconfig files were added 3 years later in

  commit df5fe3c2fa9d7dbb38fb7b4878955330620211ed
  Author: Luca Boccassi <bluca@debian.org>
  Date:   Tue Aug 28 19:46:07 2018 +0100

    Generate and install pkgconfig files for libs

which at that point had defined:

  CMakeLists.txt:set(PACKAGE_VERSION "20.0")
  librdmacm/CMakeLists.txt:  1 1.1.${PACKAGE_VERSION}
  libibverbs/CMakeLists.txt:  1 1.5.${PACKAGE_VERSION}

So I think we can try checking

  libibverbs >= 1.5
  rdmacm >= 1.1

in meson.build, and see if that solves the Solaris
problem....depends what the scope of their downstream
patches is.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|