From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com [209.85.128.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 427F25FDB5 for ; Thu, 2 May 2024 11:01:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714647672; cv=none; b=oVRDs0LXj/LaASfwjSLTY6aEyvcyxXhs0tpREjLLeFcgaDf4g0s1LhD7lsMsHcpzpEcPbTzobLHzfV6Ii/OGdTtzB1Jyh1l0qaTLsGnb5HFEn2ClVCqVJBzarkso0CR3vsimM6DoGdO742UUKKybIyY5KgRPD+8mDMoHwOzrQho= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714647672; c=relaxed/simple; bh=ndLSvNTaHy7rcB+YkF1gfmdHrNAQTVgDr2rY9G9+Z/k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hhDIaMWGhbg+lJ0IXrxP+yIOA3nJgGDNiTQRqfm3KuCGz8CZv3vpmXltmH8sJ+vVkrUADdfKPt09sCAl5CEFCyve3//O0Rvy9DaIeM19AlluWkUet1sEsrVtKPo0R3saY8GqnTNgiUPZ263G+cnRqFrYWsebXWfP29pCig809Zs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com; spf=pass smtp.mailfrom=ventanamicro.com; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b=K6RvsGKg; arc=none smtp.client-ip=209.85.128.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b="K6RvsGKg" Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-617e42a3f94so83567607b3.2 for ; Thu, 02 May 2024 04:01:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1714647670; x=1715252470; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yjTLbsaK8lFll8/qZ6Wbe+KOojRpVIeEGiQdgeTUV/M=; b=K6RvsGKgnmqjrbmQe157B5vOKfTPdSOlhRB2eWekEhtXoZw+GcumJur9URJzk1JMXj A3mofPm+BQ+jHpZlor5hJegymcrnPshmoLaHpHOd/tkE7P62ttYVTQrLpS8oPvY/jDmg 6IM6gXLxlzOLR6dUCCL8swiVyC7NaLnwLugzgaYuawdNdrNc9TXWQykPLyPIWijiqcyE +h0G5n5z68Sljo4DWZnvOMVAd3iPZRo9f2szDwvBUXIiW9tkxt1JbE+g9RRhax+wFont dAVUeivWAHjyx/nt6a/Nk92P5O5B4rggF9OoAZaVwkw7990aPtD1eAsiJrdf+oVfZzX5 SCAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714647670; x=1715252470; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yjTLbsaK8lFll8/qZ6Wbe+KOojRpVIeEGiQdgeTUV/M=; b=CYj9hJHIDjLOjSmz9XKh/eAwUBRYvrZmtJ2p9g3TbhVTsjW91bppSj7hGtemAx7NzX MqmSGc3ghEF4vMoCoEEjMqj72SFiaMkHGZFZwZZ8n+b6Iwdx3diGU1hhrlSVE+7fA29P LSCA4nfMyNjckqcQ71t2puvHMprWTvAci16Z7r9JPyoQB7dh7ziULnkKIqcUkeEqzahR 49Ky9Wjr27VDvntTbf/LhHIKXqgw5weimM19gywm3xI64Aww6FU41HGa3AOQFNONQkaH FmgI5zcEaUMHKLsLHVkqTb7c+0CDSJDFLbNvIlMF49xugbY5rcBjzfqpIup+ckCsqKwX zYMA== X-Forwarded-Encrypted: i=1; AJvYcCWo46UhfAJq5GBqgosM1UkGxEp+S2e1u1aySWIig3KxlPmtBRrsyFXtIRn/sbNBOzt3HhY9ZpAQKADMmH6fTLULwWYiIT/vcU5MjxT4 X-Gm-Message-State: AOJu0YzVa5rfeUPltMCu7WeBwTy0O/I6RX18E8YHs2uOtPGg0N98khcY h4gp/BZJQmjX518c9g0hWDRzSyrdbH/Yxgv8RtPClHU/mpJEHmWXgNcoG/cMGyw= X-Google-Smtp-Source: AGHT+IHfkJrlGnon/mEX5fWtLywYkDj4de083FrQTvrfO2XC94gdhaKM/ttBrgT+XJ2VbkvvaIQxaw== X-Received: by 2002:a05:690c:d88:b0:61a:d2d9:5488 with SMTP id da8-20020a05690c0d8800b0061ad2d95488mr6160180ywb.7.1714647670339; Thu, 02 May 2024 04:01:10 -0700 (PDT) Received: from sunil-laptop ([106.51.190.19]) by smtp.gmail.com with ESMTPSA id dg17-20020a05690c0fd100b0061adfb01cc2sm147882ywb.90.2024.05.02.04.01.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 May 2024 04:01:09 -0700 (PDT) Date: Thu, 2 May 2024 16:30:50 +0530 From: Sunil V L To: Andy Shevchenko Cc: Sudeep Holla , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, linux-serial@vger.kernel.org, acpica-devel@lists.linux.dev, Catalin Marinas , Will Deacon , Paul Walmsley , Albert Ou , "Rafael J . Wysocki" , Len Brown , Bjorn Helgaas , Anup Patel , Thomas Gleixner , Samuel Holland , Greg Kroah-Hartman , Jiri Slaby , Robert Moore , Conor Dooley , Andrew Jones , Marc Zyngier , Atish Kumar Patra , Andrei Warkentin , Haibo1 Xu , =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= Subject: Re: [PATCH v5 03/17] ACPI: bus: Add acpi_riscv_init function Message-ID: References: <20240501121742.1215792-1-sunilvl@ventanamicro.com> <20240501121742.1215792-4-sunilvl@ventanamicro.com> Precedence: bulk X-Mailing-List: acpica-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, May 02, 2024 at 01:19:55PM +0300, Andy Shevchenko wrote: > On Thu, May 02, 2024 at 11:12:43AM +0100, Sudeep Holla wrote: > > On Thu, May 02, 2024 at 03:32:25PM +0530, Sunil V L wrote: > > > On Thu, May 02, 2024 at 12:24:14PM +0300, Andy Shevchenko wrote: > > > > On Wed, May 01, 2024 at 05:47:28PM +0530, Sunil V L wrote: > > > > > Add a new function for RISC-V to do any architecture specific > > > > > initialization. This function will be used to create platform devices > > > > > like APLIC, PLIC, RISC-V IOMMU etc. This is similar to acpi_arm_init(). > > > > > > > > What is the special about this architecture that it requires a separate > > > > initialization that is _not_ going to be in other cases? > > > > Please, elaborate. > > > > > > > This init function will be used to create GSI mapping structures and in > > > future may be others like iommu. Like I mentioned, ARM already has > > > similar function acpi_arm_init(). So, it is not new right? > > > > Just to add: > > > > This is to initialise everything around all the arch specific tables > > which you will not have on any other architectures. We could execute > > on all architectures but the tables will never be found. The main point > > is why do we want to do that if we can optimise and skip on all other > > archs. > > You need to carefully write the commit messages. Some kind of the above > paragraphs has to be in there. > Sure, let me update the commit message on similar lines. Thanks, Sunil From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 637E7C4345F for ; Thu, 2 May 2024 11:01:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DkxqqXTJPkQMR5YFKDc9nZ7y+2NctYmkJQf7zhNt9Jk=; b=amCJIspFGE7gjb QrnPfY2TMWRhedvGP6g1EIlut95mwtcVoG+knPN84KyksdtWLsibtXKWkcV7GY1tQo5w5Go46gs45 hctB99K92KLf4MBaoQAGpfoow06HbyLked6QgDGqZfc7ssaQZo/Az7nemn+xXI0gnbM9DFiGRBbjC jjSer1m2CghXVgbKChdWO4s17AMq9MOxm7AuVW+/WgtBO2UcSOLKApDi9gcbSzgVcUz+YalGyF3wR MNlb3ah33jO9jVJtJimV6/1Xwl6wMnvhKkQ8/lR/8S0tEms1KIckXtVIB4vSavUq7E/iGKiWvYsGs 2kLV/kxxz+/c8EZXG8xg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2UBg-0000000CRPQ-3IKZ; Thu, 02 May 2024 11:01:16 +0000 Received: from mail-yw1-x112b.google.com ([2607:f8b0:4864:20::112b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2UBc-0000000CRNi-0Cg3 for linux-riscv@lists.infradead.org; Thu, 02 May 2024 11:01:14 +0000 Received: by mail-yw1-x112b.google.com with SMTP id 00721157ae682-61be74097cbso34325157b3.1 for ; Thu, 02 May 2024 04:01:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1714647670; x=1715252470; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yjTLbsaK8lFll8/qZ6Wbe+KOojRpVIeEGiQdgeTUV/M=; b=Zt/isbTb3NcGtq8lvlVhC3WUOi4/kC9+NhmcybBdkYLXPBOSLXq2aPEa/8uOCvs9bC Kcg/sleMU+3pZFsFsFkXdmJq+kwv9BtQxtPTctDLtfqUAFu5yAMA5zgPIIHobRcGfzsE 9i6exTlkfj2gHNV+sMv0rereK4h+kXufxw/B/1xcdlYVupmbBdRVGXuvGdj1g/h4l0PM R7Zmw0qTb+G/7A7PFF0xAFUxlO8ysEgBRuekI5DKXAXL0Hl3NlMceRCeGqg39A9PfK4+ nM8/g6Q5inD7iUKZqNe5RWG7nHrsvlFG3CZYPJheDiiGkXrEXXJNZbzkOoryfzwZEiQe N4Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714647670; x=1715252470; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yjTLbsaK8lFll8/qZ6Wbe+KOojRpVIeEGiQdgeTUV/M=; b=W1L9Iw6X22x1YDT23dY015D7//EhCxHE1UR2b0t9HlT0iOrcTwuIBKNGqLt115PNJT pDfwt8+vG8TMSCqAF7NdyEdRDe/3QggMaoU3zgl7TnjLSpTTozWQdV0Q5+jjLylgwyWW ogoD46EVP8mWWhE30grgX9gEFmGr6VpagJZn3rkhyyEObcmChI/Iqje/bJwIambU+jpw LvNWBX9WK2aFFTStiUh4JIcE0irwLtRtAdEj8FuxGxeIkSOhberWvRlMNDo6ei35quKm iJhlwdcQhDjX77WaESPpIgHsAas06G7b6TIXJ0PjiPH2cyumhv5HzLpdiC9c7efb6ICq uPiQ== X-Forwarded-Encrypted: i=1; AJvYcCXDSa28tjP9xEyUnKfIwaQXrPRKkDYQCOyEZRhDSdBrq85Y+LYOO8cfQcmQK9NVIzaylFHHtQHPLlhL63jv1FrM20CCD/Aiycu6HwdKMuKB X-Gm-Message-State: AOJu0Yz3Jh5NySYEIOTXVE1eFPeVvqnMZhiLc3Qk2oAPXrBKhtkilC5Z /yGzq0F3GIB57ROJOfQs9if3yfVoqCQ32zoPMOoy8waHzSUhhYkb7fCvECX2LUw= X-Google-Smtp-Source: AGHT+IHfkJrlGnon/mEX5fWtLywYkDj4de083FrQTvrfO2XC94gdhaKM/ttBrgT+XJ2VbkvvaIQxaw== X-Received: by 2002:a05:690c:d88:b0:61a:d2d9:5488 with SMTP id da8-20020a05690c0d8800b0061ad2d95488mr6160180ywb.7.1714647670339; Thu, 02 May 2024 04:01:10 -0700 (PDT) Received: from sunil-laptop ([106.51.190.19]) by smtp.gmail.com with ESMTPSA id dg17-20020a05690c0fd100b0061adfb01cc2sm147882ywb.90.2024.05.02.04.01.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 May 2024 04:01:09 -0700 (PDT) Date: Thu, 2 May 2024 16:30:50 +0530 From: Sunil V L To: Andy Shevchenko Cc: Sudeep Holla , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, linux-serial@vger.kernel.org, acpica-devel@lists.linux.dev, Catalin Marinas , Will Deacon , Paul Walmsley , Albert Ou , "Rafael J . Wysocki" , Len Brown , Bjorn Helgaas , Anup Patel , Thomas Gleixner , Samuel Holland , Greg Kroah-Hartman , Jiri Slaby , Robert Moore , Conor Dooley , Andrew Jones , Marc Zyngier , Atish Kumar Patra , Andrei Warkentin , Haibo1 Xu , =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= Subject: Re: [PATCH v5 03/17] ACPI: bus: Add acpi_riscv_init function Message-ID: References: <20240501121742.1215792-1-sunilvl@ventanamicro.com> <20240501121742.1215792-4-sunilvl@ventanamicro.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240502_040112_211810_C2FDFB1D X-CRM114-Status: GOOD ( 23.52 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Thu, May 02, 2024 at 01:19:55PM +0300, Andy Shevchenko wrote: > On Thu, May 02, 2024 at 11:12:43AM +0100, Sudeep Holla wrote: > > On Thu, May 02, 2024 at 03:32:25PM +0530, Sunil V L wrote: > > > On Thu, May 02, 2024 at 12:24:14PM +0300, Andy Shevchenko wrote: > > > > On Wed, May 01, 2024 at 05:47:28PM +0530, Sunil V L wrote: > > > > > Add a new function for RISC-V to do any architecture specific > > > > > initialization. This function will be used to create platform devices > > > > > like APLIC, PLIC, RISC-V IOMMU etc. This is similar to acpi_arm_init(). > > > > > > > > What is the special about this architecture that it requires a separate > > > > initialization that is _not_ going to be in other cases? > > > > Please, elaborate. > > > > > > > This init function will be used to create GSI mapping structures and in > > > future may be others like iommu. Like I mentioned, ARM already has > > > similar function acpi_arm_init(). So, it is not new right? > > > > Just to add: > > > > This is to initialise everything around all the arch specific tables > > which you will not have on any other architectures. We could execute > > on all architectures but the tables will never be found. The main point > > is why do we want to do that if we can optimise and skip on all other > > archs. > > You need to carefully write the commit messages. Some kind of the above > paragraphs has to be in there. > Sure, let me update the commit message on similar lines. Thanks, Sunil _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA073C04FFE for ; Thu, 2 May 2024 11:01:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NDNPzhAxz2nZQHEamCCoW6iFMOVzuwItJ32VP9gH2bc=; b=WdUmhT/XvGilmU Vy3sgKHSAMgwJwLtmNx9tZz4J0V5eLkrkkEAADXAd4cbEtnNHagyz7Jt12BRRPgmeTfGi16NKXXni q4uc3+SHC7YfV/gGxCLm6put5kt9EPtaVX9rtZOcFb5ZMDeJV7H5f2PmI7ONDyasunA/jdi3shbmD 2jdCQAP7IoLZNAJkhDA9yvs7yEgSqRc4zOzMIyDkdH7+0DCKTHGbnF9W9gu33iu/gWseE5l8tBN/z trUcX3oslI0nxk9IytW+Ys244+uQwkeGZMEZwYumcdyW0wbf0yCFJ3o8Ofk+JZEIxBrFWJnRVH8Lt XPZCjGhpi4eSZC1CsNCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2UBg-0000000CROu-0IZP; Thu, 02 May 2024 11:01:16 +0000 Received: from mail-yw1-x1136.google.com ([2607:f8b0:4864:20::1136]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2UBc-0000000CRNj-0DOc for linux-arm-kernel@lists.infradead.org; Thu, 02 May 2024 11:01:14 +0000 Received: by mail-yw1-x1136.google.com with SMTP id 00721157ae682-61af74a010aso77437287b3.0 for ; Thu, 02 May 2024 04:01:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1714647670; x=1715252470; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yjTLbsaK8lFll8/qZ6Wbe+KOojRpVIeEGiQdgeTUV/M=; b=Zt/isbTb3NcGtq8lvlVhC3WUOi4/kC9+NhmcybBdkYLXPBOSLXq2aPEa/8uOCvs9bC Kcg/sleMU+3pZFsFsFkXdmJq+kwv9BtQxtPTctDLtfqUAFu5yAMA5zgPIIHobRcGfzsE 9i6exTlkfj2gHNV+sMv0rereK4h+kXufxw/B/1xcdlYVupmbBdRVGXuvGdj1g/h4l0PM R7Zmw0qTb+G/7A7PFF0xAFUxlO8ysEgBRuekI5DKXAXL0Hl3NlMceRCeGqg39A9PfK4+ nM8/g6Q5inD7iUKZqNe5RWG7nHrsvlFG3CZYPJheDiiGkXrEXXJNZbzkOoryfzwZEiQe N4Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714647670; x=1715252470; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yjTLbsaK8lFll8/qZ6Wbe+KOojRpVIeEGiQdgeTUV/M=; b=qID9p3+OW7WAr30vePhkuh5p2QRZBSRKC2Mr1zttHT71z44zSb6OaFNzg+2cd7EaQA WIDTRwi0HeHC1LDoCW28epoAOMIZpHX4DT5Fk2mV1H+/dzdUn+n929eJV2M9xlLsqHcV 2NtJkyz2RyJAnIjamx+5Q2yxZhUAC7OaSf2nK4wJU/eTB00jTOMYOdCf0cppdeI5j+AC AdYO2H8CiE+Ag3EEbeNECGIWkoX6aj9hNj30V4kOlvJHWbPN/bzfNjOvQrMRhmKzeAVW IqBcdmeeIpIFrjVuFhO29uZBLWwY29edzLglOq3W4M/7o+UY48/OUj084A3cd+hJZn6T dEmA== X-Forwarded-Encrypted: i=1; AJvYcCVeoAvfz43OpRQbAnT840PDJKIC1S6LlGu9M4HI64YSPVR9lGRTB6Af8XGkBC1fND11Og4dZLU/6feO1JPR3KNsCo9fjDTS5EsZA2tyxZiI5NKeu6g= X-Gm-Message-State: AOJu0YyXsoZfoa8beBNN50tXTFzfiEZMO1LR/EeP6uX6iQQYu4v6wnQM hfLby23hSt/CnBMoYIHdl4TFsAfEzVcYlVw6O9E3822Gc0HeZ4ogCiAevgS4/Vw= X-Google-Smtp-Source: AGHT+IHfkJrlGnon/mEX5fWtLywYkDj4de083FrQTvrfO2XC94gdhaKM/ttBrgT+XJ2VbkvvaIQxaw== X-Received: by 2002:a05:690c:d88:b0:61a:d2d9:5488 with SMTP id da8-20020a05690c0d8800b0061ad2d95488mr6160180ywb.7.1714647670339; Thu, 02 May 2024 04:01:10 -0700 (PDT) Received: from sunil-laptop ([106.51.190.19]) by smtp.gmail.com with ESMTPSA id dg17-20020a05690c0fd100b0061adfb01cc2sm147882ywb.90.2024.05.02.04.01.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 May 2024 04:01:09 -0700 (PDT) Date: Thu, 2 May 2024 16:30:50 +0530 From: Sunil V L To: Andy Shevchenko Cc: Sudeep Holla , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, linux-serial@vger.kernel.org, acpica-devel@lists.linux.dev, Catalin Marinas , Will Deacon , Paul Walmsley , Albert Ou , "Rafael J . Wysocki" , Len Brown , Bjorn Helgaas , Anup Patel , Thomas Gleixner , Samuel Holland , Greg Kroah-Hartman , Jiri Slaby , Robert Moore , Conor Dooley , Andrew Jones , Marc Zyngier , Atish Kumar Patra , Andrei Warkentin , Haibo1 Xu , =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= Subject: Re: [PATCH v5 03/17] ACPI: bus: Add acpi_riscv_init function Message-ID: References: <20240501121742.1215792-1-sunilvl@ventanamicro.com> <20240501121742.1215792-4-sunilvl@ventanamicro.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240502_040112_253886_A1A59879 X-CRM114-Status: GOOD ( 24.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 02, 2024 at 01:19:55PM +0300, Andy Shevchenko wrote: > On Thu, May 02, 2024 at 11:12:43AM +0100, Sudeep Holla wrote: > > On Thu, May 02, 2024 at 03:32:25PM +0530, Sunil V L wrote: > > > On Thu, May 02, 2024 at 12:24:14PM +0300, Andy Shevchenko wrote: > > > > On Wed, May 01, 2024 at 05:47:28PM +0530, Sunil V L wrote: > > > > > Add a new function for RISC-V to do any architecture specific > > > > > initialization. This function will be used to create platform devices > > > > > like APLIC, PLIC, RISC-V IOMMU etc. This is similar to acpi_arm_init(). > > > > > > > > What is the special about this architecture that it requires a separate > > > > initialization that is _not_ going to be in other cases? > > > > Please, elaborate. > > > > > > > This init function will be used to create GSI mapping structures and in > > > future may be others like iommu. Like I mentioned, ARM already has > > > similar function acpi_arm_init(). So, it is not new right? > > > > Just to add: > > > > This is to initialise everything around all the arch specific tables > > which you will not have on any other architectures. We could execute > > on all architectures but the tables will never be found. The main point > > is why do we want to do that if we can optimise and skip on all other > > archs. > > You need to carefully write the commit messages. Some kind of the above > paragraphs has to be in there. > Sure, let me update the commit message on similar lines. Thanks, Sunil _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel