From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1s2Ybl-0005L9-Ge for mharc-qemu-trivial@gnu.org; Thu, 02 May 2024 11:44:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2Ybj-0005Kn-Tu for qemu-trivial@nongnu.org; Thu, 02 May 2024 11:44:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2Ybh-0000lz-1R for qemu-trivial@nongnu.org; Thu, 02 May 2024 11:44:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714664664; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=peDjk/pLP4R2ocU2Rnlh4PorQBhNai0jBnH3cyTZRYI=; b=J2gYa3MsPe+3RllJlIDmU4O2qA0YLSZmEmFGA+zzTXcQ3j89n6UBSfXCSdKLbJcq8tuMaf d7CT/kxrwOakL1bdR4tFoBkdVao6+oHhD4cWUVqTeXiK0qdMvNFp4luo0Z73QKegojpBVr TUbuATYUTgLZwzxYq6A4qy1EcP9J+qs= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-587-5zMvKy6pOGmy_oW325KB3w-1; Thu, 02 May 2024 11:44:22 -0400 X-MC-Unique: 5zMvKy6pOGmy_oW325KB3w-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5147D8002EA; Thu, 2 May 2024 15:44:22 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.138]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 999051121306; Thu, 2 May 2024 15:44:21 +0000 (UTC) Date: Thu, 2 May 2024 16:44:19 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Paolo Bonzini Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org, Roman Kiryanov Subject: Re: [PATCH v2] bitmap: Use g_try_new0/g_renew Message-ID: Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20240502152242.101181-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240502152242.101181-1-pbonzini@redhat.com> User-Agent: Mutt/2.2.12 (2023-09-09) X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.476, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 May 2024 15:44:28 -0000 On Thu, May 02, 2024 at 05:22:42PM +0200, Paolo Bonzini wrote: > Avoids an explicit use of sizeof(). The GLib allocation macros > ensure that the multiplication by the size of the element > uses the right type and does not overflow. > > While at it, change bitmap_new() to use g_new0 directly. Its current > impl of calling bitmap_try_new() followed by a plain abort() has > worse diagnostics than g_new0, which uses g_error to report the actual > allocation size that failed. > > Cc: qemu-trivial@nongnu.org > Cc: Roman Kiryanov > Cc: Daniel Berrange > Signed-off-by: Paolo Bonzini > --- > include/qemu/bitmap.h | 19 ++++++++----------- > 1 file changed, 8 insertions(+), 11 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|