All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: changqing.li@eng.windriver.com
Cc: meta-virtualization@lists.yoctoproject.org
Subject: Re: [master][scarthgap][meta-virtualization][PATCH] kubernetes: skip textrel QA warning
Date: Thu, 2 May 2024 18:00:53 +0000	[thread overview]
Message-ID: <ZjPU1aQrRd2rs7hR@gmail.com> (raw)
In-Reply-To: <20240430061733.3518484-1-changqing.li@windriver.com>

merged.

Bruce

In message: [master][scarthgap][meta-virtualization][PATCH] kubernetes: skip textrel QA warning
on 30/04/2024 Changqing Li via lists.yoctoproject.org wrote:

> From: Changqing Li <changqing.li@windriver.com>
> 
> -buildmode=pie need cgo is enabled, but for kubernetes, some build
> targets are static, and cgo is disable in build script directly, refer
> [1]. If we add -buildmode=pie by default, will cause these static target
> build failed with error "-buildmode=pie requires external (cgo) linking,
> but cgo is not enabled".
> 
> This warning is acceptable, so just skip it.
> 
> [1] https://github.com/kubernetes/kubernetes/blob/master/hack/lib/golang.sh#L811
> 
> Signed-off-by: Changqing Li <changqing.li@windriver.com>
> ---
>  recipes-containers/kubernetes/kubernetes_git.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/recipes-containers/kubernetes/kubernetes_git.bb b/recipes-containers/kubernetes/kubernetes_git.bb
> index d7874dfa..044175eb 100644
> --- a/recipes-containers/kubernetes/kubernetes_git.bb
> +++ b/recipes-containers/kubernetes/kubernetes_git.bb
> @@ -126,7 +126,7 @@ PACKAGES =+ "kubeadm kubectl kubelet kube-proxy ${PN}-misc ${PN}-host"
>  ALLOW_EMPTY:${PN} = "1"
>  INSANE_SKIP:${PN} += "ldflags already-stripped"
>  INSANE_SKIP:${PN}-misc += "ldflags already-stripped textrel"
> -INSANE_SKIP:kubelet += "ldflags already-stripped"
> +INSANE_SKIP:${MLPREFIX}kubelet += "ldflags already-stripped textrel"
>  
>  # Note: we are explicitly *not* adding docker to the rdepends, since we allow
>  #       backends like cri-o to be used.
> -- 
> 2.25.1
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#8706): https://lists.yoctoproject.org/g/meta-virtualization/message/8706
> Mute This Topic: https://lists.yoctoproject.org/mt/105816435/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 



  reply	other threads:[~2024-05-02 18:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-30  6:17 [master][scarthgap][meta-virtualization][PATCH] kubernetes: skip textrel QA warning changqing.li
2024-05-02 18:00 ` Bruce Ashfield [this message]
2025-11-14  5:50   ` nvhieudt11
2025-11-19 23:39     ` Bruce Ashfield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZjPU1aQrRd2rs7hR@gmail.com \
    --to=bruce.ashfield@gmail.com \
    --cc=changqing.li@eng.windriver.com \
    --cc=meta-virtualization@lists.yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.