From: Luis Chamberlain <mcgrof@kernel.org>
To: Allen <allen.lkml@gmail.com>
Cc: Kees Cook <keescook@chromium.org>,
Allen Pais <apais@linux.microsoft.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, viro@zeniv.linux.org.uk, brauner@kernel.org,
jack@suse.cz, ebiederm@xmission.com, j.granados@samsung.com
Subject: Re: [PATCH v2] fs/coredump: Enable dynamic configuration of max file note size
Date: Thu, 2 May 2024 14:35:14 -0700 [thread overview]
Message-ID: <ZjQHEpRW7q686kU7@bombadil.infradead.org> (raw)
In-Reply-To: <CAOMdWSJzXiqB5tusdKaavJFTaKC-qyArT0ssRHVY-fvZVKJW+Q@mail.gmail.com>
On Thu, May 02, 2024 at 01:03:52PM -0700, Allen wrote:
> +int proc_core_file_note_size_max(struct ctl_table *table, int write,
> void __user *buffer, size_t *lenp, loff_t *ppos) {
> + int error = proc_douintvec(table, write, buffer, lenp, ppos);
> + if (write && (core_file_note_size_max < MAX_FILE_NOTE_SIZE ||
> core_file_note_size_max > MAX_ALLOWED_NOTE_SIZE))
> + core_file_note_size_max = MAX_FILE_NOTE_SIZE; // Revert to
> default if out of bounds
> + return error;
> +}
There's already a proc helper which let's you set min / max.
Luis
next prev parent reply other threads:[~2024-05-02 21:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 14:59 [PATCH v2] fs/coredump: Enable dynamic configuration of max file note size Allen Pais
2024-05-02 17:50 ` Kees Cook
2024-05-02 20:03 ` Allen
2024-05-02 21:35 ` Luis Chamberlain [this message]
2024-05-02 22:47 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjQHEpRW7q686kU7@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=allen.lkml@gmail.com \
--cc=apais@linux.microsoft.com \
--cc=brauner@kernel.org \
--cc=ebiederm@xmission.com \
--cc=j.granados@samsung.com \
--cc=jack@suse.cz \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.