From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] gitlab-ci: adjust msys2-64bit to be able to run qtest
Date: Fri, 3 May 2024 13:29:08 +0100 [thread overview]
Message-ID: <ZjTYlDXkLXNtGgGR@redhat.com> (raw)
In-Reply-To: <20240503121509.219567-1-pbonzini@redhat.com>
On Fri, May 03, 2024 at 02:15:09PM +0200, Paolo Bonzini wrote:
> sparc-softmmu is able to run a subset of qtests when compiled --without-default-devices,
> so use it instead of x86_64-softmmu for the msys2 run.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> .gitlab-ci.d/windows.yml | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/.gitlab-ci.d/windows.yml b/.gitlab-ci.d/windows.yml
> index 94834269ec7..d26dbdd0c0d 100644
> --- a/.gitlab-ci.d/windows.yml
> +++ b/.gitlab-ci.d/windows.yml
> @@ -24,10 +24,7 @@ msys2-64bit:
> # changed to compile QEMU with the --without-default-devices switch
> # for this job, because otherwise the build could not complete within
> # the project timeout.
> - CONFIGURE_ARGS: --target-list=x86_64-softmmu --without-default-devices -Ddebug=false -Doptimization=0
> - # qTests don't run successfully with "--without-default-devices",
> - # so let's exclude the qtests from CI for now.
> - TEST_ARGS: --no-suite qtest
> + CONFIGURE_ARGS: --target-list=sparc-softmmu --without-default-devices -Ddebug=false -Doptimization=0
We have compile coverage of x86_64-softmmu on the cross-win64 mingw
job. So we're not loosing any compile coverage in aggregate with
this change, in fact we improve it by compiling sparc here.
The msys2-64bit job currently takes 50mins wallclock just to compile
and run unit tests though, which is quite long already.
What's the new running time when you enable qtest too ?
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2024-05-03 12:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 12:15 [PATCH] gitlab-ci: adjust msys2-64bit to be able to run qtest Paolo Bonzini
2024-05-03 12:29 ` Daniel P. Berrangé [this message]
2024-05-03 13:37 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjTYlDXkLXNtGgGR@redhat.com \
--to=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.