From: Tycho Andersen <tycho@tycho.pizza>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Kees Cook <keescook@chromium.org>,
Alexander Popov <alex.popov@linux.com>,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, Luis Chamberlain <mcgrof@kernel.org>,
Joel Granados <j.granados@samsung.com>
Subject: Re: [PATCH] stackleak: don't modify ctl_table argument
Date: Fri, 3 May 2024 07:58:16 -0600 [thread overview]
Message-ID: <ZjTteMPELxCZTUSw@tycho.pizza> (raw)
In-Reply-To: <20240503-sysctl-const-stackleak-v1-1-603fecb19170@weissschuh.net>
On Fri, May 03, 2024 at 03:44:09PM +0200, Thomas Weißschuh wrote:
> Sysctl handlers are not supposed to modify the ctl_table passed to them.
> Adapt the logic to work with a temporary
> variable, similar to how it is done in other parts of the kernel.
>
> This is also a prerequisite to enforce the immutability of the argument
> through the callbacks prototy.
>
> Fixes: 964c9dff0091 ("stackleak: Allow runtime disabling of kernel stack erasing")
Reviewed-by: Tycho Andersen <tycho@tycho.pizza>
Tycho
next prev parent reply other threads:[~2024-05-03 13:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 13:44 [PATCH] stackleak: don't modify ctl_table argument Thomas Weißschuh
2024-05-03 13:58 ` Tycho Andersen [this message]
2024-05-03 17:55 ` Kees Cook
2024-05-03 18:24 ` linux
2024-05-03 19:31 ` Kees Cook
2024-05-03 19:35 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjTteMPELxCZTUSw@tycho.pizza \
--to=tycho@tycho.pizza \
--cc=alex.popov@linux.com \
--cc=j.granados@samsung.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=mcgrof@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.