From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B23D6C4345F for ; Mon, 6 May 2024 08:51:36 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 814A740716; Mon, 6 May 2024 08:51:36 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id KC42WpnOcLFO; Mon, 6 May 2024 08:51:34 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 482B840580 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1714985494; bh=2QRgH5VnpX0RwusZ17k7CmbkY8dMM97q2eTbNB/OxcE=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=YPWhkJJBOAC031kHFXTg4dePNxC8fuLkcokfLcQwMSiAUCx2YSjDOMctzRpgKhMUQ 5q+BQpt3jLuWcGmw8g2JZb+4iLa5SZ7TuMS0nEtvt0c4glZiKwPzvUScrkwT50ZG1w sKTM07qeUE6jRp6JLa1hmDCs9p5ggWPm5UB+Z0dc+f77DIrWP6n/ER7Zl2mfbw3ze+ 5wZxFn2NaZhi46PVUQ0PGUYopo/p5QcIeetAfB5kseMxv7Cn1zgteQNzCinxdQNIaf r6972wOeWyNGzz0eTQU9KhDXkR/dYqNX1ZKpQEX+VUD1lpg+yRFN1yxVUL22yuD1FI cfF8Xvi6loPcg== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 482B840580; Mon, 6 May 2024 08:51:34 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 30CEB1BF38A for ; Mon, 6 May 2024 08:51:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 1C713606A6 for ; Mon, 6 May 2024 08:51:32 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id u2CcefjEfmQq for ; Mon, 6 May 2024 08:51:31 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=198.175.65.12; helo=mgamail.intel.com; envelope-from=michal.swiatkowski@linux.intel.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 5FCCC605E9 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 5FCCC605E9 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by smtp3.osuosl.org (Postfix) with ESMTPS id 5FCCC605E9 for ; Mon, 6 May 2024 08:51:31 +0000 (UTC) X-CSE-ConnectionGUID: dXty7dbbTaK4sKlVJSHjAg== X-CSE-MsgGUID: txiPJiZPQ7OxkA6nGCL7qQ== X-IronPort-AV: E=McAfee;i="6600,9927,11064"; a="22130423" X-IronPort-AV: E=Sophos;i="6.07,257,1708416000"; d="scan'208";a="22130423" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2024 01:51:31 -0700 X-CSE-ConnectionGUID: EB7Wb8sjSPqQumpTj1FBDw== X-CSE-MsgGUID: yR1fEpw9T4GvwxMk6MSwVQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,257,1708416000"; d="scan'208";a="32771649" Received: from unknown (HELO mev-dev) ([10.237.112.144]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2024 01:51:28 -0700 Date: Mon, 6 May 2024 10:50:53 +0200 From: Michal Swiatkowski To: Tony Nguyen Message-ID: References: <20240419171336.11617-1-michal.swiatkowski@linux.intel.com> <20240419171336.11617-4-michal.swiatkowski@linux.intel.com> <7003fe5e-4bb9-8335-6d3f-9edab0aa3570@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7003fe5e-4bb9-8335-6d3f-9edab0aa3570@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714985491; x=1746521491; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=n077hml70tQrzUxJl7tu8jfzK0VqIgZ/7Ew1bmK5Y+A=; b=IfpYWCxf8fVWnlkoUT+zAJnYwmXH6FUq8fJEdaVbXZpScHXaHQF/g9wD xmZd6PXMXaKGzKWE/xc3E+zgukzEpHodnoqEN9dPhGZ0SOzKLlXhViv0j Z0PoLhoSdUP/i99pNmaD6vXYObWxDopcAp+nW57APX9s9DmbtUOHaMnN8 8UXfJqE7cnLa3IbenSiG5Hg2h+EasAQsnpIPNH0SfsLkIORMPyrRF75LE Ixn5Mhqhbl6U0LEzW/4g1AZrzVfvZZ4pGhl197TseUK/EINXkPpRWDhgo voaxMm7Ho0m5vuP2q8+4duMNUEQQJMAgKYPqX8gZRYL+hgHkxw31EQSzN A==; X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=none (p=none dis=none) header.from=linux.intel.com X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=IfpYWCxf Subject: Re: [Intel-wired-lan] [iwl-next v1 3/4] ice: move VSI configuration outside repr setup X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: shayd@nvidia.com, maciej.fijalkowski@intel.com, mateusz.polchlopek@intel.com, netdev@vger.kernel.org, jiri@nvidia.com, michal.kubiak@intel.com, intel-wired-lan@lists.osuosl.org, pio.raczynski@gmail.com, sridhar.samudrala@intel.com, jacob.e.keller@intel.com, wojciech.drewek@intel.com, przemyslaw.kitszel@intel.com Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Wed, Apr 24, 2024 at 02:08:11PM -0700, Tony Nguyen wrote: > > > On 4/19/2024 10:13 AM, Michal Swiatkowski wrote: > > > +/** > > + * ice_eswitch_cfg_vsi - configure VSI to work in slow-path > > + * @vsi: VSI structure of representee > > + * @mac: representee MAC > > Can you fix the kdoc for this? > > > drivers/net/ethernet/intel/ice/ice_eswitch.c:140: warning: No description > found for return value of 'ice_eswitch_cfg_vsi' > > Thanks, > Tony > I sent v2, sorry for late response, I was OOO. Thanks, Michal > > + */ > > +int ice_eswitch_cfg_vsi(struct ice_vsi *vsi, const u8 *mac) > > +{ > > + int err; > > + From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5976C1420B9 for ; Mon, 6 May 2024 08:51:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714985493; cv=none; b=eW/lqU0uzGGgpC7Clw0Xow3Ck/wQVFoyNUCeVYrzs3kc86xSCsnq0C8Nmsv/+UrL8NhFcYKjqrj0yeA7CLVpWQzkGM03imu5TwhtcGWN270LcIiHwehcprqfKA9lOKz4Bk/xYyr2yxBSw5jeCANlzynGKQrTA7ab1Pt9zIPpOCs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714985493; c=relaxed/simple; bh=n077hml70tQrzUxJl7tu8jfzK0VqIgZ/7Ew1bmK5Y+A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kublFrc8zMrz8tK5AqsvJ7hMsn+pRvi6AI/qeeQSAMmUySnOIHtbOh1uf0mz+/PGXSi+2MHl6Xb8OtmiWKoGHnAIGD+ELpI46RPVu2r7PeT2kYkZ8jm+ft1XUbtm3FqVsMc+8SzFFAkqal7gRUi3PybbvIYiH2CGcG7WkAEXTug= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Hsj2PDJ4; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Hsj2PDJ4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714985492; x=1746521492; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=n077hml70tQrzUxJl7tu8jfzK0VqIgZ/7Ew1bmK5Y+A=; b=Hsj2PDJ4z1FGgp+wNnceSzkdG0P0+UTkoBGTX04zODnF85miRCb7Nhsv 8BHATxI/Ud7IkexnU3RHn+e9x/9k0QMzkOTvtyEY9CmX8uylvUuL7HuA8 q1tKSQekcU4FU5f0uuQLQ8SN0/QhIAKaB6Mpg4mkqin/LxvFcQfX9vDsS e7GYTaac7YryJibW78MWJa6+q0VqRFrq4ssuiNRO+Wb28ZhhYZqafAPtN Nxy+hC94aDs+uq6BPB7Fwv2gowD/FDUvlR9nWJ9E4UJxevyCLLmssmuYN HS6nlv5oRhR7p/e4MgCoIMsBMrN7JaeIRv6QLp6BgrYh/bK/kdGvYC5K8 A==; X-CSE-ConnectionGUID: GK/4xz7FSWyfWT9kiTCoXg== X-CSE-MsgGUID: bAKseya6QyGX56zSbtRCFA== X-IronPort-AV: E=McAfee;i="6600,9927,11064"; a="22130421" X-IronPort-AV: E=Sophos;i="6.07,257,1708416000"; d="scan'208";a="22130421" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2024 01:51:31 -0700 X-CSE-ConnectionGUID: EB7Wb8sjSPqQumpTj1FBDw== X-CSE-MsgGUID: yR1fEpw9T4GvwxMk6MSwVQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,257,1708416000"; d="scan'208";a="32771649" Received: from unknown (HELO mev-dev) ([10.237.112.144]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2024 01:51:28 -0700 Date: Mon, 6 May 2024 10:50:53 +0200 From: Michal Swiatkowski To: Tony Nguyen Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, jacob.e.keller@intel.com, michal.kubiak@intel.com, maciej.fijalkowski@intel.com, sridhar.samudrala@intel.com, przemyslaw.kitszel@intel.com, wojciech.drewek@intel.com, pio.raczynski@gmail.com, jiri@nvidia.com, mateusz.polchlopek@intel.com, shayd@nvidia.com Subject: Re: [iwl-next v1 3/4] ice: move VSI configuration outside repr setup Message-ID: References: <20240419171336.11617-1-michal.swiatkowski@linux.intel.com> <20240419171336.11617-4-michal.swiatkowski@linux.intel.com> <7003fe5e-4bb9-8335-6d3f-9edab0aa3570@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7003fe5e-4bb9-8335-6d3f-9edab0aa3570@intel.com> On Wed, Apr 24, 2024 at 02:08:11PM -0700, Tony Nguyen wrote: > > > On 4/19/2024 10:13 AM, Michal Swiatkowski wrote: > > > +/** > > + * ice_eswitch_cfg_vsi - configure VSI to work in slow-path > > + * @vsi: VSI structure of representee > > + * @mac: representee MAC > > Can you fix the kdoc for this? > > > drivers/net/ethernet/intel/ice/ice_eswitch.c:140: warning: No description > found for return value of 'ice_eswitch_cfg_vsi' > > Thanks, > Tony > I sent v2, sorry for late response, I was OOO. Thanks, Michal > > + */ > > +int ice_eswitch_cfg_vsi(struct ice_vsi *vsi, const u8 *mac) > > +{ > > + int err; > > +