From: Benjamin Marzinski <bmarzins@redhat.com>
To: Joel Colledge <joel.colledge@linbit.com>
Cc: Christian Loehle <christian.loehle@arm.com>,
dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] dm-delay: fix hung task introduced by kthread mode
Date: Mon, 6 May 2024 17:10:59 -0400 [thread overview]
Message-ID: <ZjlHY02it0wBL0TB@redhat.com> (raw)
In-Reply-To: <20240506072523.399767-2-joel.colledge@linbit.com>
On Mon, May 06, 2024 at 09:25:23AM +0200, Joel Colledge wrote:
> If the worker thread is not woken due to a bio, then it is not woken at
> all. This causes the hung task check to trigger. This occurs, for
> instance, when no bios are submitted. Also when a delay of 0 is
> configured, delay_bio() returns without waking the worker.
>
> Prevent the hung task check from triggering by creating the thread with
> kthread_run() instead of using kthread_create() directly.
>
> Fixes: 70bbeb29fab0 ("dm delay: for short delays, use kthread instead of timers and wq")
> Signed-off-by: Joel Colledge <joel.colledge@linbit.com>
Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>
prev parent reply other threads:[~2024-05-06 21:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 7:25 [PATCH v2 0/1] dm-delay: fix hung task issue Joel Colledge
2024-05-06 7:25 ` [PATCH v2 1/1] dm-delay: fix hung task introduced by kthread mode Joel Colledge
2024-05-06 21:10 ` Benjamin Marzinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjlHY02it0wBL0TB@redhat.com \
--to=bmarzins@redhat.com \
--cc=christian.loehle@arm.com \
--cc=dm-devel@lists.linux.dev \
--cc=joel.colledge@linbit.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.