From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Simon Ser <contact@emersion.fr>
Cc: dri-devel@lists.freedesktop.org,
Harry Wentland <harry.wentland@amd.com>,
Joshua Ashton <joshua@froggi.es>,
Alex Deucher <alexander.deucher@amd.com>
Subject: Re: [PATCH] drm/uapi: Move drm_color_ctm_3x4 out from drm_mode.h
Date: Tue, 7 May 2024 14:49:23 +0300 [thread overview]
Message-ID: <ZjoVQxGKAZlvxIDW@intel.com> (raw)
In-Reply-To: <mB2sQaqlBgdsUPAXqWyd03aZAS8h1JKTff3_efNWi5uTEnwBWzIuRSEL72CUCohJ06bEzN9n5jvVzB4rApwfSB1fxwQWDBri4RZ9oSujNlg=@emersion.fr>
On Wed, Apr 24, 2024 at 03:48:24PM +0000, Simon Ser wrote:
> On Monday, April 22nd, 2024 at 10:58, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
>
> > drm_color_ctm_3x4 is some undocumented amgdpu private
> > uapi and thus has no business being in drm_mode.h.
> > At least move it to some amdgpu specific header, albeit
> > with the wrong namespace as maybe something somewhere
> > is using this already?
>
> If something somewhere is using this already, I don't think the name
> matters? In other words, if there is a user, such user would be broken
> when moving the declaration anyways, so it shouldn't be more risky to
> do the rename as well?
I suppose. Not something I want to have to think about though.
I've pushed this to drm-misc-next with Harry's rb (thanks).
>
> I'm holding off the libdrm header update until we find a solution.
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2024-05-07 11:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 8:58 [PATCH] drm/uapi: Move drm_color_ctm_3x4 out from drm_mode.h Ville Syrjala
2024-04-24 15:48 ` Simon Ser
2024-05-07 11:49 ` Ville Syrjälä [this message]
2024-04-30 18:03 ` Harry Wentland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjoVQxGKAZlvxIDW@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=alexander.deucher@amd.com \
--cc=contact@emersion.fr \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=joshua@froggi.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.