From: Tao Su <tao1.su@linux.intel.com>
To: Edward Liaw <edliaw@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-sound@vger.kernel.org, kvm@vger.kernel.org,
netdev@vger.kernel.org, linux-rtc@vger.kernel.org,
linux-sgx@vger.kernel.org, ivan.orlov0322@gmail.com,
broonie@kernel.org, perex@perex.cz, tiwai@suse.com,
shuah@kernel.org, seanjc@google.com, pbonzini@redhat.com,
bongsu.jeon@samsung.com, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com,
alexandre.belloni@bootlin.com, jarkko@kernel.org,
dave.hansen@linux.intel.com
Subject: Re: [PATCH] selftests: Add _GNU_SOURCE definition when including kselftest_harness.h
Date: Thu, 9 May 2024 13:10:23 +0800 [thread overview]
Message-ID: <Zjxav6li45yXMNTB@linux.bj.intel.com> (raw)
In-Reply-To: <CAG4es9Xdo8fBEpZLWGFHodi7=+ZYLvrE-kQYt=YfCeEHWYxaXg@mail.gmail.com>
On Wed, May 08, 2024 at 10:57:47AM -0700, Edward Liaw wrote:
> On Wed, May 8, 2024 at 7:00 AM Jakub Kicinski <kuba@kernel.org> wrote:
> >
> > On Wed, 8 May 2024 10:55:05 +0800 Tao Su wrote:
> > > Back to commit 38c957f07038, I don't see any advantage in using LINE_MAX.
> > > Can we use a fixed value instead of LINE_MAX? E.g., 1024, 2048. Then we
> > > just need to revert commit 809216233555.
> >
> > SGTM, FWIW. The print is printing a test summary line, printing more
> > than 1k seems rather unreasonable. Other facilities, like TH_LOG(),
> > should be used for displaying longer info.
>
> I also submitted some patches to fix the _GNU_SOURCE issues here:
> https://lore.kernel.org/linux-kselftest/20240507214254.2787305-1-edliaw@google.com/
>
> I'm fine with this approach. It's aligned to what Sean suggested
> there, since it's causing a lot of troubles for the release cycle.
Thanks, I will submit patches with this approach soon.
next prev parent reply other threads:[~2024-05-09 5:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 6:35 [PATCH] selftests: Add _GNU_SOURCE definition when including kselftest_harness.h Tao Su
2024-05-07 17:06 ` Andrew Morton
2024-05-08 2:55 ` Tao Su
2024-05-08 14:00 ` Jakub Kicinski
2024-05-08 17:57 ` Edward Liaw
2024-05-09 5:10 ` Tao Su [this message]
2024-05-09 5:08 ` Tao Su
2024-05-09 18:27 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zjxav6li45yXMNTB@linux.bj.intel.com \
--to=tao1.su@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=alexandre.belloni@bootlin.com \
--cc=bongsu.jeon@samsung.com \
--cc=broonie@kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=edliaw@google.com \
--cc=edumazet@google.com \
--cc=ivan.orlov0322@gmail.com \
--cc=jarkko@kernel.org \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pbonzini@redhat.com \
--cc=perex@perex.cz \
--cc=seanjc@google.com \
--cc=shuah@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.