Re: [PATCH 06/10] drm/i915: add LNL PCI IDs

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Wed, May 22, 2024 at 08:33:43PM +0300, Jani Nikula wrote:
> Although not supported by i915 core, the display code needs to know the
> LNL PCI IDs.

perhaps we should add a comment in the header near the IDs?

> 
> Long term, xe and i915 should probably share the file defining PCI IDs.

although it might get harder to distinguish the intersection, this
might be a good idea indeed.

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  include/drm/i915_pciids.h | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> index 3e39d644ebaa..7ae7ee11ef38 100644
> --- a/include/drm/i915_pciids.h
> +++ b/include/drm/i915_pciids.h
> @@ -783,4 +783,10 @@
>  	MACRO__(0x7DD1, ## __VA_ARGS__), \
>  	MACRO__(0x7DD5, ## __VA_ARGS__)
>  
> +/* LNL */
> +#define INTEL_LNL_IDS(MACRO__, ...) \
> +	MACRO__(0x6420, ## __VA_ARGS__), \
> +	MACRO__(0x64A0, ## __VA_ARGS__), \
> +	MACRO__(0x64B0, ## __VA_ARGS__)
> +
>  #endif /* _I915_PCIIDS_H */
> -- 
> 2.39.2
>