From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Nechita, Ramona" <Ramona.Nechita@analog.com>
Cc: "Nuno Sá" <noname.nuno@gmail.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"Jonathan Cameron" <jic23@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Hennerich, Michael" <Michael.Hennerich@analog.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Sa, Nuno" <Nuno.Sa@analog.com>,
"Marius Cristea" <marius.cristea@microchip.com>,
"Schmitt, Marcelo" <Marcelo.Schmitt@analog.com>,
"Maksim Kiselev" <bigunclemax@gmail.com>,
"Ivan Mikhaylov" <fr0st61te@gmail.com>,
"Marcus Folkesson" <marcus.folkesson@gmail.com>,
"Liam Beguin" <liambeguin@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers: iio: adc: add support for ad777x family
Date: Wed, 22 May 2024 18:07:54 +0300 [thread overview]
Message-ID: <Zk4KSlZ7NFgYx2Co@smile.fi.intel.com> (raw)
In-Reply-To: <SN6PR03MB4320549F56148C13C4BDBBA1F3EB2@SN6PR03MB4320.namprd03.prod.outlook.com>
On Wed, May 22, 2024 at 03:01:52PM +0000, Nechita, Ramona wrote:
> Hello Nuno,
>
> I apologize, I accidentally submitted the updated version that I used for the
> project, instead of the one without axi. I will fix it and resend the patch
> asap.
First of all, do not top-post!
Second, don't do ASAP, take your time, read the comments given for this version
and address the same / similar issues in any code you are possessing before
sending.
> -----Original Message-----
> From: Nuno Sá <noname.nuno@gmail.com>
> Sent: Wednesday, May 22, 2024 5:36 PM
> On Wed, 2024-05-22 at 14:59 +0300, ranechita wrote:
> > Added support for ad7770,ad7771,ad7779 ADCs. The data is streamed only
> > on the spi-mode, without using the data lines.
> Is this even compiling? This is definitely not code to be upstreamed since it
> relies on the our out-of-tree/legacy driver for the adi-axi-adc. You need to
> convert this to use the IIO backend framework (adding new interfaces if
> needed).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-05-22 15:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-22 11:59 [PATCH] drivers: iio: adc: add support for ad777x family ranechita
2024-05-22 14:18 ` Andy Shevchenko
2024-05-29 15:01 ` Nechita, Ramona
2024-05-29 15:11 ` Andy Shevchenko
2024-05-29 15:45 ` Nechita, Ramona
2024-05-30 15:07 ` Andy Shevchenko
2024-05-22 14:35 ` Nuno Sá
2024-05-22 15:01 ` Nechita, Ramona
2024-05-22 15:07 ` Andy Shevchenko [this message]
2024-05-22 22:40 ` kernel test robot
2024-05-24 7:17 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zk4KSlZ7NFgYx2Co@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Marcelo.Schmitt@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=Nuno.Sa@analog.com \
--cc=Ramona.Nechita@analog.com \
--cc=bigunclemax@gmail.com \
--cc=broonie@kernel.org \
--cc=fr0st61te@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=liambeguin@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcus.folkesson@gmail.com \
--cc=marius.cristea@microchip.com \
--cc=noname.nuno@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.