From: Andy Shevchenko <andy@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
platform-driver-x86@vger.kernel.org,
"Gregor Riepl" <onitake@gmail.com>
Subject: Re: [PATCH] platform/x86: touchscreen_dmi: Add support for setting touchscreen properties from cmdline
Date: Wed, 22 May 2024 20:20:47 +0300 [thread overview]
Message-ID: <Zk4pbyKX7yDNPjgf@smile.fi.intel.com> (raw)
In-Reply-To: <Zk4pC0dkmTEcS_qA@smile.fi.intel.com>
On Wed, May 22, 2024 at 08:19:07PM +0300, Andy Shevchenko wrote:
> On Wed, May 22, 2024 at 06:48:07PM +0200, Hans de Goede wrote:
...
> > + ret = kstrtou32(value, 10, &u32val);
One more thing, why to limit to the decimal only?
Should be up to user to choose. And some properties (now or in the future)
actually might benefit from being able to be entered in hexadecimal form.
> > + if (ret)
> > + return ret;
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-05-22 17:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-22 16:48 [PATCH] platform/x86: touchscreen_dmi: Add support for setting touchscreen properties from cmdline Hans de Goede
2024-05-22 17:19 ` Andy Shevchenko
2024-05-22 17:20 ` Andy Shevchenko [this message]
2024-05-22 18:40 ` Hans de Goede
2024-05-22 19:32 ` Andy Shevchenko
2024-05-22 19:34 ` Andy Shevchenko
2024-05-23 8:47 ` Hans de Goede
2024-05-25 14:07 ` Andy Shevchenko
2024-05-25 17:41 ` Gregor Riepl
2024-05-27 13:44 ` Andy Shevchenko
2024-05-22 19:01 ` Randy Dunlap
2024-05-23 9:48 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zk4pbyKX7yDNPjgf@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=onitake@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.