From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Rob Barnes <robbarnes@google.com>
Cc: chrome-platform@lists.linux.dev, gwendal@chromium.org,
groweck@chromium.org
Subject: Re: [PATCH] drivers/cros_ec: Make log polling period a parameter
Date: Thu, 23 May 2024 09:30:02 +0800 [thread overview]
Message-ID: <Zk6cGhB99cktsCsy@google.com> (raw)
In-Reply-To: <20240507155809.525701-1-robbarnes@google.com>
On Tue, May 07, 2024 at 03:58:09PM +0000, Rob Barnes wrote:
> Make EC log polling period a module parameter. This allows the polling
> period to be set via the kernel command line. Keeping the default at
> the current 10 second period. The optimal polling period will differ by
> board.
If you get chance for sending next version, please use title prefix
"platform/chrome: cros_ec_debugfs:".
> @@ -118,7 +122,7 @@ static void cros_ec_console_log_work(struct work_struct *__work)
>
> resched:
> schedule_delayed_work(&debug_info->log_poll_work,
> - msecs_to_jiffies(LOG_POLL_SEC * 1000));
> + msecs_to_jiffies(log_poll_period_ms));
If the value is set to 0, it works like an infinite loop on
cros_ec_console_log_work(). Is it expected?
next prev parent reply other threads:[~2024-05-23 1:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 15:58 [PATCH] drivers/cros_ec: Make log polling period a parameter Rob Barnes
2024-05-23 1:30 ` Tzung-Bi Shih [this message]
2024-05-29 0:08 ` Rob Barnes
2024-05-29 5:20 ` patchwork-bot+chrome-platform
2024-05-29 5:20 ` patchwork-bot+chrome-platform
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zk6cGhB99cktsCsy@google.com \
--to=tzungbi@kernel.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groweck@chromium.org \
--cc=gwendal@chromium.org \
--cc=robbarnes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.