From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A2871C69D; Sun, 12 May 2024 10:26:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715509592; cv=none; b=kf9IIqe3h+4hC2pWpQ1RiWGB0BsLuHDWC3bIUoGGIbBQthZiH65Q8K10tHbLJh1ShGH615kUWY64AwDOl/Dn6YhOy81kLUehp10dm+ajVws/hxf7YmMTfXu429Basf9H7cTj/B6foeBHn3BMgipfSnCsx9PtibmATPOzW1bunhM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715509592; c=relaxed/simple; bh=+9pJXpQgPt2lHwMONUOemo2q9+iF6WTtWDicG6lMru4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RHvMUXB4k4Ocl5vsjRah5t63uf9jqbtiVADvEspfIDFoiEcsyLQqWWgLuzOe3rOnUSDl1Ywo70FSKYoNbUcmL6M1iWlWZ75mbW/s9GLz/JkA6FEGbEWtR7cERBTnv0YMmXJb471lfH/DfnO/u9K/XuDoLeUjY8CXaqZXgndqxsI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BSLBJ1H0; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BSLBJ1H0" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-5d4d15ec7c5so2935041a12.1; Sun, 12 May 2024 03:26:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715509591; x=1716114391; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lr1WXbRSQZLTTHa7cFPRGYFpMRh1Ph2AIduJlL752P8=; b=BSLBJ1H0xoGDHoKQjJ1zOc8UglikBI1kq/fstGvKHXE5pFR0vS219udOYQHp3pYf+2 K3Hjh51jwxmSggi27AA9pIpYfPOW9tVdF/kPAMJMGKCzruz6XQjTly1iLSbeNC0gGwQ8 uUezUbVzLEBwIUdR9BJjvRGhZP6M7TLD+IYs5WX675SR+9HPWOQ1Nb0D1mD4gTMaKPcs gVjvDdRfuGpP5oRVZXqjnrEPLipfH9AN5RY58xZAU81fhWEMZpIHLsdemT3YYX3g/gXY l2KrvP5+8mSqHS4jD1lX6m0WdYtrL7kbU60ARxr8bQQDnilYEZpPZo1uizrGnU74bKmS CPCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715509591; x=1716114391; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lr1WXbRSQZLTTHa7cFPRGYFpMRh1Ph2AIduJlL752P8=; b=C5dcNbNHYegPxB9/mfplOINM8M8pJ9EGwoe/3hcVjDGhrDb47MZivnNPcAr9Fy5XbW I+aV5SwIpFEqbInZAZ0QxNzV5HAWTz37qZ/4TQL6ZE+HbEXhTKCfHBaPJNEtrCql/wrI Je/9eB7I21Wm6ROYY6Ta9QaKMszo8bDnt0YCtwTP8V79H+FOHCvEOLR2uhjIWhmL1rqZ kzh2TyW2Au+9RbKmswkc/HU9WHVbPDUyY0190CPK9NHrFkA8+ChcQs5yKdxUsfMbe+Ri nPkgnMj1pjI8bqngdHgXsD8gfqKREFDuxM1R0pN/Z0vh/GPIRW4ppuOeudriZudT/IyJ oHyg== X-Forwarded-Encrypted: i=1; AJvYcCUoldMMwgwgU5FmfU027iQJ+8PKfSgloRNwyrVXDTzQc7Pox/EMBED0tyZOJjr37BeinviMxXvhzeL+wfR+sGXnk4XmXVw5spCrBiQ1KFYMK+X2MnXDhYKCS1Q7+IFuwhwxehI= X-Gm-Message-State: AOJu0Yx8E0Py3Hl+0gULubyrbm5SP+qUHXguRc6dUbO0wiWStctDQx0/ FKKkocjSlE+b+Ut0TRpNQutzrANvlLUQ2OQlJek/tjOVlx7Rj8GP X-Google-Smtp-Source: AGHT+IEFgljEemnXmHYaYEZNRwlIHszI6LnaACziDBUoVD9+Ku7bb0vKsVX72jtPhwQgQBbzm6bgrQ== X-Received: by 2002:a17:902:b949:b0:1e4:48e7:3dab with SMTP id d9443c01a7336-1ef43e269ddmr91828255ad.38.1715509590471; Sun, 12 May 2024 03:26:30 -0700 (PDT) Received: from five231003 ([2409:40f0:1038:c113:806e:6d6a:367e:63ce]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bf32b4dsm61454005ad.137.2024.05.12.03.26.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 May 2024 03:26:30 -0700 (PDT) Date: Sun, 12 May 2024 15:56:22 +0530 From: Kousik Sanagavarapu To: kernel test robot Cc: Nishanth Menon , Santosh Shilimkar , Julia Lawall , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Shuah Khan , Javier Carrasco , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/3] soc: ti: knav_qmss_queue: do device_node auto cleanup Message-ID: References: <20240510071432.62913-3-five231003@gmail.com> <202405111846.3m9z398l-lkp@intel.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <202405111846.3m9z398l-lkp@intel.com> On Sat, May 11, 2024 at 06:12:39PM +0800, kernel test robot wrote: > Hi Kousik, > > kernel test robot noticed the following build errors: > [...] > All errors (new ones prefixed by >>): > > >> drivers/soc/ti/knav_qmss_queue.c:1853:3: error: cannot jump from this goto statement to its label > goto err; > ^ > drivers/soc/ti/knav_qmss_queue.c:1855:22: note: jump bypasses initialization of variable with __attribute__((cleanup)) > struct device_node *regions __free(device_node) = > ^ > drivers/soc/ti/knav_qmss_queue.c:1840:3: error: cannot jump from this goto statement to its label > goto err; > ^ > drivers/soc/ti/knav_qmss_queue.c:1855:22: note: jump bypasses initialization of variable with __attribute__((cleanup)) > struct device_node *regions __free(device_node) = > ^ > drivers/soc/ti/knav_qmss_queue.c:1835:3: error: cannot jump from this goto statement to its label > goto err; > ^ > drivers/soc/ti/knav_qmss_queue.c:1855:22: note: jump bypasses initialization of variable with __attribute__((cleanup)) > struct device_node *regions __free(device_node) = > ^ > drivers/soc/ti/knav_qmss_queue.c:1831:3: error: cannot jump from this goto statement to its label > goto err; > ^ > drivers/soc/ti/knav_qmss_queue.c:1855:22: note: jump bypasses initialization of variable with __attribute__((cleanup)) > struct device_node *regions __free(device_node) = > ^ > drivers/soc/ti/knav_qmss_queue.c:1822:4: error: cannot jump from this goto statement to its label > goto err; > ^ > drivers/soc/ti/knav_qmss_queue.c:1855:22: note: jump bypasses initialization of variable with __attribute__((cleanup)) > struct device_node *regions __free(device_node) = > ^ > drivers/soc/ti/knav_qmss_queue.c:1826:22: note: jump bypasses initialization of variable with __attribute__((cleanup)) > struct device_node *queue_pools __free(device_node) = > ^ > drivers/soc/ti/knav_qmss_queue.c:1818:4: error: cannot jump from this goto statement to its label > goto err; > ^ > drivers/soc/ti/knav_qmss_queue.c:1855:22: note: jump bypasses initialization of variable with __attribute__((cleanup)) > struct device_node *regions __free(device_node) = > ^ > drivers/soc/ti/knav_qmss_queue.c:1826:22: note: jump bypasses initialization of variable with __attribute__((cleanup)) > struct device_node *queue_pools __free(device_node) = > ^ > drivers/soc/ti/knav_qmss_queue.c:1810:3: error: cannot jump from this goto statement to its label > goto err; > ^ > drivers/soc/ti/knav_qmss_queue.c:1855:22: note: jump bypasses initialization of variable with __attribute__((cleanup)) > struct device_node *regions __free(device_node) = > ^ > drivers/soc/ti/knav_qmss_queue.c:1826:22: note: jump bypasses initialization of variable with __attribute__((cleanup)) > struct device_node *queue_pools __free(device_node) = > ^ > drivers/soc/ti/knav_qmss_queue.c:1813:22: note: jump bypasses initialization of variable with __attribute__((cleanup)) > struct device_node *pdsps __free(device_node) = > ^ > drivers/soc/ti/knav_qmss_queue.c:1806:3: error: cannot jump from this goto statement to its label > goto err; > ^ > drivers/soc/ti/knav_qmss_queue.c:1855:22: note: jump bypasses initialization of variable with __attribute__((cleanup)) > struct device_node *regions __free(device_node) = > ^ > drivers/soc/ti/knav_qmss_queue.c:1826:22: note: jump bypasses initialization of variable with __attribute__((cleanup)) > struct device_node *queue_pools __free(device_node) = > ^ > drivers/soc/ti/knav_qmss_queue.c:1813:22: note: jump bypasses initialization of variable with __attribute__((cleanup)) > struct device_node *pdsps __free(device_node) = > ^ > drivers/soc/ti/knav_qmss_queue.c:1795:3: error: cannot jump from this goto statement to its label > goto err; > ^ > drivers/soc/ti/knav_qmss_queue.c:1855:22: note: jump bypasses initialization of variable with __attribute__((cleanup)) > struct device_node *regions __free(device_node) = > ^ > drivers/soc/ti/knav_qmss_queue.c:1826:22: note: jump bypasses initialization of variable with __attribute__((cleanup)) > struct device_node *queue_pools __free(device_node) = > ^ > drivers/soc/ti/knav_qmss_queue.c:1813:22: note: jump bypasses initialization of variable with __attribute__((cleanup)) > struct device_node *pdsps __free(device_node) = > ^ > drivers/soc/ti/knav_qmss_queue.c:1801:22: note: jump bypasses initialization of variable with __attribute__((cleanup)) > struct device_node *qmgrs __free(device_node) = > ^ > 9 errors generated. Seems like gcc didn't catch this when I compiled locally. Normally, this would be fixed if we placed braces around the individual initialization blocks, that is, say { struct device_node *qmgrs __free(device_node) = of_get_child_by_name(node, "qmgrs"); ... } That would make the code look a lot more dirty though and is purely unnecessary. So I'd say I'd drop this patch and do a v2 with the remaining two patches. Thoughts? There's also some stuff with classes but that too is not really worth doing because the code will end up looking very ugly. Thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8EFCBC10F1A for ; Sun, 12 May 2024 10:26:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1tdvVQswsrYAtjtfgmJIMn4JhMR0JiekLwe9OWDx+4A=; b=PVvnVm0GRZZ9Me 0jEk6oacRyWwio8eF31C+nb5QdlhbKBmr1aeh+41HOj8jwSo8VnqTu0VuYKz3mQAr9LnuCP7sCLOO SFgGxqd/1UOPhtBzMQ8MgmyCtwgLS/ZPsiEX3nIGEkf6u1nqvYdTZ/0jpTGoGaeBoRDWxmrbXkVEP t9NhCdcY0dwz/cxgy0bzYUwqu2P3pHHEcr5uxf3xp0U98hvj51zu04dU4+rsz+LPMHrf+1FeoD+++ eH3yrLDIedb3+t9/1TgD1UlTtXE7VT5FuzmRCXXV2hh7FbLU6DP/0TI90pGvmiibsRT2Zymcfb/tE wXRi7/nY3Zwfu0UXuebA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s66Pe-00000009jjW-1tzM; Sun, 12 May 2024 10:26:38 +0000 Received: from mail-pg1-x533.google.com ([2607:f8b0:4864:20::533]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s66PZ-00000009jic-3qKr for linux-arm-kernel@lists.infradead.org; Sun, 12 May 2024 10:26:35 +0000 Received: by mail-pg1-x533.google.com with SMTP id 41be03b00d2f7-5d3907ff128so2950096a12.3 for ; Sun, 12 May 2024 03:26:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715509591; x=1716114391; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lr1WXbRSQZLTTHa7cFPRGYFpMRh1Ph2AIduJlL752P8=; b=hH5COmC81Vh4VcIKEp6wz1/WsRUp6XvjLHdJh7lhb6zFr2lD1w50MNQG400PiBxI17 M84xWDmZBiDsMOHWbF7sV7pwhzp+lNEvaYbSZ5m/EMIrNqcfYyIqmh/DTkgWoQINj6Jw emd5GdtkZy8SY08q7nVf25MNuFy98AH9svIWBWxvrkyuZLailSfx+2wrTYfZI5JICjGz SlL90zkMQWEsvgsUySAxW4qCZG9rTa4C9b5uxuXjSRLHnwZRKpJJXE2OjydZknRzvf/8 cllT3TQ9VFT2VEbox6vfhPSwY6QCdGSLCA8aENdIhS/DcZ2RhD75ti9lEfejT2JgpEVz TSxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715509591; x=1716114391; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lr1WXbRSQZLTTHa7cFPRGYFpMRh1Ph2AIduJlL752P8=; b=JwvTUipDXm9/MypDgFZJY9zfmg743QdHPuE3KwzMR0xVnpII5ZxtZoqVfhQ5tTHC6r qKeEY/8grXVIzrxht9GRNruqAZ88vGWv50TczA/VH4XeHHCwG6NFumG4+to3BzPMOk/Q HFWccYlE0jQ3xM2PH8I1XR3C5aAWgDeHbe5QkVPDyT7YfakZSKl74SZ9ENuDxxr4jFaW EuKTw/aVG8ajDoESLjpuhYPVK7oPfU/5H171cNa68u7cxUXMJIcGj6oofbEEJe02urcz 7LbTRUSCUCqf64oBOL0muQbWUykA6vxHshBx5l4muofm9DumP3kvdoctsIaooG+TBUAI 8QEw== X-Forwarded-Encrypted: i=1; AJvYcCXLP0TZA01CadZLDrXkzzg9bU5MIGam2nwpiYjqCj3XTUqTafTVoLZ0EJWRlos5JwiEyuU/plV/9UpK0G8e1anuF0y4DZdr+toh2kcswWAIEBMw73E= X-Gm-Message-State: AOJu0Yw/WqMMr1ZXzBJ70qVp7Ucju21/b+p/kyrGRWcgtnt6dbLsykNa Swm2hqXnlytfqQXqQhCvnd69g2ZzWa+JO+XQhKXr1qcb57XNCu03 X-Google-Smtp-Source: AGHT+IEFgljEemnXmHYaYEZNRwlIHszI6LnaACziDBUoVD9+Ku7bb0vKsVX72jtPhwQgQBbzm6bgrQ== X-Received: by 2002:a17:902:b949:b0:1e4:48e7:3dab with SMTP id d9443c01a7336-1ef43e269ddmr91828255ad.38.1715509590471; Sun, 12 May 2024 03:26:30 -0700 (PDT) Received: from five231003 ([2409:40f0:1038:c113:806e:6d6a:367e:63ce]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bf32b4dsm61454005ad.137.2024.05.12.03.26.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 May 2024 03:26:30 -0700 (PDT) Date: Sun, 12 May 2024 15:56:22 +0530 From: Kousik Sanagavarapu To: kernel test robot Cc: Nishanth Menon , Santosh Shilimkar , Julia Lawall , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Shuah Khan , Javier Carrasco , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/3] soc: ti: knav_qmss_queue: do device_node auto cleanup Message-ID: References: <20240510071432.62913-3-five231003@gmail.com> <202405111846.3m9z398l-lkp@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <202405111846.3m9z398l-lkp@intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240512_032633_987258_D9D007F0 X-CRM114-Status: GOOD ( 14.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, May 11, 2024 at 06:12:39PM +0800, kernel test robot wrote: > Hi Kousik, > > kernel test robot noticed the following build errors: > [...] > All errors (new ones prefixed by >>): > > >> drivers/soc/ti/knav_qmss_queue.c:1853:3: error: cannot jump from this goto statement to its label > goto err; > ^ > drivers/soc/ti/knav_qmss_queue.c:1855:22: note: jump bypasses initialization of variable with __attribute__((cleanup)) > struct device_node *regions __free(device_node) = > ^ > drivers/soc/ti/knav_qmss_queue.c:1840:3: error: cannot jump from this goto statement to its label > goto err; > ^ > drivers/soc/ti/knav_qmss_queue.c:1855:22: note: jump bypasses initialization of variable with __attribute__((cleanup)) > struct device_node *regions __free(device_node) = > ^ > drivers/soc/ti/knav_qmss_queue.c:1835:3: error: cannot jump from this goto statement to its label > goto err; > ^ > drivers/soc/ti/knav_qmss_queue.c:1855:22: note: jump bypasses initialization of variable with __attribute__((cleanup)) > struct device_node *regions __free(device_node) = > ^ > drivers/soc/ti/knav_qmss_queue.c:1831:3: error: cannot jump from this goto statement to its label > goto err; > ^ > drivers/soc/ti/knav_qmss_queue.c:1855:22: note: jump bypasses initialization of variable with __attribute__((cleanup)) > struct device_node *regions __free(device_node) = > ^ > drivers/soc/ti/knav_qmss_queue.c:1822:4: error: cannot jump from this goto statement to its label > goto err; > ^ > drivers/soc/ti/knav_qmss_queue.c:1855:22: note: jump bypasses initialization of variable with __attribute__((cleanup)) > struct device_node *regions __free(device_node) = > ^ > drivers/soc/ti/knav_qmss_queue.c:1826:22: note: jump bypasses initialization of variable with __attribute__((cleanup)) > struct device_node *queue_pools __free(device_node) = > ^ > drivers/soc/ti/knav_qmss_queue.c:1818:4: error: cannot jump from this goto statement to its label > goto err; > ^ > drivers/soc/ti/knav_qmss_queue.c:1855:22: note: jump bypasses initialization of variable with __attribute__((cleanup)) > struct device_node *regions __free(device_node) = > ^ > drivers/soc/ti/knav_qmss_queue.c:1826:22: note: jump bypasses initialization of variable with __attribute__((cleanup)) > struct device_node *queue_pools __free(device_node) = > ^ > drivers/soc/ti/knav_qmss_queue.c:1810:3: error: cannot jump from this goto statement to its label > goto err; > ^ > drivers/soc/ti/knav_qmss_queue.c:1855:22: note: jump bypasses initialization of variable with __attribute__((cleanup)) > struct device_node *regions __free(device_node) = > ^ > drivers/soc/ti/knav_qmss_queue.c:1826:22: note: jump bypasses initialization of variable with __attribute__((cleanup)) > struct device_node *queue_pools __free(device_node) = > ^ > drivers/soc/ti/knav_qmss_queue.c:1813:22: note: jump bypasses initialization of variable with __attribute__((cleanup)) > struct device_node *pdsps __free(device_node) = > ^ > drivers/soc/ti/knav_qmss_queue.c:1806:3: error: cannot jump from this goto statement to its label > goto err; > ^ > drivers/soc/ti/knav_qmss_queue.c:1855:22: note: jump bypasses initialization of variable with __attribute__((cleanup)) > struct device_node *regions __free(device_node) = > ^ > drivers/soc/ti/knav_qmss_queue.c:1826:22: note: jump bypasses initialization of variable with __attribute__((cleanup)) > struct device_node *queue_pools __free(device_node) = > ^ > drivers/soc/ti/knav_qmss_queue.c:1813:22: note: jump bypasses initialization of variable with __attribute__((cleanup)) > struct device_node *pdsps __free(device_node) = > ^ > drivers/soc/ti/knav_qmss_queue.c:1795:3: error: cannot jump from this goto statement to its label > goto err; > ^ > drivers/soc/ti/knav_qmss_queue.c:1855:22: note: jump bypasses initialization of variable with __attribute__((cleanup)) > struct device_node *regions __free(device_node) = > ^ > drivers/soc/ti/knav_qmss_queue.c:1826:22: note: jump bypasses initialization of variable with __attribute__((cleanup)) > struct device_node *queue_pools __free(device_node) = > ^ > drivers/soc/ti/knav_qmss_queue.c:1813:22: note: jump bypasses initialization of variable with __attribute__((cleanup)) > struct device_node *pdsps __free(device_node) = > ^ > drivers/soc/ti/knav_qmss_queue.c:1801:22: note: jump bypasses initialization of variable with __attribute__((cleanup)) > struct device_node *qmgrs __free(device_node) = > ^ > 9 errors generated. Seems like gcc didn't catch this when I compiled locally. Normally, this would be fixed if we placed braces around the individual initialization blocks, that is, say { struct device_node *qmgrs __free(device_node) = of_get_child_by_name(node, "qmgrs"); ... } That would make the code look a lot more dirty though and is purely unnecessary. So I'd say I'd drop this patch and do a v2 with the remaining two patches. Thoughts? There's also some stuff with classes but that too is not really worth doing because the code will end up looking very ugly. Thanks _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel